1. Patchew
  2. EDK2
  3. [edk2-devel] [PATCH v1 0/7] Enable CI in Intel FSP Packages
  4. View patch

[edk2-devel] [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting errors

Michael Kubacki posted 7 patches 3 years, 5 months ago
There is a newer version of this series
[edk2-devel] [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting errors
Posted by Michael Kubacki 3 years, 5 months ago 
From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048

This package did not have CI enabled so code changes were merged
that fail uncrustify formatting. This change updates those files
to include uncustify formatting.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c      | 9 +++++----
 IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c | 2 +-
 IntelFsp2Pkg/Include/Ppi/Variable.h                            | 8 ++++----
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c
index cb2317bfb240..8e24b946cd88 100644
--- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c
+++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c
@@ -193,8 +193,8 @@ DebugBPrint (
 **/
 VOID
 FillHex (
-  UINTN   Value,
-  CHAR8   *Buffer
+  UINTN  Value,
+  CHAR8  *Buffer
   )
 {
   INTN  Idx;
@@ -227,8 +227,8 @@ DebugAssertInternal (
   VOID
   )
 {
-  CHAR8   Buffer[MAX_DEBUG_MESSAGE_LENGTH];
-  UINTN   *Frame;
+  CHAR8  Buffer[MAX_DEBUG_MESSAGE_LENGTH];
+  UINTN  *Frame;
 
   Frame = (UINTN *)GetStackFramePointer ();
 
@@ -250,6 +250,7 @@ DebugAssertInternal (
       sizeof (Buffer) / sizeof (CHAR8) - 1
       );
   }
+
   SerialPortWrite ((UINT8 *)"ASSERT DUMP:\n", 13);
   while (Frame != NULL) {
     FillHex ((UINTN)Frame, Buffer + 9);
diff --git a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c
index 69a021f42b39..a0b2193bdeab 100644
--- a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c
+++ b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c
@@ -31,6 +31,6 @@ SwapStack (
 
   FspData            = GetFspGlobalDataPointer ();
   OldStack           = FspData->CoreStack;
-  FspData->CoreStack = (UINTN) NewStack;
+  FspData->CoreStack = (UINTN)NewStack;
   return OldStack;
 }
diff --git a/IntelFsp2Pkg/Include/Ppi/Variable.h b/IntelFsp2Pkg/Include/Ppi/Variable.h
index 3e1f4b98a999..581f14880813 100644
--- a/IntelFsp2Pkg/Include/Ppi/Variable.h
+++ b/IntelFsp2Pkg/Include/Ppi/Variable.h
@@ -184,10 +184,10 @@ EFI_STATUS
 /// to store data in the PEI environment.
 ///
 struct _EDKII_PEI_VARIABLE_PPI {
-  EDKII_PEI_GET_VARIABLE            GetVariable;
-  EDKII_PEI_GET_NEXT_VARIABLE_NAME  GetNextVariableName;
-  EDKII_PEI_SET_VARIABLE            SetVariable;
-  EDKII_PEI_QUERY_VARIABLE_INFO     QueryVariableInfo;
+  EDKII_PEI_GET_VARIABLE              GetVariable;
+  EDKII_PEI_GET_NEXT_VARIABLE_NAME    GetNextVariableName;
+  EDKII_PEI_SET_VARIABLE              SetVariable;
+  EDKII_PEI_QUERY_VARIABLE_INFO       QueryVariableInfo;
 };
 
 extern EFI_GUID  gEdkiiPeiVariablePpiGuid;
-- 
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93315): https://edk2.groups.io/g/devel/message/93315
Mute This Topic: https://groups.io/mt/93518036/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting errors
Posted by Chiu, Chasel 3 years, 5 months ago 
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> Kubacki
> Sent: Tuesday, September 6, 2022 8:19 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2-devel] [PATCH v1 1/7] IntelFsp2Pkg: Fix code formatting errors
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048
> 
> This package did not have CI enabled so code changes were merged that fail
> uncrustify formatting. This change updates those files to include uncustify
> formatting.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c      | 9 +++++----
>  IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c | 2 +-
>  IntelFsp2Pkg/Include/Ppi/Variable.h                            | 8 ++++----
>  3 files changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c
> b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c
> index cb2317bfb240..8e24b946cd88 100644
> --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c
> +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c
> @@ -193,8 +193,8 @@ DebugBPrint (
>  **/
>  VOID
>  FillHex (
> -  UINTN   Value,
> -  CHAR8   *Buffer
> +  UINTN  Value,
> +  CHAR8  *Buffer
>    )
>  {
>    INTN  Idx;
> @@ -227,8 +227,8 @@ DebugAssertInternal (
>    VOID
>    )
>  {
> -  CHAR8   Buffer[MAX_DEBUG_MESSAGE_LENGTH];
> -  UINTN   *Frame;
> +  CHAR8  Buffer[MAX_DEBUG_MESSAGE_LENGTH];  UINTN  *Frame;
> 
>    Frame = (UINTN *)GetStackFramePointer ();
> 
> @@ -250,6 +250,7 @@ DebugAssertInternal (
>        sizeof (Buffer) / sizeof (CHAR8) - 1
>        );
>    }
> +
>    SerialPortWrite ((UINT8 *)"ASSERT DUMP:\n", 13);
>    while (Frame != NULL) {
>      FillHex ((UINTN)Frame, Buffer + 9); diff --git
> a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c
> b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c
> index 69a021f42b39..a0b2193bdeab 100644
> --- a/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c
> +++ b/IntelFsp2Pkg/Library/BaseFspSwitchStackLib/FspSwitchStackLib.c
> @@ -31,6 +31,6 @@ SwapStack (
> 
>    FspData            = GetFspGlobalDataPointer ();
>    OldStack           = FspData->CoreStack;
> -  FspData->CoreStack = (UINTN) NewStack;
> +  FspData->CoreStack = (UINTN)NewStack;
>    return OldStack;
>  }
> diff --git a/IntelFsp2Pkg/Include/Ppi/Variable.h
> b/IntelFsp2Pkg/Include/Ppi/Variable.h
> index 3e1f4b98a999..581f14880813 100644
> --- a/IntelFsp2Pkg/Include/Ppi/Variable.h
> +++ b/IntelFsp2Pkg/Include/Ppi/Variable.h
> @@ -184,10 +184,10 @@ EFI_STATUS
>  /// to store data in the PEI environment.
>  ///
>  struct _EDKII_PEI_VARIABLE_PPI {
> -  EDKII_PEI_GET_VARIABLE            GetVariable;
> -  EDKII_PEI_GET_NEXT_VARIABLE_NAME  GetNextVariableName;
> -  EDKII_PEI_SET_VARIABLE            SetVariable;
> -  EDKII_PEI_QUERY_VARIABLE_INFO     QueryVariableInfo;
> +  EDKII_PEI_GET_VARIABLE              GetVariable;
> +  EDKII_PEI_GET_NEXT_VARIABLE_NAME    GetNextVariableName;
> +  EDKII_PEI_SET_VARIABLE              SetVariable;
> +  EDKII_PEI_QUERY_VARIABLE_INFO       QueryVariableInfo;
>  };
> 
>  extern EFI_GUID  gEdkiiPeiVariablePpiGuid;
> --
> 2.28.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#93315): https://edk2.groups.io/g/devel/message/93315
> Mute This Topic: https://groups.io/mt/93518036/1777047
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93325): https://edk2.groups.io/g/devel/message/93325
Mute This Topic: https://groups.io/mt/93518036/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.