[v4] CloudHv/arm: Add specific mem info lib

[edk2-devel] [PATCH v4 0/2] CloudHv/arm: Add specific mem info lib

Posted by Jianyong Wu 1 year, 7 months ago

Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the memory
layout for cloud hypervisor is changed, it needs a new meminfo lib.

Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>

Jianyong Wu (2):
  CloudHv/arm: add PeiMemInfoLib
  CloudHv/arm: switch PeiMemLib to its own

 ArmVirtPkg/ArmVirtCloudHv.dsc                 |   2 +-
 .../CloudHvVirtMemInfoLib.c                   | 243 ++++++++++++++++++
 .../CloudHvVirtMemInfoLib.h                   |  42 +++
 .../CloudHvVirtMemInfoPeiLib.inf              |  47 ++++
 4 files changed, 333 insertions(+), 1 deletion(-)
 create mode 100644 ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c
 create mode 100644 ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.h
 create mode 100644 ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoPeiLib.inf

-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93186): https://edk2.groups.io/g/devel/message/93186
Mute This Topic: https://groups.io/mt/93496215/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/2] CloudHv/arm: Add specific mem info lib

Posted by Sami Mujawar 1 year, 7 months ago

Hi Jianyong,

If you push your branch with these patches to Github, then you could do a draft pull request to check that your patches pass the edk2 CI.

I normally include the link for my Github branch in the cover letter. This also helps the reviewer to apply the patches locally, if the mail client damages the patches by changing line breaks etc.

Regards,

Sami Mujawar


On 06/09/2022, 08:39, "Jianyong Wu" <jianyong.wu@arm.com> wrote:

    Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the memory
    layout for cloud hypervisor is changed, it needs a new meminfo lib.

    Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>

    Jianyong Wu (2):
      CloudHv/arm: add PeiMemInfoLib
      CloudHv/arm: switch PeiMemLib to its own

     ArmVirtPkg/ArmVirtCloudHv.dsc                 |   2 +-
     .../CloudHvVirtMemInfoLib.c                   | 243 ++++++++++++++++++
     .../CloudHvVirtMemInfoLib.h                   |  42 +++
     .../CloudHvVirtMemInfoPeiLib.inf              |  47 ++++
     4 files changed, 333 insertions(+), 1 deletion(-)
     create mode 100644 ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c
     create mode 100644 ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.h
     create mode 100644 ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoPeiLib.inf

    --
    2.17.1


IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93189): https://edk2.groups.io/g/devel/message/93189
Mute This Topic: https://groups.io/mt/93496215/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/2] CloudHv/arm: Add specific mem info lib

Posted by Jianyong Wu 1 year, 7 months ago

Thanks Sami,

I have pushed this patch set to GitHub and all the CI passes. The link is https://github.com/tianocore/edk2/pull/3289

Thanks
Jianyong

> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: Tuesday, September 6, 2022 3:46 PM
> To: Jianyong Wu <Jianyong.Wu@arm.com>; devel@edk2.groups.io
> Cc: ardb+tianocore@kernel.org; Justin He <Justin.He@arm.com>
> Subject: Re: [PATCH v4 0/2] CloudHv/arm: Add specific mem info lib
>
> Hi Jianyong,
>
> If you push your branch with these patches to Github, then you could do a
> draft pull request to check that your patches pass the edk2 CI.
>
> I normally include the link for my Github branch in the cover letter. This also
> helps the reviewer to apply the patches locally, if the mail client damages the
> patches by changing line breaks etc.
>
> Regards,
>
> Sami Mujawar
>
>
> On 06/09/2022, 08:39, "Jianyong Wu" <jianyong.wu@arm.com> wrote:
>
>     Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the
> memory
>     layout for cloud hypervisor is changed, it needs a new meminfo lib.
>
>     Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
>
>     Jianyong Wu (2):
>       CloudHv/arm: add PeiMemInfoLib
>       CloudHv/arm: switch PeiMemLib to its own
>
>      ArmVirtPkg/ArmVirtCloudHv.dsc                 |   2 +-
>      .../CloudHvVirtMemInfoLib.c                   | 243 ++++++++++++++++++
>      .../CloudHvVirtMemInfoLib.h                   |  42 +++
>      .../CloudHvVirtMemInfoPeiLib.inf              |  47 ++++
>      4 files changed, 333 insertions(+), 1 deletion(-)
>      create mode 100644
> ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c
>      create mode 100644
> ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.h
>      create mode 100644
> ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoPeiLib.inf
>
>     --
>     2.17.1
>
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93210): https://edk2.groups.io/g/devel/message/93210
Mute This Topic: https://groups.io/mt/93496215/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4 0/2] CloudHv/arm: Add specific mem info lib

Posted by Ard Biesheuvel 1 year, 7 months ago

On Tue, 6 Sept 2022 at 11:07, Jianyong Wu <Jianyong.Wu@arm.com> wrote:
>
> Thanks Sami,
>
> I have pushed this patch set to GitHub and all the CI passes. The link is https://github.com/tianocore/edk2/pull/3289
>

Merged as #3298


>
> > -----Original Message-----
> > From: Sami Mujawar <Sami.Mujawar@arm.com>
> > Sent: Tuesday, September 6, 2022 3:46 PM
> > To: Jianyong Wu <Jianyong.Wu@arm.com>; devel@edk2.groups.io
> > Cc: ardb+tianocore@kernel.org; Justin He <Justin.He@arm.com>
> > Subject: Re: [PATCH v4 0/2] CloudHv/arm: Add specific mem info lib
> >
> > Hi Jianyong,
> >
> > If you push your branch with these patches to Github, then you could do a
> > draft pull request to check that your patches pass the edk2 CI.
> >
> > I normally include the link for my Github branch in the cover letter. This also
> > helps the reviewer to apply the patches locally, if the mail client damages the
> > patches by changing line breaks etc.
> >
> > Regards,
> >
> > Sami Mujawar
> >
> >
> > On 06/09/2022, 08:39, "Jianyong Wu" <jianyong.wu@arm.com> wrote:
> >
> >     Currently, the meminfo lib for CloudHv/arm is reusing QEMU's. As the
> > memory
> >     layout for cloud hypervisor is changed, it needs a new meminfo lib.
> >
> >     Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> >
> >     Jianyong Wu (2):
> >       CloudHv/arm: add PeiMemInfoLib
> >       CloudHv/arm: switch PeiMemLib to its own
> >
> >      ArmVirtPkg/ArmVirtCloudHv.dsc                 |   2 +-
> >      .../CloudHvVirtMemInfoLib.c                   | 243 ++++++++++++++++++
> >      .../CloudHvVirtMemInfoLib.h                   |  42 +++
> >      .../CloudHvVirtMemInfoPeiLib.inf              |  47 ++++
> >      4 files changed, 333 insertions(+), 1 deletion(-)
> >      create mode 100644
> > ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c
> >      create mode 100644
> > ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.h
> >      create mode 100644
> > ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoPeiLib.inf
> >
> >     --
> >     2.17.1
> >
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93244): https://edk2.groups.io/g/devel/message/93244
Mute This Topic: https://groups.io/mt/93496215/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-