[edk2-devel] [PATCH v4 0/6] Enhance DynamicTablesPkg modules

Kun Qin posted 6 patches 1 year, 8 months ago
Failed in applying to current master (apply log)
DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c   | 216 ++++++++++++--------
DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c   | 140 +++++++++++++
DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c    |  80 +++++++-
DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf |   4 +
DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf  |   1 +
5 files changed, 357 insertions(+), 84 deletions(-)
[edk2-devel] [PATCH v4 0/6] Enhance DynamicTablesPkg modules
Posted by Kun Qin 1 year, 8 months ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998

This patch series is a follow-up of previous submission:
https://edk2.groups.io/g/devel/message/91995

The main changes between v3 and v4 patches are:
  - Added reviewed-by collected from previous iteration
  - Fixed an error where the ACPI verification will fail incorrectly
  - Updated ECAM reservation routine with config space based look-up

Current DynamicTablesPkg provide great support for creating dynamic ACPI
tables during boot time.

However, there are some modules needs minor tweaks to expand support and
compatibility for OS requirements and platform needs.

This patch series proposes a few fixes to resolve minor issues discovered
in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.

Patch v4 branch: https://github.com/kuqin12/edk2/tree/dynamic_update_v4

Cc: Joe Lopez <joelopez@microsoft.com>
Cc: Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
Cc: Pierre Gondois <pierre.gondois@arm.com>

Kun Qin (6):
  DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to inf
  DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
  DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
  DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
    tables
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
    space
  DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
    config

 DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c   | 216 ++++++++++++--------
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c   | 140 +++++++++++++
 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c    |  80 +++++++-
 DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf |   4 +
 DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf  |   1 +
 5 files changed, 357 insertions(+), 84 deletions(-)

-- 
2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92312): https://edk2.groups.io/g/devel/message/92312
Mute This Topic: https://groups.io/mt/92947263/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v4 0/6] Enhance DynamicTablesPkg modules
Posted by Sami Mujawar 1 year, 7 months ago
Dropped last patch in this series as discussed at 
https://edk2.groups.io/g/devel/topic/92947269#92984 and tested using 
guest firmware for Kvmtool.

For this series.

Tested-by: Sami Mujawar <sami.mujawar@arm.com>

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 10/08/2022 11:28 pm, Kun Qin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
>
> This patch series is a follow-up of previous submission:
> https://edk2.groups.io/g/devel/message/91995
>
> The main changes between v3 and v4 patches are:
>    - Added reviewed-by collected from previous iteration
>    - Fixed an error where the ACPI verification will fail incorrectly
>    - Updated ECAM reservation routine with config space based look-up
>
> Current DynamicTablesPkg provide great support for creating dynamic ACPI
> tables during boot time.
>
> However, there are some modules needs minor tweaks to expand support and
> compatibility for OS requirements and platform needs.
>
> This patch series proposes a few fixes to resolve minor issues discovered
> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.
>
> Patch v4 branch: https://github.com/kuqin12/edk2/tree/dynamic_update_v4
>
> Cc: Joe Lopez <joelopez@microsoft.com>
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
>
> Kun Qin (6):
>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to inf
>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
>      tables
>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
>      space
>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
>      config
>
>   DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c   | 216 ++++++++++++--------
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c   | 140 +++++++++++++
>   DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c    |  80 +++++++-
>   DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf |   4 +
>   DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf  |   1 +
>   5 files changed, 357 insertions(+), 84 deletions(-)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93035): https://edk2.groups.io/g/devel/message/93035
Mute This Topic: https://groups.io/mt/92947263/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v4 0/6] Enhance DynamicTablesPkg modules
Posted by Kun Qin 1 year, 7 months ago
Hi Sami,

Thank you so much the test and help!

Regards,
Kun

On 9/1/2022 3:17 AM, Sami Mujawar wrote:
> Dropped last patch in this series as discussed at 
> https://edk2.groups.io/g/devel/topic/92947269#92984 and tested using 
> guest firmware for Kvmtool.
>
> For this series.
>
> Tested-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> On 10/08/2022 11:28 pm, Kun Qin wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
>>
>> This patch series is a follow-up of previous submission:
>> https://edk2.groups.io/g/devel/message/91995
>>
>> The main changes between v3 and v4 patches are:
>>    - Added reviewed-by collected from previous iteration
>>    - Fixed an error where the ACPI verification will fail incorrectly
>>    - Updated ECAM reservation routine with config space based look-up
>>
>> Current DynamicTablesPkg provide great support for creating dynamic ACPI
>> tables during boot time.
>>
>> However, there are some modules needs minor tweaks to expand support and
>> compatibility for OS requirements and platform needs.
>>
>> This patch series proposes a few fixes to resolve minor issues 
>> discovered
>> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.
>>
>> Patch v4 branch: https://github.com/kuqin12/edk2/tree/dynamic_update_v4
>>
>> Cc: Joe Lopez <joelopez@microsoft.com>
>> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
>> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>> Cc: Pierre Gondois <pierre.gondois@arm.com>
>>
>> Kun Qin (6):
>>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to 
>> inf
>>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
>>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
>>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
>>      tables
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
>>      space
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
>>      config
>>
>> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c 
>> | 216 ++++++++++++--------
>> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c 
>> | 140 +++++++++++++
>> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c 
>> |  80 +++++++-
>> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf 
>> |   4 +
>> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf 
>> |   1 +
>>   5 files changed, 357 insertions(+), 84 deletions(-)
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93063): https://edk2.groups.io/g/devel/message/93063
Mute This Topic: https://groups.io/mt/92947263/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v4 0/6] Enhance DynamicTablesPkg modules
Posted by Sami Mujawar 1 year, 7 months ago
Merged as 9ca7ece8b3b1..033ba8bb2976

Thanks.

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93040): https://edk2.groups.io/g/devel/message/93040
Mute This Topic: https://groups.io/mt/92947263/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-