[edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support to EDK2

Maciej Czajkowski posted 2 patches 1 week, 3 days ago
Failed in applying to current master (apply log)
MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c    | 505 +++++++++++++-------
MdeModulePkg/Bus/Ata/AhciPei/DevicePath.c |  44 --
MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h    |  57 ++-
MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf  |   5 +-
MdeModulePkg/Include/Ppi/PciDevice.h      |  32 ++
MdeModulePkg/MdeModulePkg.dec             |   3 +
MdeModulePkg/MdeModulePkg.dsc             |   1 +
7 files changed, 425 insertions(+), 222 deletions(-)
create mode 100644 MdeModulePkg/Include/Ppi/PciDevice.h
[edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support to EDK2
Posted by Maciej Czajkowski 1 week, 3 days ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907

The purpose of those changes is to introduce the way to enumerate and assign resources in PEI for the systems with more than one PCI root. 
Here is a need to have an interface that will support such a mechanizm.
For now, the part that performs the enumeration will be implemented in the silicon code.
Sample code can be seen here: https://github.com/mczaj/edk2-platforms/commit/d443062e58f9fba228869b54f2546d9735b3b506

v1: https://edk2.groups.io/g/devel/topic/91575907
v2: https://edk2.groups.io/g/devel/message/91893

v2 changes:
- collected Acked-by tag for no.1 commit
- followed-up with change suggestions in no.2 commit

v3 changes:
- no.1 commit: picked up reviewed-by tag
- no.2 commit: a few fixes based on v2 review

Maciej Czajkowski (2):
  MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition
  MdeModulePkg/AhciPei: Use PCI_DEVICE_PPI to manage AHCI device

 MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c    | 505 +++++++++++++-------
 MdeModulePkg/Bus/Ata/AhciPei/DevicePath.c |  44 --
 MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h    |  57 ++-
 MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf  |   5 +-
 MdeModulePkg/Include/Ppi/PciDevice.h      |  32 ++
 MdeModulePkg/MdeModulePkg.dec             |   3 +
 MdeModulePkg/MdeModulePkg.dsc             |   1 +
 7 files changed, 425 insertions(+), 222 deletions(-)
 create mode 100644 MdeModulePkg/Include/Ppi/PciDevice.h

-- 
2.27.0.windows.1

---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92015): https://edk2.groups.io/g/devel/message/92015
Mute This Topic: https://groups.io/mt/92752847/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support to EDK2
Posted by Wu, Hao A 1 week, 2 days ago
Thanks, the series look good to me. I have given my R-B tag for both of the patches.
Will wait some time to see if there are comments from other reviewers. If no further feedback received, I will merge the series before the end of this week.

Best Regards,
Hao Wu

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Maciej
> Czajkowski
> Sent: Tuesday, August 2, 2022 1:00 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support to
> EDK2
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
> 
> The purpose of those changes is to introduce the way to enumerate and
> assign resources in PEI for the systems with more than one PCI root.
> Here is a need to have an interface that will support such a mechanizm.
> For now, the part that performs the enumeration will be implemented in the
> silicon code.
> Sample code can be seen here: https://github.com/mczaj/edk2-
> platforms/commit/d443062e58f9fba228869b54f2546d9735b3b506
> 
> v1: https://edk2.groups.io/g/devel/topic/91575907
> v2: https://edk2.groups.io/g/devel/message/91893
> 
> v2 changes:
> - collected Acked-by tag for no.1 commit
> - followed-up with change suggestions in no.2 commit
> 
> v3 changes:
> - no.1 commit: picked up reviewed-by tag
> - no.2 commit: a few fixes based on v2 review
> 
> Maciej Czajkowski (2):
>   MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition
>   MdeModulePkg/AhciPei: Use PCI_DEVICE_PPI to manage AHCI device
> 
>  MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c    | 505 +++++++++++++-------
>  MdeModulePkg/Bus/Ata/AhciPei/DevicePath.c |  44 --
>  MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h    |  57 ++-
>  MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf  |   5 +-
>  MdeModulePkg/Include/Ppi/PciDevice.h      |  32 ++
>  MdeModulePkg/MdeModulePkg.dec             |   3 +
>  MdeModulePkg/MdeModulePkg.dsc             |   1 +
>  7 files changed, 425 insertions(+), 222 deletions(-)  create mode 100644
> MdeModulePkg/Include/Ppi/PciDevice.h
> 
> --
> 2.27.0.windows.1
> 
> ---------------------------------------------------------------------
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII
> Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-
> 07-52-316 | Kapital zakladowy 200.000 PLN.
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> adresata i moze zawierac informacje poufne. W razie przypadkowego
> otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale
> jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest
> zabronione.
> This e-mail and any attachments may contain confidential material for the
> sole use of the intended recipient(s). If you are not the intended recipient,
> please contact the sender and delete all copies; any review or distribution by
> others is strictly prohibited.
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92039): https://edk2.groups.io/g/devel/message/92039
Mute This Topic: https://groups.io/mt/92752847/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support to EDK2
Posted by Wu, Hao A 6 days, 22 hours ago
Series merged via:
PR - https://github.com/tianocore/edk2/pull/3176
Commits:
https://github.com/tianocore/edk2/commit/86757f0b4750f672f346d955f89e5b76430ba6b4
https://github.com/tianocore/edk2/commit/a8f59e2eb44199040d2e1f747a6d950a25ed0984

Best Regards,
Hao Wu

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao
> A
> Sent: Tuesday, August 2, 2022 10:21 AM
> To: devel@edk2.groups.io; Czajkowski, Maciej
> <maciej.czajkowski@intel.com>
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI
> support to EDK2
> 
> Thanks, the series look good to me. I have given my R-B tag for both of the
> patches.
> Will wait some time to see if there are comments from other reviewers. If no
> further feedback received, I will merge the series before the end of this
> week.
> 
> Best Regards,
> Hao Wu
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Maciej
> > Czajkowski
> > Sent: Tuesday, August 2, 2022 1:00 AM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support
> > to
> > EDK2
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3907
> >
> > The purpose of those changes is to introduce the way to enumerate and
> > assign resources in PEI for the systems with more than one PCI root.
> > Here is a need to have an interface that will support such a mechanizm.
> > For now, the part that performs the enumeration will be implemented in
> > the silicon code.
> > Sample code can be seen here: https://github.com/mczaj/edk2-
> > platforms/commit/d443062e58f9fba228869b54f2546d9735b3b506
> >
> > v1: https://edk2.groups.io/g/devel/topic/91575907
> > v2: https://edk2.groups.io/g/devel/message/91893
> >
> > v2 changes:
> > - collected Acked-by tag for no.1 commit
> > - followed-up with change suggestions in no.2 commit
> >
> > v3 changes:
> > - no.1 commit: picked up reviewed-by tag
> > - no.2 commit: a few fixes based on v2 review
> >
> > Maciej Czajkowski (2):
> >   MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition
> >   MdeModulePkg/AhciPei: Use PCI_DEVICE_PPI to manage AHCI device
> >
> >  MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c    | 505 +++++++++++++-------
> >  MdeModulePkg/Bus/Ata/AhciPei/DevicePath.c |  44 --
> >  MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h    |  57 ++-
> >  MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf  |   5 +-
> >  MdeModulePkg/Include/Ppi/PciDevice.h      |  32 ++
> >  MdeModulePkg/MdeModulePkg.dec             |   3 +
> >  MdeModulePkg/MdeModulePkg.dsc             |   1 +
> >  7 files changed, 425 insertions(+), 222 deletions(-)  create mode
> > 100644 MdeModulePkg/Include/Ppi/PciDevice.h
> >
> > --
> > 2.27.0.windows.1
> >
> > ---------------------------------------------------------------------
> > Intel Technology Poland sp. z o.o.
> > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII
> > Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP
> > 957-
> > 07-52-316 | Kapital zakladowy 200.000 PLN.
> > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> > adresata i moze zawierac informacje poufne. W razie przypadkowego
> > otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale
> > jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest
> > zabronione.
> > This e-mail and any attachments may contain confidential material for
> > the sole use of the intended recipient(s). If you are not the intended
> > recipient, please contact the sender and delete all copies; any review
> > or distribution by others is strictly prohibited.
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92137): https://edk2.groups.io/g/devel/message/92137
Mute This Topic: https://groups.io/mt/92752847/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-