[v1] BaseTools/GenFds: Correct file type set for the PIC section

[edk2-devel] [PATCH] BaseTools/GenFds: Correct file type set for the PIC section

Konstantin Aladyshev posted 1 patch 1 year, 9 months ago

Diff against v2
Download mbox

Failed in applying to current master (apply log)

There is a newer version of this series

BaseTools/Source/Python/GenFds/FdfParser.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[edk2-devel] [PATCH] BaseTools/GenFds: Correct file type set for the PIC section

Posted by Konstantin Aladyshev 1 year, 9 months ago

Corrently the set of file types for the PIC section contains two
duplicate values.
Replace the duplicate value with the correct one to fix the issue.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 BaseTools/Source/Python/GenFds/FdfParser.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py b/BaseTools/Source/Python/GenFds/FdfParser.py
index aa18fef09e..a9a14ca2bb 100644
--- a/BaseTools/Source/Python/GenFds/FdfParser.py
+++ b/BaseTools/Source/Python/GenFds/FdfParser.py
@@ -4018,7 +4018,7 @@ class FdfParser:
             if FileType not in {BINARY_FILE_TYPE_PE32, "SEC_PE32"}:
                 raise Warning(WarningString % FileType, self.FileName, self.CurrentLineNumber)
         elif SectionType == BINARY_FILE_TYPE_PIC:
-            if FileType not in {BINARY_FILE_TYPE_PIC, BINARY_FILE_TYPE_PIC}:
+            if FileType not in {BINARY_FILE_TYPE_PIC, "SEC_PIC"}:
                 raise Warning(WarningString % FileType, self.FileName, self.CurrentLineNumber)
         elif SectionType == BINARY_FILE_TYPE_TE:
             if FileType not in {BINARY_FILE_TYPE_TE, "SEC_TE"}:
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91813): https://edk2.groups.io/g/devel/message/91813
Mute This Topic: https://groups.io/mt/92607300/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-