Set HoleLen to UINT64 to perform safe cast to UINTN in ternary operator
at WasRead assignment

Cc: Marvin Häuser <mhaeuser@posteo.de>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>
Signed-off-by: Savva Mitrofanov <savvamtr@gmail.com>
---
 Features/Ext4Pkg/Ext4Dxe/Inode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Features/Ext4Pkg/Ext4Dxe/Inode.c b/Features/Ext4Pkg/Ext4Dxe/Inode.c
index 142ee6e3d78a..6416f5388486 100644
--- a/Features/Ext4Pkg/Ext4Dxe/Inode.c
+++ b/Features/Ext4Pkg/Ext4Dxe/Inode.c
@@ -100,7 +100,7 @@ Ext4Read (
   EFI_STATUS   Status;

   BOOLEAN      HasBackingExtent;

   UINT32       HoleOff;

-  UINTN        HoleLen;

+  UINT64       HoleLen;

   UINT64       ExtentStartBytes;

   UINT64       ExtentLengthBytes;

   UINT64       ExtentLogicalBytes;

@@ -155,7 +155,7 @@ Ext4Read (
         HoleLen = (Ext4GetExtentLength (&Extent) * Partition->BlockSize) - HoleOff;

       }

 

-      WasRead = HoleLen > RemainingRead ? RemainingRead : HoleLen;

+      WasRead = HoleLen > RemainingRead ? RemainingRead : (UINTN) HoleLen;

       // Potential improvement: In the future, we could get the file hole's total

       // size and memset all that

       ZeroMem (Buffer, WasRead);

-- 
2.37.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91648): https://edk2.groups.io/g/devel/message/91648
Mute This Topic: https://groups.io/mt/92531464/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-