[v2] Remove all UGA support

[edk2-devel] [Patch v2 02/11] ArmVirtPkg: Remove All UGA Support

Posted by Guomin Jiang 3 years, 6 months ago

From: GuoMinJ <newexplorerj@gmail.com>

REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368

Remove PcdConOutGopSupport, it is unnecessary any more.
Remove All UGA Support in ArmVirtPkg

Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
---
 ArmVirtPkg/ArmVirtQemu.dsc       | 7 +------
 ArmVirtPkg/ArmVirtQemuKernel.dsc | 7 +------
 2 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
index 9369a88858fd..dc87050f3f3a 100644
--- a/ArmVirtPkg/ArmVirtQemu.dsc
+++ b/ArmVirtPkg/ArmVirtQemu.dsc
@@ -1,7 +1,7 @@
 #
 #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
 #  Copyright (c) 2014, Linaro Limited. All rights reserved.
-#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
+#  Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -125,11 +125,6 @@
   gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
   gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
 
-  ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
-  #  It could be set FALSE to save size.
-  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
-  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
-
   gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
 
   gArmVirtTokenSpaceGuid.PcdTpm2SupportEnabled|$(TPM2_ENABLE)
diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
index 7f7d15d6eee3..0d13d8edb407 100644
--- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
+++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
@@ -1,7 +1,7 @@
 #
 #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
 #  Copyright (c) 2014, Linaro Limited. All rights reserved.
-#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
+#  Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -107,11 +107,6 @@
   gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
   gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
 
-  ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
-  #  It could be set FALSE to save size.
-  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
-  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
-
   gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
 
 [PcdsFixedAtBuild.common]
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91396): https://edk2.groups.io/g/devel/message/91396
Mute This Topic: https://groups.io/mt/92393243/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v2 02/11] ArmVirtPkg: Remove All UGA Support

Posted by Sami Mujawar 3 years, 6 months ago

Hi Guomin,

Thank you for this patch.

Please find my response inline marked [SAMI].

Regards,

Sami Mujawar

On 15/07/2022 02:50 am, Guomin Jiang wrote:
> From: GuoMinJ <newexplorerj@gmail.com>
>
> REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
>
> Remove PcdConOutGopSupport, it is unnecessary any more.
> Remove All UGA Support in ArmVirtPkg
>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   ArmVirtPkg/ArmVirtQemu.dsc       | 7 +------
>   ArmVirtPkg/ArmVirtQemuKernel.dsc | 7 +------
>   2 files changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 9369a88858fd..dc87050f3f3a 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -1,7 +1,7 @@
>   #
>   #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
>   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
> -#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
> +#  Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -125,11 +125,6 @@
>     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
>     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
>   
> -  ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> -  #  It could be set FALSE to save size.
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE

[SAMI] I am assuming PcdConOutGopSupport is going to be removed. Can you 
confiirm, please?

I am not sure I am looking at the right pull request. But the patch at 
https://github.com/tianocore/edk2/pull/290/commits/49838844df66826c5d09a2dad075dfe0d37ee709#diff-6bdd1bc5bd7bacf61a4499e556ae002cbc49fc24c19e424fdf544d91e163bbb8 
does not seem to drop it.

Also the subject line for the commit is same as for the patch at 
https://edk2.groups.io/g/devel/message/91390 in this series.

[/SAMI]

> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> -
>     gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
>   
>     gArmVirtTokenSpaceGuid.PcdTpm2SupportEnabled|$(TPM2_ENABLE)
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index 7f7d15d6eee3..0d13d8edb407 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -1,7 +1,7 @@
>   #
>   #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
>   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
> -#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
> +#  Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
>   #
>   #  SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
> @@ -107,11 +107,6 @@
>     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
>     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
>   
> -  ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
> -  #  It could be set FALSE to save size.
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> -
>     gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
>   
>   [PcdsFixedAtBuild.common]


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91411): https://edk2.groups.io/g/devel/message/91411
Mute This Topic: https://groups.io/mt/92393243/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v2 02/11] ArmVirtPkg: Remove All UGA Support

Posted by Guomin Jiang 3 years, 6 months ago

Hi Sami,

I am sure that the PcdConOutGopSupport will being removed.

We will keep it in dec file temporarily because some downstream project still need it
First we will remove all related code except definition and header
Second we will highlight it and downstream should remove all related code in their project
Last we will remove the definition and header and all UGA will be clean totally.

Thanks
Guomin
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami
> Mujawar
> Sent: Friday, July 15, 2022 5:42 PM
> To: Jiang, Guomin <guomin.jiang@intel.com>; devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Leif Lindholm <leif@nuviainc.com>; Gerd
> Hoffmann <kraxel@redhat.com>; nd@arm.com
> Subject: Re: [edk2-devel] [Patch v2 02/11] ArmVirtPkg: Remove All UGA
> Support
> 
> Hi Guomin,
> 
> Thank you for this patch.
> 
> Please find my response inline marked [SAMI].
> 
> Regards,
> 
> Sami Mujawar
> 
> On 15/07/2022 02:50 am, Guomin Jiang wrote:
> > From: GuoMinJ <newexplorerj@gmail.com>
> >
> > REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
> >
> > Remove PcdConOutGopSupport, it is unnecessary any more.
> > Remove All UGA Support in ArmVirtPkg
> >
> > Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >   ArmVirtPkg/ArmVirtQemu.dsc       | 7 +------
> >   ArmVirtPkg/ArmVirtQemuKernel.dsc | 7 +------
> >   2 files changed, 2 insertions(+), 12 deletions(-)
> >
> > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> > index 9369a88858fd..dc87050f3f3a 100644
> > --- a/ArmVirtPkg/ArmVirtQemu.dsc
> > +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> > @@ -1,7 +1,7 @@
> >   #
> >   #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
> >   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
> > -#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
> > +#  Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
> >   #
> >   #  SPDX-License-Identifier: BSD-2-Clause-Patent
> >   #
> > @@ -125,11 +125,6 @@
> >     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
> >
> gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
> >
> > -  ## If TRUE, Graphics Output Protocol will be installed on virtual handle
> created by ConsplitterDxe.
> > -  #  It could be set FALSE to save size.
> > -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> 
> [SAMI] I am assuming PcdConOutGopSupport is going to be removed. Can
> you confiirm, please?
> 
> I am not sure I am looking at the right pull request. But the patch at
> https://github.com/tianocore/edk2/pull/290/commits/49838844df66826c5d0
> 9a2dad075dfe0d37ee709#diff-
> 6bdd1bc5bd7bacf61a4499e556ae002cbc49fc24c19e424fdf544d91e163bbb8
> does not seem to drop it.
> 
> Also the subject line for the commit is same as for the patch at
> https://edk2.groups.io/g/devel/message/91390 in this series.
> 
> [/SAMI]
> 
> > -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> > -
> >
> gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
> >
> >     gArmVirtTokenSpaceGuid.PcdTpm2SupportEnabled|$(TPM2_ENABLE)
> > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> > b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> > index 7f7d15d6eee3..0d13d8edb407 100644
> > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> > @@ -1,7 +1,7 @@
> >   #
> >   #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
> >   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
> > -#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
> > +#  Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
> >   #
> >   #  SPDX-License-Identifier: BSD-2-Clause-Patent
> >   #
> > @@ -107,11 +107,6 @@
> >     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
> >
> gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
> >
> > -  ## If TRUE, Graphics Output Protocol will be installed on virtual handle
> created by ConsplitterDxe.
> > -  #  It could be set FALSE to save size.
> > -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> > -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
> > -
> >
> gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
> >
> >   [PcdsFixedAtBuild.common]
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91444): https://edk2.groups.io/g/devel/message/91444
Mute This Topic: https://groups.io/mt/92393243/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v2 02/11] ArmVirtPkg: Remove All UGA Support

Posted by Sami Mujawar 3 years, 6 months ago

Hi Guomin,

Thank you for confirming.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 18/07/2022, 13:24, "Jiang, Guomin" <guomin.jiang@intel.com> wrote:

    Hi Sami,

    I am sure that the PcdConOutGopSupport will being removed.

    We will keep it in dec file temporarily because some downstream project still need it
    First we will remove all related code except definition and header
    Second we will highlight it and downstream should remove all related code in their project
    Last we will remove the definition and header and all UGA will be clean totally.

    Thanks
    Guomin
    > -----Original Message-----
    > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sami
    > Mujawar
    > Sent: Friday, July 15, 2022 5:42 PM
    > To: Jiang, Guomin <guomin.jiang@intel.com>; devel@edk2.groups.io
    > Cc: GuoMinJ <newexplorerj@gmail.com>; Ard Biesheuvel
    > <ardb+tianocore@kernel.org>; Leif Lindholm <leif@nuviainc.com>; Gerd
    > Hoffmann <kraxel@redhat.com>; nd@arm.com
    > Subject: Re: [edk2-devel] [Patch v2 02/11] ArmVirtPkg: Remove All UGA
    > Support
    > 
    > Hi Guomin,
    > 
    > Thank you for this patch.
    > 
    > Please find my response inline marked [SAMI].
    > 
    > Regards,
    > 
    > Sami Mujawar
    > 
    > On 15/07/2022 02:50 am, Guomin Jiang wrote:
    > > From: GuoMinJ <newexplorerj@gmail.com>
    > >
    > > REF: https//bugzilla.tianocore.org/show_bug.cgi?id=2368
    > >
    > > Remove PcdConOutGopSupport, it is unnecessary any more.
    > > Remove All UGA Support in ArmVirtPkg
    > >
    > > Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
    > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
    > > Cc: Leif Lindholm <leif@nuviainc.com>
    > > Cc: Sami Mujawar <sami.mujawar@arm.com>
    > > Cc: Gerd Hoffmann <kraxel@redhat.com>
    > > ---
    > >   ArmVirtPkg/ArmVirtQemu.dsc       | 7 +------
    > >   ArmVirtPkg/ArmVirtQemuKernel.dsc | 7 +------
    > >   2 files changed, 2 insertions(+), 12 deletions(-)
    > >
    > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
    > > index 9369a88858fd..dc87050f3f3a 100644
    > > --- a/ArmVirtPkg/ArmVirtQemu.dsc
    > > +++ b/ArmVirtPkg/ArmVirtQemu.dsc
    > > @@ -1,7 +1,7 @@
    > >   #
    > >   #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
    > >   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
    > > -#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
    > > +#  Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
    > >   #
    > >   #  SPDX-License-Identifier: BSD-2-Clause-Patent
    > >   #
    > > @@ -125,11 +125,6 @@
    > >     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
    > >
    > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
    > >
    > > -  ## If TRUE, Graphics Output Protocol will be installed on virtual handle
    > created by ConsplitterDxe.
    > > -  #  It could be set FALSE to save size.
    > > -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
    > 
    > [SAMI] I am assuming PcdConOutGopSupport is going to be removed. Can
    > you confiirm, please?
    > 
    > I am not sure I am looking at the right pull request. But the patch at
    > https://github.com/tianocore/edk2/pull/290/commits/49838844df66826c5d0
    > 9a2dad075dfe0d37ee709#diff-
    > 6bdd1bc5bd7bacf61a4499e556ae002cbc49fc24c19e424fdf544d91e163bbb8
    > does not seem to drop it.
    > 
    > Also the subject line for the commit is same as for the patch at
    > https://edk2.groups.io/g/devel/message/91390 in this series.
    > 
    > [/SAMI]
    > 
    > > -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
    > > -
    > >
    > gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
    > >
    > >     gArmVirtTokenSpaceGuid.PcdTpm2SupportEnabled|$(TPM2_ENABLE)
    > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc
    > > b/ArmVirtPkg/ArmVirtQemuKernel.dsc
    > > index 7f7d15d6eee3..0d13d8edb407 100644
    > > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
    > > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
    > > @@ -1,7 +1,7 @@
    > >   #
    > >   #  Copyright (c) 2011-2015, ARM Limited. All rights reserved.
    > >   #  Copyright (c) 2014, Linaro Limited. All rights reserved.
    > > -#  Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
    > > +#  Copyright (c) 2015 - 2022, Intel Corporation. All rights reserved.
    > >   #
    > >   #  SPDX-License-Identifier: BSD-2-Clause-Patent
    > >   #
    > > @@ -107,11 +107,6 @@
    > >     gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
    > >
    > gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
    > >
    > > -  ## If TRUE, Graphics Output Protocol will be installed on virtual handle
    > created by ConsplitterDxe.
    > > -  #  It could be set FALSE to save size.
    > > -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
    > > -  gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
    > > -
    > >
    > gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
    > >
    > >   [PcdsFixedAtBuild.common]
    > 
    > 
    > 
    > 




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91473): https://edk2.groups.io/g/devel/message/91473
Mute This Topic: https://groups.io/mt/92393243/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-