[v3] Fix build breaks and update IORT revision macro

[edk2-devel] [PATCH edk2-platforms v3 03/12] Platform/ARM: SGI: Update for IORT revision macro renaming

Posted by Sami Mujawar 3 years, 7 months ago

The IORT Specification E.d updates the IORT table revision to 5. To
reflect this change the IORT header file has been updated to rename
the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
macro in the IORT table for SGI platforms to
EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
 Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
index fcc28a71c82eb0c78c96d60c9d9eb1554adb41a3..a7ad92622a905f5b1fd725d5d673a2643685f9af 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
+++ b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
@@ -50,7 +50,7 @@ ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort =
      (
        EFI_ACPI_6_2_IO_REMAPPING_TABLE_SIGNATURE,
        ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE,
-       EFI_ACPI_IO_REMAPPING_TABLE_REVISION
+       EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00
      ),
      3,  // NumNodes
      sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),  // NodeOffset
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91272): https://edk2.groups.io/g/devel/message/91272
Mute This Topic: https://groups.io/mt/92334294/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms v3 03/12] Platform/ARM: SGI: Update for IORT revision macro renaming

Posted by Thomas Abraham 3 years, 7 months ago


On 12/07/2022 15:40, Sami Mujawar wrote:
> The IORT Specification E.d updates the IORT table revision to 5. To
> reflect this change the IORT header file has been updated to rename
> the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
> 
> Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
> macro in the IORT table for SGI platforms to
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>   Platform/ARM/SgiPkg/AcpiTables/Iort.aslc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
> index fcc28a71c82eb0c78c96d60c9d9eb1554adb41a3..a7ad92622a905f5b1fd725d5d673a2643685f9af 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
> +++ b/Platform/ARM/SgiPkg/AcpiTables/Iort.aslc
> @@ -50,7 +50,7 @@ ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort =
>        (
>          EFI_ACPI_6_2_IO_REMAPPING_TABLE_SIGNATURE,
>          ARM_EFI_ACPI_6_0_IO_REMAPPING_TABLE,
> -       EFI_ACPI_IO_REMAPPING_TABLE_REVISION
> +       EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00
>        ),
>        3,  // NumNodes
>        sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),  // NodeOffset

Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>

Thanks.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91349): https://edk2.groups.io/g/devel/message/91349
Mute This Topic: https://groups.io/mt/92334294/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-