From: Gua Guo <gua.guo@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3933

URL: https://universalpayload.github.io/documentation/

1. Currently, SpecRevision on USF spec is 0.7. Change to align it.
2. SpecRevision is not be patched into UniversalPayloadInfo.bin due to
different structure item name. Change item name from "HeaderRevision"
 to "SpecRevision" to check the correct value can be patched.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
---
 UefiPayloadPkg/UniversalPayloadBuild.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py
index b7fd1505b6..089d631b51 100644
--- a/UefiPayloadPkg/UniversalPayloadBuild.py
+++ b/UefiPayloadPkg/UniversalPayloadBuild.py
@@ -31,7 +31,7 @@ class UPLD_INFO_HEADER(LittleEndianStructure):
     def __init__(self):
         self.Identifier     =  b'PLDH'
         self.HeaderLength   = sizeof(UPLD_INFO_HEADER)
-        self.HeaderRevision = 0x0075
+        self.SpecRevision   = 0x0007
         self.Revision       = 0x0000010105
         self.ImageId        = b'UEFI'
         self.ProducerId     = b'INTEL'
-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90055): https://edk2.groups.io/g/devel/message/90055
Mute This Topic: https://groups.io/mt/91354494/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Reviewed-by: Guo Dong <guo.dong@intel.com>

-----Original Message-----
From: Guo, Gua <gua.guo@intel.com> 
Sent: Thursday, May 26, 2022 5:14 AM
To: devel@edk2.groups.io
Cc: Guo, Gua <gua.guo@intel.com>; Ni, Ray <ray.ni@intel.com>; Dong, Guo <guo.dong@intel.com>
Subject: [PATCH 3/3] UefiPayloadPkg: Align SpecRevision value with UPL spec

From: Gua Guo <gua.guo@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3933

URL: https://universalpayload.github.io/documentation/

1. Currently, SpecRevision on USF spec is 0.7. Change to align it.
2. SpecRevision is not be patched into UniversalPayloadInfo.bin due to different structure item name. Change item name from "HeaderRevision"
 to "SpecRevision" to check the correct value can be patched.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
---
 UefiPayloadPkg/UniversalPayloadBuild.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py
index b7fd1505b6..089d631b51 100644
--- a/UefiPayloadPkg/UniversalPayloadBuild.py
+++ b/UefiPayloadPkg/UniversalPayloadBuild.py
@@ -31,7 +31,7 @@ class UPLD_INFO_HEADER(LittleEndianStructure):
     def __init__(self):         self.Identifier     =  b'PLDH'         self.HeaderLength   = sizeof(UPLD_INFO_HEADER)-        self.HeaderRevision = 0x0075+        self.SpecRevision   = 0x0007         self.Revision       = 0x0000010105         self.ImageId        = b'UEFI'         self.ProducerId     = b'INTEL'-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90083): https://edk2.groups.io/g/devel/message/90083
Mute This Topic: https://groups.io/mt/91354494/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Thursday, May 26, 2022 8:14 PM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>; Ni, Ray <ray.ni@intel.com>; Dong, Guo <guo.dong@intel.com>
> Subject: [PATCH 3/3] UefiPayloadPkg: Align SpecRevision value with UPL spec
> 
> From: Gua Guo <gua.guo@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3933
> 
> URL: https://universalpayload.github.io/documentation/
> 
> 1. Currently, SpecRevision on USF spec is 0.7. Change to align it.
> 2. SpecRevision is not be patched into UniversalPayloadInfo.bin due to
> different structure item name. Change item name from "HeaderRevision"
>  to "SpecRevision" to check the correct value can be patched.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
>  UefiPayloadPkg/UniversalPayloadBuild.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py
> index b7fd1505b6..089d631b51 100644
> --- a/UefiPayloadPkg/UniversalPayloadBuild.py
> +++ b/UefiPayloadPkg/UniversalPayloadBuild.py
> @@ -31,7 +31,7 @@ class UPLD_INFO_HEADER(LittleEndianStructure):
>      def __init__(self):
> 
>          self.Identifier     =  b'PLDH'
> 
>          self.HeaderLength   = sizeof(UPLD_INFO_HEADER)
> 
> -        self.HeaderRevision = 0x0075
> 
> +        self.SpecRevision   = 0x0007
> 
>          self.Revision       = 0x0000010105
> 
>          self.ImageId        = b'UEFI'
> 
>          self.ProducerId     = b'INTEL'
> 
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90043): https://edk2.groups.io/g/devel/message/90043
Mute This Topic: https://groups.io/mt/91352868/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-