[edk2-devel] [PATCH] .pytool: Fix python command error in self introduction doc

Chao Li posted 1 patch 1 month ago
Failed in applying to current master (apply log)
.pytool/Readme.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[edk2-devel] [PATCH] .pytool: Fix python command error in self introduction doc
Posted by Chao Li 1 month ago
Fix misspelling of word "Prerequisites".

In the step 5 of the Prerequisites section, the python command was missing
the "-r" option, what the command really meant was to install from the given
requirements file, so fix that.

Cc: sean.brogan@microsoft.com
Cc: Bret.Barkelew@microsoft.com
Cc: michael.d.kinney@intel.com
Cc: gaoliming@byosoft.com.cn

Signed-off-by: Chao Li <lichao@loongson.cn>
---
 .pytool/Readme.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index e0d07f3170..9c7b7f9abb 100644
--- a/.pytool/Readme.md
+++ b/.pytool/Readme.md
@@ -82,7 +82,7 @@ easily and consistently running locally and in a cloud ci environment.  To do
 that a few steps should be followed.  Details of EDKII Tools can be found in the
 [docs folder here](https://github.com/tianocore/edk2-pytool-extensions/tree/master/docs)
 
-### Prerequisets
+### Prerequisites
 
 1. A supported toolchain (others might work but this is what is tested and validated)
    * Windows 10:
@@ -95,7 +95,7 @@ that a few steps should be followed.  Details of EDKII Tools can be found in the
 2. Python 3.7.x or newer on path
 3. git on path
 4. Recommended to setup and activate a python virtual environment
-5. Install the requirements `pip install --upgrade pip-requirements.txt`
+5. Install the requirements `pip install --upgrade -r pip-requirements.txt`
 
 ### Running CI
 
-- 
2.27.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89217): https://edk2.groups.io/g/devel/message/89217
Mute This Topic: https://groups.io/mt/90623543/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] 回复: [PATCH] .pytool: Fix python command error in self introduction doc
Posted by gaoliming 4 weeks, 1 day ago
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Chao Li <lichao@loongson.cn>
> 发送时间: 2022年4月22日 15:44
> 收件人: devel@edk2.groups.io
> 抄送: sean.brogan@microsoft.com; Bret.Barkelew@microsoft.com;
> michael.d.kinney@intel.com; gaoliming@byosoft.com.cn
> 主题: [PATCH] .pytool: Fix python command error in self introduction doc
> 
> Fix misspelling of word "Prerequisites".
> 
> In the step 5 of the Prerequisites section, the python command was missing
> the "-r" option, what the command really meant was to install from the
given
> requirements file, so fix that.
> 
> Cc: sean.brogan@microsoft.com
> Cc: Bret.Barkelew@microsoft.com
> Cc: michael.d.kinney@intel.com
> Cc: gaoliming@byosoft.com.cn
> 
> Signed-off-by: Chao Li <lichao@loongson.cn>
> ---
>  .pytool/Readme.md | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.pytool/Readme.md b/.pytool/Readme.md
> index e0d07f3170..9c7b7f9abb 100644
> --- a/.pytool/Readme.md
> +++ b/.pytool/Readme.md
> @@ -82,7 +82,7 @@ easily and consistently running locally and in a cloud
ci
> environment.  To do
>  that a few steps should be followed.  Details of EDKII Tools can be found
in
> the
> 
>  [docs folder
> here](https://github.com/tianocore/edk2-pytool-extensions/tree/master/doc
> s)
> 
> 
> 
> -### Prerequisets
> 
> +### Prerequisites
> 
> 
> 
>  1. A supported toolchain (others might work but this is what is tested
and
> validated)
> 
>     * Windows 10:
> 
> @@ -95,7 +95,7 @@ that a few steps should be followed.  Details of EDKII
> Tools can be found in the
>  2. Python 3.7.x or newer on path
> 
>  3. git on path
> 
>  4. Recommended to setup and activate a python virtual environment
> 
> -5. Install the requirements `pip install --upgrade pip-requirements.txt`
> 
> +5. Install the requirements `pip install --upgrade -r
pip-requirements.txt`
> 
> 
> 
>  ### Running CI
> 
> 
> 
> --
> 2.27.0





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89248): https://edk2.groups.io/g/devel/message/89248
Mute This Topic: https://groups.io/mt/90676375/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-