ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 48 +++++ ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 188 ++++++++++++++++++++ ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 167 +++++++++++------ 3 files changed, 348 insertions(+), 55 deletions(-)
Hi, Sorry for the delayed reply. I had updated the patch according to the review comments. Please review the updated patch. REF: https://github.com/abdattar/edk2/tree/FadtFlagsParserV5 Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Cc: Sami Mujawar <sami.mujawar@arm.com> Abdul Lateef Attar (2): ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser ShellPkg/AcpiView: PrintFormatter for FADT Flags field ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 48 +++++ ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 188 ++++++++++++++++++++ ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 167 +++++++++++------ 3 files changed, 348 insertions(+), 55 deletions(-) -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86705): https://edk2.groups.io/g/devel/message/86705 Mute This Topic: https://groups.io/mt/89182985/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Patchset Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Thanks, Zhichao > -----Original Message----- > From: Abdul Lateef Attar <abdattar@amd.com> > Sent: Wednesday, February 16, 2022 7:14 PM > To: devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Sami > Mujawar <sami.mujawar@arm.com> > Subject: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield > parser > > Hi, > Sorry for the delayed reply. > I had updated the patch according to the review comments. > Please review the updated patch. > > REF: https://github.com/abdattar/edk2/tree/FadtFlagsParserV5 > > > Cc: Ray Ni <ray.ni@intel.com> > Cc: Zhichao Gao <zhichao.gao@intel.com> > Cc: Sami Mujawar <sami.mujawar@arm.com> > > Abdul Lateef Attar (2): > ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser > ShellPkg/AcpiView: PrintFormatter for FADT Flags field > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 48 > +++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 188 > ++++++++++++++++++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > | 167 +++++++++++------ > 3 files changed, 348 insertions(+), 55 deletions(-) > > -- > 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86825): https://edk2.groups.io/g/devel/message/86825 Mute This Topic: https://groups.io/mt/89182985/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Gentle reminder for PR. -----Original Message----- From: Gao, Zhichao <zhichao.gao@intel.com> Sent: Monday, February 21, 2022 1:10 PM To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; devel@edk2.groups.io Cc: Ni, Ray <ray.ni@intel.com>; Sami Mujawar <sami.mujawar@arm.com> Subject: RE: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser [CAUTION: External Email] Patchset Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Thanks, Zhichao > -----Original Message----- > From: Abdul Lateef Attar <abdattar@amd.com> > Sent: Wednesday, February 16, 2022 7:14 PM > To: devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; > Sami Mujawar <sami.mujawar@arm.com> > Subject: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield > parser > > Hi, > Sorry for the delayed reply. > I had updated the patch according to the review comments. > Please review the updated patch. > > REF: > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Fabdattar%2Fedk2%2Ftree%2FFadtFlagsParserV5&data=04%7C01%7 > CAbdulLateef.Attar%40amd.com%7Cdbcced5d461947c4c52908d9f50d60e9%7C3dd8 > 961fe4884e608e11a82d994e183d%7C0%7C0%7C637810260090713957%7CUnknown%7C > TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC > I6Mn0%3D%7C3000&sdata=lqrY9GyWZTJl%2BsRa%2F223ft8ei5rKBbm36av4SQh4 > l9g%3D&reserved=0 > > > Cc: Ray Ni <ray.ni@intel.com> > Cc: Zhichao Gao <zhichao.gao@intel.com> > Cc: Sami Mujawar <sami.mujawar@arm.com> > > Abdul Lateef Attar (2): > ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser > ShellPkg/AcpiView: PrintFormatter for FADT Flags field > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 48 > +++++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 188 > ++++++++++++++++++++ > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > | 167 +++++++++++------ > 3 files changed, 348 insertions(+), 55 deletions(-) > > -- > 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87672): https://edk2.groups.io/g/devel/message/87672 Mute This Topic: https://groups.io/mt/89182985/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Sorry. I forgot to update. I have create the PR twice but the open-CI failed. Can you check? https://github.com/tianocore/edk2/pull/2568 Thanks, Zhichao > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com> > Sent: Thursday, March 17, 2022 3:10 PM > To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com>; Sami Mujawar <sami.mujawar@arm.com> > Subject: RE: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield > parser > > Gentle reminder for PR. > > -----Original Message----- > From: Gao, Zhichao <zhichao.gao@intel.com> > Sent: Monday, February 21, 2022 1:10 PM > To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; > devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com>; Sami Mujawar <sami.mujawar@arm.com> > Subject: RE: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield > parser > > [CAUTION: External Email] > > Patchset Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> > > Thanks, > Zhichao > > > -----Original Message----- > > From: Abdul Lateef Attar <abdattar@amd.com> > > Sent: Wednesday, February 16, 2022 7:14 PM > > To: devel@edk2.groups.io > > Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; > > Sami Mujawar <sami.mujawar@arm.com> > > Subject: [PATCH v5 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield > > parser > > > > Hi, > > Sorry for the delayed reply. > > I had updated the patch according to the review comments. > > Please review the updated patch. > > > > REF: > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > > > ub.com%2Fabdattar%2Fedk2%2Ftree%2FFadtFlagsParserV5&data=04%7C0 > 1%7 > > > CAbdulLateef.Attar%40amd.com%7Cdbcced5d461947c4c52908d9f50d60e9%7C > 3dd8 > > > 961fe4884e608e11a82d994e183d%7C0%7C0%7C637810260090713957%7CUnk > nown%7C > > > TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX > VC > > > I6Mn0%3D%7C3000&sdata=lqrY9GyWZTJl%2BsRa%2F223ft8ei5rKBbm36av > 4SQh4 > > l9g%3D&reserved=0 > > > > > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: Zhichao Gao <zhichao.gao@intel.com> > > Cc: Sami Mujawar <sami.mujawar@arm.com> > > > > Abdul Lateef Attar (2): > > ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser > > ShellPkg/AcpiView: PrintFormatter for FADT Flags field > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 48 > > +++++ > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 188 > > ++++++++++++++++++++ > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > > | 167 +++++++++++------ > > 3 files changed, 348 insertions(+), 55 deletions(-) > > > > -- > > 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87725): https://edk2.groups.io/g/devel/message/87725 Mute This Topic: https://groups.io/mt/89182985/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.