1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check

wenyi,xie via groups.io posted 1 patch 2 years, 3 months ago
Failed in applying to current master (apply log)
RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +++++++++-----------
1 file changed, 17 insertions(+), 21 deletions(-)
[edk2-devel] [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
Posted by wenyi,xie via groups.io 2 years, 3 months ago 
Main Changes :
1.Remove redundant if statement.

Wenyi Xie (1):
  RedfishPkg/RedfishRestExDxe:Simplify status check

 RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +++++++++-----------
 1 file changed, 17 insertions(+), 21 deletions(-)

-- 
2.20.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85803): https://edk2.groups.io/g/devel/message/85803
Mute This Topic: https://groups.io/mt/88529321/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
Posted by Abner Chang 2 years, 3 months ago 
Hi Wenyi,
May I know what is the problem you encountered and what environment causes the issue? Is that under edk2 emulation or the real Redfish service?

Thanks
Abner
________________________________
From: Wenyi Xie <xiewenyi2@huawei.com>
Sent: Wednesday, January 19, 2022 2:12 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Wang, Nickle (Server BIOS) <nickle.wang@hpe.com>
Cc: songdongkuang@huawei.com <songdongkuang@huawei.com>; xiewenyi2@huawei.com <xiewenyi2@huawei.com>
Subject: [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check

Main Changes :
1.Remove redundant if statement.

Wenyi Xie (1):
  RedfishPkg/RedfishRestExDxe:Simplify status check

 RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +++++++++-----------
 1 file changed, 17 insertions(+), 21 deletions(-)

--
2.20.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85806): https://edk2.groups.io/g/devel/message/85806
Mute This Topic: https://groups.io/mt/88529321/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
Posted by wenyi,xie via groups.io 2 years, 3 months ago 

On 2022/1/19 15:29, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hi Wenyi,
> May I know what is the problem you encountered and what environment causes the issue? Is that under edk2 emulation or the real Redfish service?
> 
Hi Abner,
I didn't encounter any issue and there's no functional change in this patch, just try to simplify the code. Please review whether it's OK or not.

Thanks
Wenyi
> Thanks
> Abner
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Wenyi Xie <xiewenyi2@huawei.com>
> *Sent:* Wednesday, January 19, 2022 2:12 PM
> *To:* devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Wang, Nickle (Server BIOS) <nickle.wang@hpe.com>
> *Cc:* songdongkuang@huawei.com <songdongkuang@huawei.com>; xiewenyi2@huawei.com <xiewenyi2@huawei.com>
> *Subject:* [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
>  
> Main Changes :
> 1.Remove redundant if statement.
> 
> Wenyi Xie (1):
>   RedfishPkg/RedfishRestExDxe:Simplify status check
> 
>  RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +++++++++-----------
>  1 file changed, 17 insertions(+), 21 deletions(-)
> 
> -- 
> 2.20.1.windows.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85807): https://edk2.groups.io/g/devel/message/85807
Mute This Topic: https://groups.io/mt/88529321/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
Posted by Abner Chang 2 years, 3 months ago 
Hi Wenyi,
Could you please create PR for this change? So we can have core CI on this patch and I can also merge this patch later when the core CI is finished successfully.
Just send me the link to PR once you create it.

Thanks
Abner
________________________________
From: xiewenyi (A) <xiewenyi2@huawei.com>
Sent: Wednesday, January 19, 2022 3:39 PM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Wang, Nickle (Server BIOS) <nickle.wang@hpe.com>
Cc: songdongkuang@huawei.com <songdongkuang@huawei.com>
Subject: Re: [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check



On 2022/1/19 15:29, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hi Wenyi,
> May I know what is the problem you encountered and what environment causes the issue? Is that under edk2 emulation or the real Redfish service?
>
Hi Abner,
I didn't encounter any issue and there's no functional change in this patch, just try to simplify the code. Please review whether it's OK or not.

Thanks
Wenyi
> Thanks
> Abner
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Wenyi Xie <xiewenyi2@huawei.com>
> *Sent:* Wednesday, January 19, 2022 2:12 PM
> *To:* devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Wang, Nickle (Server BIOS) <nickle.wang@hpe.com>
> *Cc:* songdongkuang@huawei.com <songdongkuang@huawei.com>; xiewenyi2@huawei.com <xiewenyi2@huawei.com>
> *Subject:* [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
>
> Main Changes :
> 1.Remove redundant if statement.
>
> Wenyi Xie (1):
>   RedfishPkg/RedfishRestExDxe:Simplify status check
>
>  RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +++++++++-----------
>  1 file changed, 17 insertions(+), 21 deletions(-)
>
> --
> 2.20.1.windows.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85859): https://edk2.groups.io/g/devel/message/85859
Mute This Topic: https://groups.io/mt/88529321/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
Posted by wenyi,xie via groups.io 2 years, 3 months ago 

On 2022/1/20 10:30, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hi Wenyi,
> Could you please create PR for this change? So we can have core CI on this patch and I can also merge this patch later when the core CI is finished successfully.
> Just send me the link to PR once you create it.
> 

Sure, here's the link.
https://github.com/tianocore/edk2/pull/2429

Thanks
Wenyi

> Thanks
> Abner
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* xiewenyi (A) <xiewenyi2@huawei.com>
> *Sent:* Wednesday, January 19, 2022 3:39 PM
> *To:* Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Wang, Nickle (Server BIOS) <nickle.wang@hpe.com>
> *Cc:* songdongkuang@huawei.com <songdongkuang@huawei.com>
> *Subject:* Re: [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
>  
> 
> 
> On 2022/1/19 15:29, Chang, Abner (HPS SW/FW Technologist) wrote:
>> Hi Wenyi,
>> May I know what is the problem you encountered and what environment causes the issue? Is that under edk2 emulation or the real Redfish service?
>> 
> Hi Abner,
> I didn't encounter any issue and there's no functional change in this patch, just try to simplify the code. Please review whether it's OK or not.
> 
> Thanks
> Wenyi
>> Thanks
>> Abner
>> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>> *From:* Wenyi Xie <xiewenyi2@huawei.com>
>> *Sent:* Wednesday, January 19, 2022 2:12 PM
>> *To:* devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Wang, Nickle (Server BIOS) <nickle.wang@hpe.com>
>> *Cc:* songdongkuang@huawei.com <songdongkuang@huawei.com>; xiewenyi2@huawei.com <xiewenyi2@huawei.com>
>> *Subject:* [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
>>  
>> Main Changes :
>> 1.Remove redundant if statement.
>> 
>> Wenyi Xie (1):
>>   RedfishPkg/RedfishRestExDxe:Simplify status check
>> 
>>  RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +++++++++-----------
>>  1 file changed, 17 insertions(+), 21 deletions(-)
>> 
>> -- 
>> 2.20.1.windows.1
>> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85864): https://edk2.groups.io/g/devel/message/85864
Mute This Topic: https://groups.io/mt/88529321/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
Posted by Abner Chang 2 years, 3 months ago 
Merged.
Thanks to helping on this.
Abner


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85866): https://edk2.groups.io/g/devel/message/85866
Mute This Topic: https://groups.io/mt/88529321/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.