[v2] MM communicate functionality in variable policy

[edk2-devel] [PATCH v2 0/6] MM communicate functionality in variable policy

Posted by Kun Qin 2 years, 4 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751

This patch series is a follow up of previous submission:
https://edk2.groups.io/g/devel/message/84140

v2 patches mainly focus on feedback for commits submitted in v1 patches:
a. Splitted the original ArmPkg patch into 4 separate patches;
b. Updated patches according to Uncrustify scanning results;

Patch v2 branch: https://github.com/kuqin12/edk2/tree/mm_communicate_check_v2

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>

Kun Qin (6):
  MdeModulePkg: VariableSmmRuntimeDxe: Fix Variable Policy Message
    Length
  MdePkg: MmCommunication2: Update MM communicate2 function description
  ArmPkg: MmCommunicationDxe: MM communicate function argument
    attributes
  ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**`
    checks
  ArmPkg: MmCommunicationDxe: Update MM communicate `CommSize` check
  ArmPkg: MmCommunicationDxe: Update MM communicate `MessageLength`
    check

 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c               | 46 ++++++++++++--------
 MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c | 10 ++---
 MdePkg/Include/Protocol/MmCommunication2.h                        | 13 +++---
 3 files changed, 41 insertions(+), 28 deletions(-)

-- 
2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85116): https://edk2.groups.io/g/devel/message/85116
Mute This Topic: https://groups.io/mt/87869771/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/6] MM communicate functionality in variable policy

Posted by Sami Mujawar 2 years, 3 months ago

Hi Kun,

Thank you for this patch series.

These changes look good to me. For this series

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 21/12/2021 01:33 AM, Kun Qin via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751
>
> This patch series is a follow up of previous submission:
> https://edk2.groups.io/g/devel/message/84140
>
> v2 patches mainly focus on feedback for commits submitted in v1 patches:
> a. Splitted the original ArmPkg patch into 4 separate patches;
> b. Updated patches according to Uncrustify scanning results;
>
> Patch v2 branch: https://github.com/kuqin12/edk2/tree/mm_communicate_check_v2
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Kun Qin (6):
>    MdeModulePkg: VariableSmmRuntimeDxe: Fix Variable Policy Message
>      Length
>    MdePkg: MmCommunication2: Update MM communicate2 function description
>    ArmPkg: MmCommunicationDxe: MM communicate function argument
>      attributes
>    ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**`
>      checks
>    ArmPkg: MmCommunicationDxe: Update MM communicate `CommSize` check
>    ArmPkg: MmCommunicationDxe: Update MM communicate `MessageLength`
>      check
>
>   ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c               | 46 ++++++++++++--------
>   MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c | 10 ++---
>   MdePkg/Include/Protocol/MmCommunication2.h                        | 13 +++---
>   3 files changed, 41 insertions(+), 28 deletions(-)
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85810): https://edk2.groups.io/g/devel/message/85810
Mute This Topic: https://groups.io/mt/87869771/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/6] MM communicate functionality in variable policy

Posted by Kun Qin 2 years, 3 months ago

Hi ArmPkg maintainers,

It has been almost a month since this v2 patch series has been sent out for review. Could you please take a look and provide feedback? Thanks in advance.

Regards,
Kun


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85784): https://edk2.groups.io/g/devel/message/85784
Mute This Topic: https://groups.io/mt/87869771/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/6] MM communicate functionality in variable policy

Posted by Rebecca Cran 2 years, 3 months ago

[+Leif, Ard]


Kun,


There's often so much mailing list traffic that you need to CC the 
maintainers for them to see your emails.


-- 

Rebecca Cran


On 1/18/22 11:40, Kun Qin wrote:
> Hi ArmPkg maintainers,
>
> It has been almost a month since this v2 patch series has been sent 
> out for review. Could you please take a look and provide feedback? 
> Thanks in advance.
>
> Regards,
> Kun
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85786): https://edk2.groups.io/g/devel/message/85786
Mute This Topic: https://groups.io/mt/87869771/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/6] MM communicate functionality in variable policy

Posted by Kun Qin 2 years, 3 months ago

I thought the reply on website will retain the original CC list. But I 
was wrong about that.

Thanks for the reminder, Rebecca.

Regards,
Kun

On 01/18/2022 14:04, Rebecca Cran wrote:
> [+Leif, Ard]
> 
> 
> Kun,
> 
> 
> There's often so much mailing list traffic that you need to CC the 
> maintainers for them to see your emails.
> 
> 
> -- 
> 
> Rebecca Cran
> 
> 
> On 1/18/22 11:40, Kun Qin wrote:
>> Hi ArmPkg maintainers,
>>
>> It has been almost a month since this v2 patch series has been sent 
>> out for review. Could you please take a look and provide feedback? 
>> Thanks in advance.
>>
>> Regards,
>> Kun
>> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85787): https://edk2.groups.io/g/devel/message/85787
Mute This Topic: https://groups.io/mt/87869771/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/6] MM communicate functionality in variable policy

Posted by Sami Mujawar 2 years, 3 months ago

Hi Kun,

I will review this patch series shortly.

Regards,

Sami Mujawar

On 18/01/2022, 22:07, "devel@edk2.groups.io on behalf of Kun Qin via groups.io" <devel@edk2.groups.io on behalf of kuqin12=gmail.com@groups.io> wrote:

    I thought the reply on website will retain the original CC list. But I 
    was wrong about that.

    Thanks for the reminder, Rebecca.

    Regards,
    Kun

    On 01/18/2022 14:04, Rebecca Cran wrote:
    > [+Leif, Ard]
    > 
    > 
    > Kun,
    > 
    > 
    > There's often so much mailing list traffic that you need to CC the 
    > maintainers for them to see your emails.
    > 
    > 
    > -- 
    > 
    > Rebecca Cran
    > 
    > 
    > On 1/18/22 11:40, Kun Qin wrote:
    >> Hi ArmPkg maintainers,
    >>
    >> It has been almost a month since this v2 patch series has been sent 
    >> out for review. Could you please take a look and provide feedback? 
    >> Thanks in advance.
    >>
    >> Regards,
    >> Kun
    >> 


    





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85808): https://edk2.groups.io/g/devel/message/85808
Mute This Topic: https://groups.io/mt/87869771/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-