Platform/ARM/JunoPkg/ArmJuno.dsc | 1 + Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 12 ++--- Platform/ARM/Morello/MorelloPlatform.dsc.inc | 1 + Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 1 + Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 1 + Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c | 16 +++---- Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c | 16 +++---- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c | 8 ++-- Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | 8 ++-- Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | 48 ++++++++++---------- 15 files changed, 63 insertions(+), 54 deletions(-)
This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL support
for AARCH64" series which is in the process of being reviewed (I'm
sending a v2 soon).
With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consumers
of ArmPkg/Drivers/CpuDxe now need an instance of MpInitLib. This series
adds ArmPkg/Library/MpInitLib/DxeMpInitLib.inf.
Also, the ARM_CORE_INFO struct has changed so there's now an MPIDR field
where there were previously separate cluster and core fields. This
series updates the initializers for the various instances.
Rebecca Cran (8):
Platform/ARM: Add MpInitLib instance
Platform/Socionext: Add instance of MpInitLib
Silicon/Marvell: Add instance of MpInitLib
Platform/Qemu: Add instance of MpInitLib
Platform/ARM: Update ARM_CORE_INFO initializer for MPIDR field change
Silicon/Marvell: Update ARM_CORE_INFO initializer for MPIDR field
change
Silicon/Socionext: Update ARM_CORE_INFO initializer for MPIDR field
change
Silicon/Qemu: Update ARM_CORE_INFO initializer for MPIDR field change
Platform/ARM/JunoPkg/ArmJuno.dsc | 1 +
Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 12 ++---
Platform/ARM/Morello/MorelloPlatform.dsc.inc | 1 +
Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 1 +
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 1 +
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c | 16 +++----
Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c | 16 +++----
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c | 8 ++--
Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | 8 ++--
Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | 48 ++++++++++----------
15 files changed, 63 insertions(+), 54 deletions(-)
--
2.31.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84836): https://edk2.groups.io/g/devel/message/84836
Mute This Topic: https://groups.io/mt/87734393/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
On Wed, 15 Dec 2021 at 01:03, Rebecca Cran <rebecca@nuviainc.com> wrote: > > This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL support > for AARCH64" series which is in the process of being reviewed (I'm > sending a v2 soon). > > With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consumers > of ArmPkg/Drivers/CpuDxe now need an instance of MpInitLib. This series > adds ArmPkg/Library/MpInitLib/DxeMpInitLib.inf. > > Also, the ARM_CORE_INFO struct has changed so there's now an MPIDR field > where there were previously separate cluster and core fields. This > series updates the initializers for the various instances. > > > Rebecca Cran (8): > Platform/ARM: Add MpInitLib instance > Platform/Socionext: Add instance of MpInitLib > Silicon/Marvell: Add instance of MpInitLib > Platform/Qemu: Add instance of MpInitLib > Platform/ARM: Update ARM_CORE_INFO initializer for MPIDR field change > Silicon/Marvell: Update ARM_CORE_INFO initializer for MPIDR field > change > Silicon/Socionext: Update ARM_CORE_INFO initializer for MPIDR field > change > Silicon/Qemu: Update ARM_CORE_INFO initializer for MPIDR field change > Acked-by: Ard Biesheuvel <ardb@kernel.org> > Platform/ARM/JunoPkg/ArmJuno.dsc | 1 + > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 12 ++--- > Platform/ARM/Morello/MorelloPlatform.dsc.inc | 1 + > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 1 + > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 1 + > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c | 16 +++---- > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c | 16 +++---- > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c | 8 ++-- > Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | 8 ++-- > Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | 48 ++++++++++---------- > 15 files changed, 63 insertions(+), 54 deletions(-) > > -- > 2.31.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84870): https://edk2.groups.io/g/devel/message/84870 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Wed, 15 Dec 2021 at 01:03, Rebecca Cran <rebecca@nuviainc.com> wrote: > > This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL support > for AARCH64" series which is in the process of being reviewed (I'm > sending a v2 soon). > > With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consumers > of ArmPkg/Drivers/CpuDxe now need an instance of MpInitLib. This series > adds ArmPkg/Library/MpInitLib/DxeMpInitLib.inf. > > Also, the ARM_CORE_INFO struct has changed so there's now an MPIDR field > where there were previously separate cluster and core fields. This > series updates the initializers for the various instances. > > > Rebecca Cran (8): > Platform/ARM: Add MpInitLib instance > Platform/Socionext: Add instance of MpInitLib > Silicon/Marvell: Add instance of MpInitLib > Platform/Qemu: Add instance of MpInitLib > Platform/ARM: Update ARM_CORE_INFO initializer for MPIDR field change > Silicon/Marvell: Update ARM_CORE_INFO initializer for MPIDR field > change > Silicon/Socionext: Update ARM_CORE_INFO initializer for MPIDR field > change > Silicon/Qemu: Update ARM_CORE_INFO initializer for MPIDR field change > You appear to have missed a few instances: Platform/AMD/OverdriveBoard/OverdriveBoard.dsc Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc Platform/Hisilicon/D03/D03.dsc Platform/Hisilicon/D05/D05.dsc Platform/Hisilicon/D06/D06.dsc Platform/Hisilicon/HiKey/HiKey.dsc Platform/Hisilicon/HiKey960/HiKey960.dsc Platform/LeMaker/CelloBoard/CelloBoard.dsc Platform/Phytium/DurianPkg/DurianPkg.dsc Platform/RaspberryPi/RPi3/RPi3.dsc Platform/RaspberryPi/RPi4/RPi4.dsc Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc I know this is tedious busywork, but you can't break existing platforms like that, so please provide a solution for these as well. > Platform/ARM/JunoPkg/ArmJuno.dsc | 1 + > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 12 ++--- > Platform/ARM/Morello/MorelloPlatform.dsc.inc | 1 + > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 1 + > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 1 + > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c | 16 +++---- > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c | 16 +++---- > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c | 8 ++-- > Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | 8 ++-- > Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | 48 ++++++++++---------- > 15 files changed, 63 insertions(+), 54 deletions(-) > > -- > 2.31.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84975): https://edk2.groups.io/g/devel/message/84975 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 12/16/21 2:32 AM, Ard Biesheuvel wrote: > You appear to have missed a few instances: > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > Platform/Hisilicon/D03/D03.dsc > Platform/Hisilicon/D05/D05.dsc > Platform/Hisilicon/D06/D06.dsc > Platform/Hisilicon/HiKey/HiKey.dsc > Platform/Hisilicon/HiKey960/HiKey960.dsc > Platform/LeMaker/CelloBoard/CelloBoard.dsc > Platform/Phytium/DurianPkg/DurianPkg.dsc > Platform/RaspberryPi/RPi3/RPi3.dsc > Platform/RaspberryPi/RPi4/RPi4.dsc > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > I know this is tedious busywork, but you can't break existing > platforms like that, so please provide a solution for these as well. Thanks, I'm not sure how I managed to miss those. I'll send out a v2 patch with them included. I agree, I can't break platforms like this. I'm also keeping track of platforms that are currently broken in other ways, such as Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc which needs updated for the VariablePolicyHelperLib, and Platform/Comcast/RDKQemu/RDKQemu.dsc which has an ACPI build problem. Several other platforms claim to support ARM but don't currently build. For example, Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc fails with: : error F000: No files to be built in module [RELEASE, GCC5, ARM] [/home/bcran/src/upstream/uefi/edk2/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf] -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84990): https://edk2.groups.io/g/devel/message/84990 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Thu, 16 Dec 2021 at 14:13, Rebecca Cran <rebecca@nuviainc.com> wrote: > > On 12/16/21 2:32 AM, Ard Biesheuvel wrote: > > > You appear to have missed a few instances: > > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > Platform/Hisilicon/D03/D03.dsc > > Platform/Hisilicon/D05/D05.dsc > > Platform/Hisilicon/D06/D06.dsc > > Platform/Hisilicon/HiKey/HiKey.dsc > > Platform/Hisilicon/HiKey960/HiKey960.dsc > > Platform/LeMaker/CelloBoard/CelloBoard.dsc > > Platform/Phytium/DurianPkg/DurianPkg.dsc > > Platform/RaspberryPi/RPi3/RPi3.dsc > > Platform/RaspberryPi/RPi4/RPi4.dsc > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > > > I know this is tedious busywork, but you can't break existing > > platforms like that, so please provide a solution for these as well. > > Thanks, I'm not sure how I managed to miss those. I'll send out a v2 > patch with them included. > > I agree, I can't break platforms like this. > > > I'm also keeping track of platforms that are currently broken in other > ways, such as > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc which needs > updated for the VariablePolicyHelperLib, and > Platform/Comcast/RDKQemu/RDKQemu.dsc which has an ACPI build problem. > Several other platforms claim to support ARM but don't currently build. > For example, Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc fails with: > > > : error F000: No files to be built in module [RELEASE, GCC5, ARM] > [/home/bcran/src/upstream/uefi/edk2/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf] > There were some changes a while ago to support standalone MM in 32-bit mode, but I don't think any of the Platform/ARM platforms implement that. So the best fix here is to simply stop lying about ARM support. As for RdkQemu - I think it is time we just remove that. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84991): https://edk2.groups.io/g/devel/message/84991 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
W dniu 16.12.2021 o 14:16, Ard Biesheuvel pisze: >>> Platform/LeMaker/CelloBoard/CelloBoard.dsc > As for RdkQemu - I think it is time we just remove that. I would vote for removal of CelloBoard as well. It never went into any serious mass production and nowadays you probably count working ones using fingers. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84993): https://edk2.groups.io/g/devel/message/84993 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Thu, 16 Dec 2021 at 14:38, Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> wrote: > > W dniu 16.12.2021 o 14:16, Ard Biesheuvel pisze: > > >>> Platform/LeMaker/CelloBoard/CelloBoard.dsc > > > As for RdkQemu - I think it is time we just remove that. > > I would vote for removal of CelloBoard as well. It never went into any > serious mass production and nowadays you probably count working ones > using fingers. I would not object to that. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85003): https://edk2.groups.io/g/devel/message/85003 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Ard,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/12/2021, 15:07, "Ard Biesheuvel via groups.io" <ardb=kernel.org@groups.io> wrote:
On Thu, 16 Dec 2021 at 14:38, Marcin Juszkiewicz
<marcin.juszkiewicz@linaro.org> wrote:
>
> W dniu 16.12.2021 o 14:16, Ard Biesheuvel pisze:
>
> >>> Platform/LeMaker/CelloBoard/CelloBoard.dsc
>
> > As for RdkQemu - I think it is time we just remove that.
>
> I would vote for removal of CelloBoard as well. It never went into any
> serious mass production and nowadays you probably count working ones
> using fingers.
I would not object to that.
[SAMI] I am about to submit some patches for fixing the build break in SynQuacerEvalBoard and LeMaker/CelloBoard.
Based on the conversation above, I assume I could skip the fix for LeMaker/CelloBoard. Please let me know if that is ok.
[/SAMI]
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85008): https://edk2.groups.io/g/devel/message/85008
Mute This Topic: https://groups.io/mt/87734393/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
On Thu, 16 Dec 2021 at 19:55, Sami Mujawar <Sami.Mujawar@arm.com> wrote: > > Hi Ard, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > On 16/12/2021, 15:07, "Ard Biesheuvel via groups.io" <ardb=kernel.org@groups.io> wrote: > > On Thu, 16 Dec 2021 at 14:38, Marcin Juszkiewicz > <marcin.juszkiewicz@linaro.org> wrote: > > > > W dniu 16.12.2021 o 14:16, Ard Biesheuvel pisze: > > > > >>> Platform/LeMaker/CelloBoard/CelloBoard.dsc > > > > > As for RdkQemu - I think it is time we just remove that. > > > > I would vote for removal of CelloBoard as well. It never went into any > > serious mass production and nowadays you probably count working ones > > using fingers. > > I would not object to that. > [SAMI] I am about to submit some patches for fixing the build break in SynQuacerEvalBoard and LeMaker/CelloBoard. > Based on the conversation above, I assume I could skip the fix for LeMaker/CelloBoard. Please let me know if that is ok. Yes that is fine. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85009): https://edk2.groups.io/g/devel/message/85009 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 12/16/21 6:16 AM, Ard Biesheuvel wrote:
> There were some changes a while ago to support standalone MM in 32-bit
> mode, but I don't think any of the Platform/ARM platforms implement
> that. So the best fix here is to simply stop lying about ARM support.
>
> As for RdkQemu - I think it is time we just remove that.
During the work I found that the following list of platforms didn't build:
o Drivers/OptionRomPkg/OptionRomPkg.dsc for AARCH64 and ARM: due to OptionRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf.
o Features/Ext4Pkg/Ext4Pkg.dsc for ARM: edk2-platforms/Features/Ext4Pkg/Ext4Dxe/Inode.c:341: undefined reference to `__aeabi_uidivmod')
o Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc for ARM
o Platform/Hisilicon/{D03,D05,D06} for AARCH64: Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c:50:18: error: ‘EmHilink0Hccs1X8Width16’ undeclared here (not in a function))
o Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc for AARCH64 and ARM: error C0DE: Unknown fatal error when processing [Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc]
o Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc for ARM.
o Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc for ARM.
o Platform/ARM/SgiPkg/RdN2/RdN2.dsc for ARM.
o Platform/ARM/SgiPkg/RdV1/RdV1.dsc for ARM.
o Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc for ARM.
o Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc for ARM.
o Platform/Comcast/RDKQemu/RDKQemu.dsc for AARCH64 and ARM due to ACPI
issue.
o Platform/Marvell/Cn913xDb/Cn913xDbA.dsc for AARCH64 and ARM: tries to
use literal $(PLATFORM_NAME).
o Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc for AARCH64
and ARM: VariablePolicyHelperLib issue.
o Platform/SolidRun/Cn913xCEx7Eval/Cn913xCEx7Eval.dsc for AARCH64 and ARM:
T91 not found.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85030): https://edk2.groups.io/g/devel/message/85030
Mute This Topic: https://groups.io/mt/87734393/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Hi,
czw., 16 gru 2021 o 23:09 Rebecca Cran <rebecca@nuviainc.com> napisał(a):
>
> On 12/16/21 6:16 AM, Ard Biesheuvel wrote:
> > There were some changes a while ago to support standalone MM in 32-bit
> > mode, but I don't think any of the Platform/ARM platforms implement
> > that. So the best fix here is to simply stop lying about ARM support.
> >
> > As for RdkQemu - I think it is time we just remove that.
>
> During the work I found that the following list of platforms didn't build:
>
>
> o Drivers/OptionRomPkg/OptionRomPkg.dsc for AARCH64 and ARM: due to OptionRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf.
>
> o Features/Ext4Pkg/Ext4Pkg.dsc for ARM: edk2-platforms/Features/Ext4Pkg/Ext4Dxe/Inode.c:341: undefined reference to `__aeabi_uidivmod')
>
> o Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc for ARM
>
> o Platform/Hisilicon/{D03,D05,D06} for AARCH64: Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c:50:18: error: ‘EmHilink0Hccs1X8Width16’ undeclared here (not in a function))
>
> o Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc for AARCH64 and ARM: error C0DE: Unknown fatal error when processing [Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc]
>
It is expected behavior. In order to succeed, proper -D FIRMWARE_IMAGE
and -D PLATFORM_NAME must be passed.
> o Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc for ARM.
>
> o Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc for ARM.
>
> o Platform/ARM/SgiPkg/RdN2/RdN2.dsc for ARM.
>
> o Platform/ARM/SgiPkg/RdV1/RdV1.dsc for ARM.
>
> o Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc for ARM.
>
> o Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc for ARM.
>
> o Platform/Comcast/RDKQemu/RDKQemu.dsc for AARCH64 and ARM due to ACPI
> issue.
>
> o Platform/Marvell/Cn913xDb/Cn913xDbA.dsc for AARCH64 and ARM: tries to
> use literal $(PLATFORM_NAME).
>
The build is expected to fail - the user must explicitly pick the SoC
variant with -D flag, see the .dsc excerpt:
[Defines]
!if $(CN9130)
PLATFORM_NAME = Cn9130DbA
!elseif $(CN9131)
PLATFORM_NAME = Cn9131DbA
!elseif $(CN9132)
PLATFORM_NAME = Cn9132DbA
!endif
Thanks,
Marcin
> o Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc for AARCH64
> and ARM: VariablePolicyHelperLib issue.
>
> o Platform/SolidRun/Cn913xCEx7Eval/Cn913xCEx7Eval.dsc for AARCH64 and ARM:
> T91 not found.
>
> --
> Rebecca Cran
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85096): https://edk2.groups.io/g/devel/message/85096
Mute This Topic: https://groups.io/mt/87734393/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Thanks! It looks like the existing changes covered
Platform/Marvell/Cn913xDb/Cn913xDbA.dsc and Armada7k8kCapsule isn't
something that would be broken by my changes.
--
Rebecca Cran
On 12/19/21 03:32, Marcin Wojtas wrote:
> Hi,
>
> czw., 16 gru 2021 o 23:09 Rebecca Cran<rebecca@nuviainc.com> napisał(a):
>> On 12/16/21 6:16 AM, Ard Biesheuvel wrote:
>>> There were some changes a while ago to support standalone MM in 32-bit
>>> mode, but I don't think any of the Platform/ARM platforms implement
>>> that. So the best fix here is to simply stop lying about ARM support.
>>>
>>> As for RdkQemu - I think it is time we just remove that.
>> During the work I found that the following list of platforms didn't build:
>>
>>
>> o Drivers/OptionRomPkg/OptionRomPkg.dsc for AARCH64 and ARM: due to OptionRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf.
>>
>> o Features/Ext4Pkg/Ext4Pkg.dsc for ARM: edk2-platforms/Features/Ext4Pkg/Ext4Dxe/Inode.c:341: undefined reference to `__aeabi_uidivmod')
>>
>> o Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc for ARM
>>
>> o Platform/Hisilicon/{D03,D05,D06} for AARCH64: Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c:50:18: error: ‘EmHilink0Hccs1X8Width16’ undeclared here (not in a function))
>>
>> o Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc for AARCH64 and ARM: error C0DE: Unknown fatal error when processing [Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dsc]
>>
> It is expected behavior. In order to succeed, proper -D FIRMWARE_IMAGE
> and -D PLATFORM_NAME must be passed.
>
>> o Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc for ARM.
>>
>> o Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc for ARM.
>>
>> o Platform/ARM/SgiPkg/RdN2/RdN2.dsc for ARM.
>>
>> o Platform/ARM/SgiPkg/RdV1/RdV1.dsc for ARM.
>>
>> o Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc for ARM.
>>
>> o Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc for ARM.
>>
>> o Platform/Comcast/RDKQemu/RDKQemu.dsc for AARCH64 and ARM due to ACPI
>> issue.
>>
>> o Platform/Marvell/Cn913xDb/Cn913xDbA.dsc for AARCH64 and ARM: tries to
>> use literal $(PLATFORM_NAME).
>>
> The build is expected to fail - the user must explicitly pick the SoC
> variant with -D flag, see the .dsc excerpt:
> [Defines]
> !if $(CN9130)
> PLATFORM_NAME = Cn9130DbA
> !elseif $(CN9131)
> PLATFORM_NAME = Cn9131DbA
> !elseif $(CN9132)
> PLATFORM_NAME = Cn9132DbA
> !endif
>
> Thanks,
> Marcin
>
>> o Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc for AARCH64
>> and ARM: VariablePolicyHelperLib issue.
>>
>> o Platform/SolidRun/Cn913xCEx7Eval/Cn913xCEx7Eval.dsc for AARCH64 and ARM:
>> T91 not found.
>>
>> --
>> Rebecca Cran
>>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85496): https://edk2.groups.io/g/devel/message/85496
Mute This Topic: https://groups.io/mt/87734393/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Hi Rebecca,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 16/12/2021, 13:14, "Rebecca Cran" <rebecca@nuviainc.com> wrote:
On 12/16/21 2:32 AM, Ard Biesheuvel wrote:
> You appear to have missed a few instances:
>
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> Platform/Hisilicon/D03/D03.dsc
> Platform/Hisilicon/D05/D05.dsc
> Platform/Hisilicon/D06/D06.dsc
> Platform/Hisilicon/HiKey/HiKey.dsc
> Platform/Hisilicon/HiKey960/HiKey960.dsc
> Platform/LeMaker/CelloBoard/CelloBoard.dsc
> Platform/Phytium/DurianPkg/DurianPkg.dsc
> Platform/RaspberryPi/RPi3/RPi3.dsc
> Platform/RaspberryPi/RPi4/RPi4.dsc
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
>
> I know this is tedious busywork, but you can't break existing
> platforms like that, so please provide a solution for these as well.
Thanks, I'm not sure how I managed to miss those. I'll send out a v2
patch with them included.
I agree, I can't break platforms like this.
I'm also keeping track of platforms that are currently broken in other
ways, such as
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc which needs
updated for the VariablePolicyHelperLib, and
Platform/Comcast/RDKQemu/RDKQemu.dsc which has an ACPI build problem.
Several other platforms claim to support ARM but don't currently build.
For example, Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc fails with:
: error F000: No files to be built in module [RELEASE, GCC5, ARM]
[/home/bcran/src/upstream/uefi/edk2/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf]
[SAMI] I posted the following patches to fix some of the issues you mention above:
Platform/Socionext: Fix build break for SynQuacerEvalBoard (https://edk2.groups.io/g/devel/message/83553)
Platform/LeMaker: Fix build break for CelloBoard (https://edk2.groups.io/g/devel/message/83556)
Platform/Socionext/SynQuacerEvalBoard: Add missing ArmSoftFloatLib (https://edk2.groups.io/g/devel/message/83554)
Platform/Socionext/SynQuacerEvalBoard: Disable EbcDxe for AArch32 Builds (https://edk2.groups.io/g/devel/message/83557)
If it helps, I can carve out these patches in a separate series and post them to the list.
I feel we need a CI for edk2-platforms. Without this it is going to be hard to keep track of such build breaks.
[/SAMI]
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84992): https://edk2.groups.io/g/devel/message/84992
Mute This Topic: https://groups.io/mt/87734393/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
On 12/16/21 6:26 AM, Sami Mujawar wrote: > [SAMI] I posted the following patches to fix some of the issues you mention above: > Platform/Socionext: Fix build break for SynQuacerEvalBoard (https://edk2.groups.io/g/devel/message/83553) > Platform/LeMaker: Fix build break for CelloBoard (https://edk2.groups.io/g/devel/message/83556) > Platform/Socionext/SynQuacerEvalBoard: Add missing ArmSoftFloatLib (https://edk2.groups.io/g/devel/message/83554) > Platform/Socionext/SynQuacerEvalBoard: Disable EbcDxe for AArch32 Builds (https://edk2.groups.io/g/devel/message/83557) > > If it helps, I can carve out these patches in a separate series and post them to the list. > > I feel we need a CI for edk2-platforms. Without this it is going to be hard to keep track of such build breaks. > [/SAMI] Thanks, I'll take a look at those and post any comments. I agree, CI for edk2-platforms would be good. I'm hoping to find some time next week to work on it. A useful step, even if it's just the first of many, would be to simply run lots of 'build' commands for each platform. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85002): https://edk2.groups.io/g/devel/message/85002 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Rebecca, On 12/16/21 3:59 PM, Rebecca Cran wrote: > On 12/16/21 6:26 AM, Sami Mujawar wrote: > >> [SAMI] I posted the following patches to fix some of the issues you mention above: >> Platform/Socionext: Fix build break for SynQuacerEvalBoard (https://edk2.groups.io/g/devel/message/83553) >> Platform/LeMaker: Fix build break for CelloBoard (https://edk2.groups.io/g/devel/message/83556) >> Platform/Socionext/SynQuacerEvalBoard: Add missing ArmSoftFloatLib (https://edk2.groups.io/g/devel/message/83554) >> Platform/Socionext/SynQuacerEvalBoard: Disable EbcDxe for AArch32 Builds (https://edk2.groups.io/g/devel/message/83557) >> >> If it helps, I can carve out these patches in a separate series and post them to the list. >> >> I feel we need a CI for edk2-platforms. Without this it is going to be hard to keep track of such build breaks. >> [/SAMI] > > > Thanks, I'll take a look at those and post any comments. > > I agree, CI for edk2-platforms would be good. I'm hoping to find some time next week to work on it. A useful step, even if it's just the first of many, would be to simply run lots of 'build' commands for each platform. > > The following patchset should enable a CI in edk2-platforms for the Juno platorm, but it was tested before uncrustify was enabled. The patch-set is also relying on a modification in edk2-pytool-extensions: https://edk2.groups.io/g/devel/message/83803 https://github.com/tianocore/edk2-pytool-extensions/pull/279 There is a bugzilla on this topic at: https://bugzilla.tianocore.org/show_bug.cgi?id=3509 Feel free to use the patches (or not) and to take the bugzilla (or not). It didn't seem the feature was really appealing until now, Regards, Pierre -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85004): https://edk2.groups.io/g/devel/message/85004 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 12/16/21 8:26 AM, Pierre Gondois wrote: > The following patchset should enable a CI in edk2-platforms for the Juno platorm, but it was tested before uncrustify was enabled. The patch-set is also relying on a modification in edk2-pytool-extensions: > https://edk2.groups.io/g/devel/message/83803 > https://github.com/tianocore/edk2-pytool-extensions/pull/279 > > There is a bugzilla on this topic at: > https://bugzilla.tianocore.org/show_bug.cgi?id=3509 > > Feel free to use the patches (or not) and to take the bugzilla (or not). It didn't seem the feature was really appealing until now, Thanks I did see those, but I don't understand the CI framework (yet) and unfortunately it seems there's little or slow movement on enabling it for edk2-platforms. From what I've seen, the CI framework is rather complicated and tied into Azure and/or GitHub. Given I have an instance of Gitlab running, for now I'll plan on doing my own thing with shell scripts etc. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85007): https://edk2.groups.io/g/devel/message/85007 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 12/16/21 6:26 AM, Sami Mujawar wrote: > [SAMI] I posted the following patches to fix some of the issues you mention above: > Platform/Socionext: Fix build break for SynQuacerEvalBoard (https://edk2.groups.io/g/devel/message/83553) > Platform/LeMaker: Fix build break for CelloBoard (https://edk2.groups.io/g/devel/message/83556) > Platform/Socionext/SynQuacerEvalBoard: Add missing ArmSoftFloatLib (https://edk2.groups.io/g/devel/message/83554) > Platform/Socionext/SynQuacerEvalBoard: Disable EbcDxe for AArch32 Builds (https://edk2.groups.io/g/devel/message/83557) > > If it helps, I can carve out these patches in a separate series and post them to the list. Actually could you re-send them please, cc'ing the platform maintainers (Ard, Leif and Masami)? I suspect that's why they were missed. Thanks, Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85005): https://edk2.groups.io/g/devel/message/85005 Mute This Topic: https://groups.io/mt/87734393/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.