[edk2-devel] [PATCH] OvmfPkg/OvmfXen: Fix Xen build

Jason Andryuk posted 1 patch 2 years, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20211210190552.73854-1-jandryuk@gmail.com
OvmfPkg/OvmfXen.dsc | 1 +
1 file changed, 1 insertion(+)
[edk2-devel] [PATCH] OvmfPkg/OvmfXen: Fix Xen build
Posted by Jason Andryuk 2 years, 4 months ago
commit 202fb22be6e9 "OvmfPkg/SecMain: validate the memory used for
decompressing Fv" broke building OvmfXen with:

edk2/OvmfPkg/OvmfXen.dsc(...): error 1001: Module type [SEC] is not
supported by library instancer
[edk2/OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf]
	consumed by [edk2/OvmfPkg/Sec/SecMain.inf]

The above commit added a reference to MemEncryptSevLib into SecMain.inf,
but OvmfXen.dsc doesn't have a MemEncryptSevLib entry for SEC.  Add one
like OvmfPkgX64.dsc has.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
The error messages was long, so I wrapped it.

 OvmfPkg/OvmfXen.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
index 383cb03d2a..a465c0cc60 100644
--- a/OvmfPkg/OvmfXen.dsc
+++ b/OvmfPkg/OvmfXen.dsc
@@ -247,6 +247,7 @@
 !else
   CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf
 !endif
+  MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLib.inf
 
 [LibraryClasses.common.PEI_CORE]
   HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
-- 
2.33.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84648): https://edk2.groups.io/g/devel/message/84648
Mute This Topic: https://groups.io/mt/87648685/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] OvmfPkg/OvmfXen: Fix Xen build
Posted by Yao, Jiewen 2 years, 4 months ago
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Jason Andryuk <jandryuk@gmail.com>
> Sent: Saturday, December 11, 2021 3:06 AM
> To: devel@edk2.groups.io
> Cc: Jason Andryuk <jandryuk@gmail.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen,
> Jordan L <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Anthony Perard <anthony.perard@citrix.com>; Julien Grall <julien@xen.org>
> Subject: [PATCH] OvmfPkg/OvmfXen: Fix Xen build
> 
> commit 202fb22be6e9 "OvmfPkg/SecMain: validate the memory used for
> decompressing Fv" broke building OvmfXen with:
> 
> edk2/OvmfPkg/OvmfXen.dsc(...): error 1001: Module type [SEC] is not
> supported by library instancer
> [edk2/OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLib.inf]
> 	consumed by [edk2/OvmfPkg/Sec/SecMain.inf]
> 
> The above commit added a reference to MemEncryptSevLib into SecMain.inf,
> but OvmfXen.dsc doesn't have a MemEncryptSevLib entry for SEC.  Add one
> like OvmfPkgX64.dsc has.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> ---
> The error messages was long, so I wrapped it.
> 
>  OvmfPkg/OvmfXen.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> index 383cb03d2a..a465c0cc60 100644
> --- a/OvmfPkg/OvmfXen.dsc
> +++ b/OvmfPkg/OvmfXen.dsc
> @@ -247,6 +247,7 @@
>  !else
> 
> 
> CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCp
> uExceptionHandlerLib.inf
> 
>  !endif
> 
> +
> MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptS
> evLib.inf
> 
> 
> 
>  [LibraryClasses.common.PEI_CORE]
> 
>    HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
> 
> --
> 2.33.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84656): https://edk2.groups.io/g/devel/message/84656
Mute This Topic: https://groups.io/mt/87648685/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-