ArmPkg/Include/Library/OemMiscLib.h | 5 +++++ .../ProcessorSubClassDxe/ProcessorSubClass.c | 14 ++++++++++++-- .../Type01/MiscSystemManufacturerFunction.c | 10 ++++++++++ .../Type02/MiscBaseBoardManufacturerFunction.c | 15 +++++++++++++++ .../Type01/MiscSystemManufacturer.uni | 1 - 5 files changed, 42 insertions(+), 3 deletions(-)
This patchset leverages the OemUpdateSmbiosInfo API functions from
OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4
because they may be updated dynamically during UEFI booting with the
data being passed from the pre-UEFI firmware.
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
Nhi Pham (3):
ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition
ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscLib
ArmPkg/ProcessorSubClassDxe: Get serial and part number from
OemMiscLib
ArmPkg/Include/Library/OemMiscLib.h | 5 +++++
.../ProcessorSubClassDxe/ProcessorSubClass.c | 14 ++++++++++++--
.../Type01/MiscSystemManufacturerFunction.c | 10 ++++++++++
.../Type02/MiscBaseBoardManufacturerFunction.c | 15 +++++++++++++++
.../Type01/MiscSystemManufacturer.uni | 1 -
5 files changed, 42 insertions(+), 3 deletions(-)
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84191): https://edk2.groups.io/g/devel/message/84191
Mute This Topic: https://groups.io/mt/87420725/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
On Wed, 1 Dec 2021 at 05:12, Nhi Pham via groups.io <nhi=os.amperecomputing.com@groups.io> wrote: > > This patchset leverages the OemUpdateSmbiosInfo API functions from > OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4 > because they may be updated dynamically during UEFI booting with the > data being passed from the pre-UEFI firmware. > > Cc: Leif Lindholm <leif@nuviainc.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Rebecca Cran <rebecca@nuviainc.com> > Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com> > Anyone care to review this? > Nhi Pham (3): > ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition > ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscLib > ArmPkg/ProcessorSubClassDxe: Get serial and part number from > OemMiscLib > > ArmPkg/Include/Library/OemMiscLib.h | 5 +++++ > .../ProcessorSubClassDxe/ProcessorSubClass.c | 14 ++++++++++++-- > .../Type01/MiscSystemManufacturerFunction.c | 10 ++++++++++ > .../Type02/MiscBaseBoardManufacturerFunction.c | 15 +++++++++++++++ > .../Type01/MiscSystemManufacturer.uni | 1 - > 5 files changed, 42 insertions(+), 3 deletions(-) > > -- > 2.17.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84875): https://edk2.groups.io/g/devel/message/84875 Mute This Topic: https://groups.io/mt/87420725/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
For the series: Reviewed-by: Rebecca Cran <rebecca@nuviainc.com> -- Rebecca Cran On 11/30/21 9:10 PM, Nhi Pham via groups.io wrote: > This patchset leverages the OemUpdateSmbiosInfo API functions from > OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4 > because they may be updated dynamically during UEFI booting with the > data being passed from the pre-UEFI firmware. > > Cc: Leif Lindholm <leif@nuviainc.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Rebecca Cran <rebecca@nuviainc.com> > Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com> > > Nhi Pham (3): > ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition > ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscLib > ArmPkg/ProcessorSubClassDxe: Get serial and part number from > OemMiscLib > > ArmPkg/Include/Library/OemMiscLib.h | 5 +++++ > .../ProcessorSubClassDxe/ProcessorSubClass.c | 14 ++++++++++++-- > .../Type01/MiscSystemManufacturerFunction.c | 10 ++++++++++ > .../Type02/MiscBaseBoardManufacturerFunction.c | 15 +++++++++++++++ > .../Type01/MiscSystemManufacturer.uni | 1 - > 5 files changed, 42 insertions(+), 3 deletions(-) > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84907): https://edk2.groups.io/g/devel/message/84907 Mute This Topic: https://groups.io/mt/87420725/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Nhi, These patches do not cleanly apply. I guess you would need to run uncrustify for these patches. Can you check, please? Regards, Sami Mujawar On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote: > This patchset leverages the OemUpdateSmbiosInfo API functions from > OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4 > because they may be updated dynamically during UEFI booting with the > data being passed from the pre-UEFI firmware. > > Cc: Leif Lindholm <leif@nuviainc.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Rebecca Cran <rebecca@nuviainc.com> > Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com> > > Nhi Pham (3): > ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition > ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscLib > ArmPkg/ProcessorSubClassDxe: Get serial and part number from > OemMiscLib > > ArmPkg/Include/Library/OemMiscLib.h | 5 +++++ > .../ProcessorSubClassDxe/ProcessorSubClass.c | 14 ++++++++++++-- > .../Type01/MiscSystemManufacturerFunction.c | 10 ++++++++++ > .../Type02/MiscBaseBoardManufacturerFunction.c | 15 +++++++++++++++ > .../Type01/MiscSystemManufacturer.uni | 1 - > 5 files changed, 42 insertions(+), 3 deletions(-) > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84909): https://edk2.groups.io/g/devel/message/84909 Mute This Topic: https://groups.io/mt/87420725/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Sami, On 16/12/2021 00:06, Sami Mujawar wrote: > Hi Nhi, > > These patches do not cleanly apply. I guess you would need to run > uncrustify for these patches. > > Can you check, please? Sure, will fix all coding style issues found by uncrustify and change to use FixedPcdGetPtr() instead of PcdGetPtr() as your suggestion in the PATCH 3/3. Thanks, Nhi > > Regards, > > Sami Mujawar > > > On 01/12/2021 04:10 AM, Nhi Pham via groups.io wrote: >> This patchset leverages the OemUpdateSmbiosInfo API functions from >> OemMiscLib for updating some HII string fields in the SMBIOS Type 1/2/4 >> because they may be updated dynamically during UEFI booting with the >> data being passed from the pre-UEFI firmware. >> >> Cc: Leif Lindholm <leif@nuviainc.com> >> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> >> Cc: Rebecca Cran <rebecca@nuviainc.com> >> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com> >> >> Nhi Pham (3): >> ArmPkg/SmbiosMiscDxe: Remove duplicate HII string definition >> ArmPkg/SmbiosMiscDxe: Get full SMBIOS strings from OemMiscLib >> ArmPkg/ProcessorSubClassDxe: Get serial and part number from >> OemMiscLib >> >> ArmPkg/Include/Library/OemMiscLib.h | 5 +++++ >> .../ProcessorSubClassDxe/ProcessorSubClass.c | 14 ++++++++++++-- >> .../Type01/MiscSystemManufacturerFunction.c | 10 ++++++++++ >> .../Type02/MiscBaseBoardManufacturerFunction.c | 15 +++++++++++++++ >> .../Type01/MiscSystemManufacturer.uni | 1 - >> 5 files changed, 42 insertions(+), 3 deletions(-) >> > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84954): https://edk2.groups.io/g/devel/message/84954 Mute This Topic: https://groups.io/mt/87420725/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.