[edk2-devel] [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC files/errors

Michael D Kinney posted 12 patches 4 years, 2 months ago
[edk2-devel] [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC files/errors
Posted by Michael D Kinney 4 years, 2 months ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749

Update package YAML files to ignore ECC errors that are
already present.  These issues must be fixed in the future,
but should not block source code changes for these known
issues.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 CryptoPkg/CryptoPkg.ci.yaml | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index 1448299073de..eeb388ae71c5 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -19,6 +19,9 @@
         ##     "<ErrorID>", "<KeyWord>"
         ## ]
         "ExceptionList": [
+            "8001", "IsLeap",
+            "8001", "OBJ_get0_data",
+            "8001", "OBJ_length"
         ],
         ## Both file path and directory path are accepted.
         "IgnoreFiles": [
@@ -26,14 +29,15 @@
             # The unit testing folder is not to be checked
             "Test/UnitTest",
             # This has OpenSSL interfaces that aren't UEFI spec compliant
-            "Library/BaseCryptLib/SysCall/UnitTestHostCrtWrapper.c",
+            "Library/BaseCryptLib/SysCall",
             # This has OpenSSL interfaces that aren't UEFI spec compliant
             "Library/OpensslLib/rand_pool.c",
             # This has OpenSSL interfaces that aren't UEFI spec compliant
             "Library/Include/CrtLibSupport.h",
             # These directories contain auto-generated OpenSSL content
-            "Library/OpensslLib/X64",
-            "Library/OpensslLib/X64Gcc"
+            "Library/OpensslLib",
+            "Library/IntrinsicLib",
+            "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"
         ]
     },
     "CompilerPlugin": {
-- 
2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83987): https://edk2.groups.io/g/devel/message/83987
Mute This Topic: https://groups.io/mt/87268738/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC files/errors
Posted by Wang, Jian J 4 years, 2 months ago

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, November 24, 2021 5:21 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>;
> Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Michael Kubacki <michael.kubacki@microsoft.com>
> Subject: [Patch 04/12] CryptoPkg: Update YAML to ignore specific ECC
> files/errors
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3749
> 
> Update package YAML files to ignore ECC errors that are
> already present.  These issues must be fixed in the future,
> but should not block source code changes for these known
> issues.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  CryptoPkg/CryptoPkg.ci.yaml | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
> index 1448299073de..eeb388ae71c5 100644
> --- a/CryptoPkg/CryptoPkg.ci.yaml
> +++ b/CryptoPkg/CryptoPkg.ci.yaml
> @@ -19,6 +19,9 @@
>          ##     "<ErrorID>", "<KeyWord>"
>          ## ]
>          "ExceptionList": [
> +            "8001", "IsLeap",
> +            "8001", "OBJ_get0_data",
> +            "8001", "OBJ_length"
>          ],
>          ## Both file path and directory path are accepted.
>          "IgnoreFiles": [
> @@ -26,14 +29,15 @@
>              # The unit testing folder is not to be checked
>              "Test/UnitTest",
>              # This has OpenSSL interfaces that aren't UEFI spec compliant
> -            "Library/BaseCryptLib/SysCall/UnitTestHostCrtWrapper.c",
> +            "Library/BaseCryptLib/SysCall",
>              # This has OpenSSL interfaces that aren't UEFI spec compliant
>              "Library/OpensslLib/rand_pool.c",
>              # This has OpenSSL interfaces that aren't UEFI spec compliant
>              "Library/Include/CrtLibSupport.h",
>              # These directories contain auto-generated OpenSSL content
> -            "Library/OpensslLib/X64",
> -            "Library/OpensslLib/X64Gcc"
> +            "Library/OpensslLib",
> +            "Library/IntrinsicLib",
> +            "Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"
>          ]
>      },
>      "CompilerPlugin": {
> --
> 2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84121): https://edk2.groups.io/g/devel/message/84121
Mute This Topic: https://groups.io/mt/87268738/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-