1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)

Philippe Mathieu-Daudé posted 1 patch 2 years, 5 months ago
Failed in applying to current master (apply log)
OvmfPkg/AmdSev/AmdSevX64.dsc   | 1 -
OvmfPkg/Bhyve/BhyveX64.dsc     | 1 -
OvmfPkg/Microvm/MicrovmX64.dsc | 1 -
OvmfPkg/OvmfPkgIa32.dsc        | 1 -
OvmfPkg/OvmfPkgIa32X64.dsc     | 1 -
OvmfPkg/OvmfPkgX64.dsc         | 1 -
OvmfPkg/OvmfXen.dsc            | 1 -
OvmfPkg/AmdSev/AmdSevX64.fdf   | 1 -
OvmfPkg/Bhyve/BhyveX64.fdf     | 1 -
OvmfPkg/Microvm/MicrovmX64.fdf | 1 -
OvmfPkg/OvmfPkgIa32.fdf        | 1 -
OvmfPkg/OvmfPkgIa32X64.fdf     | 1 -
OvmfPkg/OvmfPkgX64.fdf         | 1 -
OvmfPkg/OvmfXen.fdf            | 1 -
14 files changed, 14 deletions(-)
[edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)
Posted by Philippe Mathieu-Daudé 2 years, 5 months ago 
From: Philippe Mathieu-Daude <philmd@redhat.com>

PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid,
and those are consumed by the following PrintLib instance:

MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf

However, none of the OVMF DSC files contain such a PrintLib class
resolution, so none of the OVMF platforms need PrintDxe.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Suggested-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3744
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
Since v3:
- Remove from MicrovmX64
- Reference BZ#3744 (Jiewen Yao)
- Add Jiewen Yao R-b tag

 OvmfPkg/AmdSev/AmdSevX64.dsc   | 1 -
 OvmfPkg/Bhyve/BhyveX64.dsc     | 1 -
 OvmfPkg/Microvm/MicrovmX64.dsc | 1 -
 OvmfPkg/OvmfPkgIa32.dsc        | 1 -
 OvmfPkg/OvmfPkgIa32X64.dsc     | 1 -
 OvmfPkg/OvmfPkgX64.dsc         | 1 -
 OvmfPkg/OvmfXen.dsc            | 1 -
 OvmfPkg/AmdSev/AmdSevX64.fdf   | 1 -
 OvmfPkg/Bhyve/BhyveX64.fdf     | 1 -
 OvmfPkg/Microvm/MicrovmX64.fdf | 1 -
 OvmfPkg/OvmfPkgIa32.fdf        | 1 -
 OvmfPkg/OvmfPkgIa32X64.fdf     | 1 -
 OvmfPkg/OvmfPkgX64.fdf         | 1 -
 OvmfPkg/OvmfXen.fdf            | 1 -
 14 files changed, 14 deletions(-)

diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
index 5ee54451169b..24f228936703 100644
--- a/OvmfPkg/AmdSev/AmdSevX64.dsc
+++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
@@ -731,7 +731,6 @@ [Components]
       DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
       PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   }
-  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
   MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
   MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
   MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
index d8fe607d1cf7..268c18fe3bfc 100644
--- a/OvmfPkg/Bhyve/BhyveX64.dsc
+++ b/OvmfPkg/Bhyve/BhyveX64.dsc
@@ -675,7 +675,6 @@ [Components]
       DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
       PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   }
-  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
   MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
   MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
   MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc
index 617f92539518..a8c975a6bd04 100644
--- a/OvmfPkg/Microvm/MicrovmX64.dsc
+++ b/OvmfPkg/Microvm/MicrovmX64.dsc
@@ -710,7 +710,6 @@ [Components]
       DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
       PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   }
-  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
   MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
   MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
   MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
index 6a5be97c059d..074c77826344 100644
--- a/OvmfPkg/OvmfPkgIa32.dsc
+++ b/OvmfPkg/OvmfPkgIa32.dsc
@@ -825,7 +825,6 @@ [Components]
       DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
       PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   }
-  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
   MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
   MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
   MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index 71227d1b709a..cf17e63c6319 100644
--- a/OvmfPkg/OvmfPkgIa32X64.dsc
+++ b/OvmfPkg/OvmfPkgIa32X64.dsc
@@ -839,7 +839,6 @@ [Components.X64]
       DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
       PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   }
-  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
   MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
   MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
   MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index 52f7598cf1c7..787d1086ee7e 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -837,7 +837,6 @@ [Components]
       DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
       PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   }
-  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
   MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
   MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
   MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
index a31519e356b7..fcf1188a3c47 100644
--- a/OvmfPkg/OvmfXen.dsc
+++ b/OvmfPkg/OvmfXen.dsc
@@ -614,7 +614,6 @@ [Components]
       DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
       PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
   }
-  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
   MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
   MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
   MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf
index 56626098862c..5a84393b00a0 100644
--- a/OvmfPkg/AmdSev/AmdSevX64.fdf
+++ b/OvmfPkg/AmdSev/AmdSevX64.fdf
@@ -245,7 +245,6 @@ [FV.DXEFV]
 INF  MdeModulePkg/Application/UiApp/UiApp.inf
 INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
 INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
-INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
 INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
 INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
 INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf
index b3b4d44cef34..e8227f865f75 100644
--- a/OvmfPkg/Bhyve/BhyveX64.fdf
+++ b/OvmfPkg/Bhyve/BhyveX64.fdf
@@ -233,7 +233,6 @@ [FV.DXEFV]
 INF  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
 INF  MdeModulePkg/Application/UiApp/UiApp.inf
 INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
-INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
 INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
 INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
 INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/Microvm/MicrovmX64.fdf b/OvmfPkg/Microvm/MicrovmX64.fdf
index 6314014f3de7..b6f080768835 100644
--- a/OvmfPkg/Microvm/MicrovmX64.fdf
+++ b/OvmfPkg/Microvm/MicrovmX64.fdf
@@ -244,7 +244,6 @@ [FV.DXEFV]
 INF  MdeModulePkg/Application/UiApp/UiApp.inf
 INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
 INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
-INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
 INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
 INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
 INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf
index 775ea2d71098..c30e5281872f 100644
--- a/OvmfPkg/OvmfPkgIa32.fdf
+++ b/OvmfPkg/OvmfPkgIa32.fdf
@@ -255,7 +255,6 @@ [FV.DXEFV]
 INF  MdeModulePkg/Application/UiApp/UiApp.inf
 INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
 INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
-INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
 INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
 INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
 INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf
index 9d8695922f97..78a01b6663ad 100644
--- a/OvmfPkg/OvmfPkgIa32X64.fdf
+++ b/OvmfPkg/OvmfPkgIa32X64.fdf
@@ -259,7 +259,6 @@ [FV.DXEFV]
 INF  MdeModulePkg/Application/UiApp/UiApp.inf
 INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
 INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
-INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
 INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
 INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
 INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
index b6cc3cabdd69..a2c7a4d7a48d 100644
--- a/OvmfPkg/OvmfPkgX64.fdf
+++ b/OvmfPkg/OvmfPkgX64.fdf
@@ -275,7 +275,6 @@ [FV.DXEFV]
 INF  MdeModulePkg/Application/UiApp/UiApp.inf
 INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
 INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
-INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
 INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
 INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
 INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf
index 8b5823555937..a6acf3b835aa 100644
--- a/OvmfPkg/OvmfXen.fdf
+++ b/OvmfPkg/OvmfXen.fdf
@@ -326,7 +326,6 @@ [FV.DXEFV]
 INF  MdeModulePkg/Application/UiApp/UiApp.inf
 INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
 INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
-INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
 INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
 INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
 INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
-- 
2.31.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83894): https://edk2.groups.io/g/devel/message/83894
Mute This Topic: https://groups.io/mt/87153227/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)
Posted by Gerd Hoffmann 2 years, 5 months ago 
On Thu, Nov 18, 2021 at 09:46:21PM +0100, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> 
> PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid,
> and those are consumed by the following PrintLib instance:
> 
> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf
> 
> However, none of the OVMF DSC files contain such a PrintLib class
> resolution, so none of the OVMF platforms need PrintDxe.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3744
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83900): https://edk2.groups.io/g/devel/message/83900
Mute This Topic: https://groups.io/mt/87153227/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)
Posted by Philippe Mathieu-Daudé 2 years, 4 months ago 
Ping?

On 11/18/21 21:46, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> 
> PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid,
> and those are consumed by the following PrintLib instance:
> 
> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf
> 
> However, none of the OVMF DSC files contain such a PrintLib class
> resolution, so none of the OVMF platforms need PrintDxe.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Erdem Aktas <erdemaktas@google.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: James Bottomley <jejb@linux.ibm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Min Xu <min.m.xu@intel.com>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3744
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> Since v3:
> - Remove from MicrovmX64
> - Reference BZ#3744 (Jiewen Yao)
> - Add Jiewen Yao R-b tag
> 
>  OvmfPkg/AmdSev/AmdSevX64.dsc   | 1 -
>  OvmfPkg/Bhyve/BhyveX64.dsc     | 1 -
>  OvmfPkg/Microvm/MicrovmX64.dsc | 1 -
>  OvmfPkg/OvmfPkgIa32.dsc        | 1 -
>  OvmfPkg/OvmfPkgIa32X64.dsc     | 1 -
>  OvmfPkg/OvmfPkgX64.dsc         | 1 -
>  OvmfPkg/OvmfXen.dsc            | 1 -
>  OvmfPkg/AmdSev/AmdSevX64.fdf   | 1 -
>  OvmfPkg/Bhyve/BhyveX64.fdf     | 1 -
>  OvmfPkg/Microvm/MicrovmX64.fdf | 1 -
>  OvmfPkg/OvmfPkgIa32.fdf        | 1 -
>  OvmfPkg/OvmfPkgIa32X64.fdf     | 1 -
>  OvmfPkg/OvmfPkgX64.fdf         | 1 -
>  OvmfPkg/OvmfXen.fdf            | 1 -
>  14 files changed, 14 deletions(-)
> 
> diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
> index 5ee54451169b..24f228936703 100644
> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc
> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
> @@ -731,7 +731,6 @@ [Components]
>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>    }
> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
> index d8fe607d1cf7..268c18fe3bfc 100644
> --- a/OvmfPkg/Bhyve/BhyveX64.dsc
> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
> @@ -675,7 +675,6 @@ [Components]
>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>    }
> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc
> index 617f92539518..a8c975a6bd04 100644
> --- a/OvmfPkg/Microvm/MicrovmX64.dsc
> +++ b/OvmfPkg/Microvm/MicrovmX64.dsc
> @@ -710,7 +710,6 @@ [Components]
>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>    }
> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index 6a5be97c059d..074c77826344 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -825,7 +825,6 @@ [Components]
>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>    }
> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index 71227d1b709a..cf17e63c6319 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -839,7 +839,6 @@ [Components.X64]
>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>    }
> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index 52f7598cf1c7..787d1086ee7e 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -837,7 +837,6 @@ [Components]
>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>    }
> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> index a31519e356b7..fcf1188a3c47 100644
> --- a/OvmfPkg/OvmfXen.dsc
> +++ b/OvmfPkg/OvmfXen.dsc
> @@ -614,7 +614,6 @@ [Components]
>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>    }
> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf
> index 56626098862c..5a84393b00a0 100644
> --- a/OvmfPkg/AmdSev/AmdSevX64.fdf
> +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf
> @@ -245,7 +245,6 @@ [FV.DXEFV]
>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf
> index b3b4d44cef34..e8227f865f75 100644
> --- a/OvmfPkg/Bhyve/BhyveX64.fdf
> +++ b/OvmfPkg/Bhyve/BhyveX64.fdf
> @@ -233,7 +233,6 @@ [FV.DXEFV]
>  INF  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/Microvm/MicrovmX64.fdf b/OvmfPkg/Microvm/MicrovmX64.fdf
> index 6314014f3de7..b6f080768835 100644
> --- a/OvmfPkg/Microvm/MicrovmX64.fdf
> +++ b/OvmfPkg/Microvm/MicrovmX64.fdf
> @@ -244,7 +244,6 @@ [FV.DXEFV]
>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf
> index 775ea2d71098..c30e5281872f 100644
> --- a/OvmfPkg/OvmfPkgIa32.fdf
> +++ b/OvmfPkg/OvmfPkgIa32.fdf
> @@ -255,7 +255,6 @@ [FV.DXEFV]
>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf
> index 9d8695922f97..78a01b6663ad 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.fdf
> +++ b/OvmfPkg/OvmfPkgIa32X64.fdf
> @@ -259,7 +259,6 @@ [FV.DXEFV]
>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
> index b6cc3cabdd69..a2c7a4d7a48d 100644
> --- a/OvmfPkg/OvmfPkgX64.fdf
> +++ b/OvmfPkg/OvmfPkgX64.fdf
> @@ -275,7 +275,6 @@ [FV.DXEFV]
>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf
> index 8b5823555937..a6acf3b835aa 100644
> --- a/OvmfPkg/OvmfXen.fdf
> +++ b/OvmfPkg/OvmfXen.fdf
> @@ -326,7 +326,6 @@ [FV.DXEFV]
>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84521): https://edk2.groups.io/g/devel/message/84521
Mute This Topic: https://groups.io/mt/87153227/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)
Posted by Ard Biesheuvel 2 years, 4 months ago 
On Wed, 8 Dec 2021 at 17:43, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Ping?
>

I'll pick this up once the stable tag is released.

> On 11/18/21 21:46, Philippe Mathieu-Daudé wrote:
> > From: Philippe Mathieu-Daude <philmd@redhat.com>
> >
> > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid,
> > and those are consumed by the following PrintLib instance:
> >
> > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf
> >
> > However, none of the OVMF DSC files contain such a PrintLib class
> > resolution, so none of the OVMF platforms need PrintDxe.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Brijesh Singh <brijesh.singh@amd.com>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Min Xu <min.m.xu@intel.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Suggested-by: Laszlo Ersek <lersek@redhat.com>
> > Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3744
> > Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> > ---
> > Since v3:
> > - Remove from MicrovmX64
> > - Reference BZ#3744 (Jiewen Yao)
> > - Add Jiewen Yao R-b tag
> >
> >  OvmfPkg/AmdSev/AmdSevX64.dsc   | 1 -
> >  OvmfPkg/Bhyve/BhyveX64.dsc     | 1 -
> >  OvmfPkg/Microvm/MicrovmX64.dsc | 1 -
> >  OvmfPkg/OvmfPkgIa32.dsc        | 1 -
> >  OvmfPkg/OvmfPkgIa32X64.dsc     | 1 -
> >  OvmfPkg/OvmfPkgX64.dsc         | 1 -
> >  OvmfPkg/OvmfXen.dsc            | 1 -
> >  OvmfPkg/AmdSev/AmdSevX64.fdf   | 1 -
> >  OvmfPkg/Bhyve/BhyveX64.fdf     | 1 -
> >  OvmfPkg/Microvm/MicrovmX64.fdf | 1 -
> >  OvmfPkg/OvmfPkgIa32.fdf        | 1 -
> >  OvmfPkg/OvmfPkgIa32X64.fdf     | 1 -
> >  OvmfPkg/OvmfPkgX64.fdf         | 1 -
> >  OvmfPkg/OvmfXen.fdf            | 1 -
> >  14 files changed, 14 deletions(-)
> >
> > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
> > index 5ee54451169b..24f228936703 100644
> > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc
> > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
> > @@ -731,7 +731,6 @@ [Components]
> >        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> >        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> >    }
> > -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
> > index d8fe607d1cf7..268c18fe3bfc 100644
> > --- a/OvmfPkg/Bhyve/BhyveX64.dsc
> > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
> > @@ -675,7 +675,6 @@ [Components]
> >        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> >        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> >    }
> > -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc
> > index 617f92539518..a8c975a6bd04 100644
> > --- a/OvmfPkg/Microvm/MicrovmX64.dsc
> > +++ b/OvmfPkg/Microvm/MicrovmX64.dsc
> > @@ -710,7 +710,6 @@ [Components]
> >        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> >        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> >    }
> > -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> > index 6a5be97c059d..074c77826344 100644
> > --- a/OvmfPkg/OvmfPkgIa32.dsc
> > +++ b/OvmfPkg/OvmfPkgIa32.dsc
> > @@ -825,7 +825,6 @@ [Components]
> >        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> >        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> >    }
> > -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> > index 71227d1b709a..cf17e63c6319 100644
> > --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> > @@ -839,7 +839,6 @@ [Components.X64]
> >        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> >        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> >    }
> > -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> > index 52f7598cf1c7..787d1086ee7e 100644
> > --- a/OvmfPkg/OvmfPkgX64.dsc
> > +++ b/OvmfPkg/OvmfPkgX64.dsc
> > @@ -837,7 +837,6 @@ [Components]
> >        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> >        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> >    }
> > -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> > index a31519e356b7..fcf1188a3c47 100644
> > --- a/OvmfPkg/OvmfXen.dsc
> > +++ b/OvmfPkg/OvmfXen.dsc
> > @@ -614,7 +614,6 @@ [Components]
> >        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> >        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> >    }
> > -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf
> > index 56626098862c..5a84393b00a0 100644
> > --- a/OvmfPkg/AmdSev/AmdSevX64.fdf
> > +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf
> > @@ -245,7 +245,6 @@ [FV.DXEFV]
> >  INF  MdeModulePkg/Application/UiApp/UiApp.inf
> >  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> >  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf
> > index b3b4d44cef34..e8227f865f75 100644
> > --- a/OvmfPkg/Bhyve/BhyveX64.fdf
> > +++ b/OvmfPkg/Bhyve/BhyveX64.fdf
> > @@ -233,7 +233,6 @@ [FV.DXEFV]
> >  INF  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> >  INF  MdeModulePkg/Application/UiApp/UiApp.inf
> >  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/Microvm/MicrovmX64.fdf b/OvmfPkg/Microvm/MicrovmX64.fdf
> > index 6314014f3de7..b6f080768835 100644
> > --- a/OvmfPkg/Microvm/MicrovmX64.fdf
> > +++ b/OvmfPkg/Microvm/MicrovmX64.fdf
> > @@ -244,7 +244,6 @@ [FV.DXEFV]
> >  INF  MdeModulePkg/Application/UiApp/UiApp.inf
> >  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> >  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf
> > index 775ea2d71098..c30e5281872f 100644
> > --- a/OvmfPkg/OvmfPkgIa32.fdf
> > +++ b/OvmfPkg/OvmfPkgIa32.fdf
> > @@ -255,7 +255,6 @@ [FV.DXEFV]
> >  INF  MdeModulePkg/Application/UiApp/UiApp.inf
> >  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> >  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf
> > index 9d8695922f97..78a01b6663ad 100644
> > --- a/OvmfPkg/OvmfPkgIa32X64.fdf
> > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf
> > @@ -259,7 +259,6 @@ [FV.DXEFV]
> >  INF  MdeModulePkg/Application/UiApp/UiApp.inf
> >  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> >  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
> > index b6cc3cabdd69..a2c7a4d7a48d 100644
> > --- a/OvmfPkg/OvmfPkgX64.fdf
> > +++ b/OvmfPkg/OvmfPkgX64.fdf
> > @@ -275,7 +275,6 @@ [FV.DXEFV]
> >  INF  MdeModulePkg/Application/UiApp/UiApp.inf
> >  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> >  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> > diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf
> > index 8b5823555937..a6acf3b835aa 100644
> > --- a/OvmfPkg/OvmfXen.fdf
> > +++ b/OvmfPkg/OvmfXen.fdf
> > @@ -326,7 +326,6 @@ [FV.DXEFV]
> >  INF  MdeModulePkg/Application/UiApp/UiApp.inf
> >  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
> >  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
> > -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
> >  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
> >
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84522): https://edk2.groups.io/g/devel/message/84522
Mute This Topic: https://groups.io/mt/87153227/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)
Posted by Philippe Mathieu-Daudé 2 years, 4 months ago 
On 12/8/21 17:47, Ard Biesheuvel wrote:
> On Wed, 8 Dec 2021 at 17:43, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> Ping?
>>
> 
> I'll pick this up once the stable tag is released.

Oh, I read "The hard freeze has ended and normal development
activities can continue." in https://edk2.groups.io/g/devel/message/84458
but didn't notice the tag was not yet pushed.

Thanks for picking this patch Ard :)

> 
>> On 11/18/21 21:46, Philippe Mathieu-Daudé wrote:
>>> From: Philippe Mathieu-Daude <philmd@redhat.com>
>>>
>>> PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid,
>>> and those are consumed by the following PrintLib instance:
>>>
>>> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf
>>>
>>> However, none of the OVMF DSC files contain such a PrintLib class
>>> resolution, so none of the OVMF platforms need PrintDxe.
>>>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Brijesh Singh <brijesh.singh@amd.com>
>>> Cc: Erdem Aktas <erdemaktas@google.com>
>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>> Cc: James Bottomley <jejb@linux.ibm.com>
>>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>>> Cc: Min Xu <min.m.xu@intel.com>
>>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>>> Suggested-by: Laszlo Ersek <lersek@redhat.com>
>>> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3744
>>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>> ---
>>> Since v3:
>>> - Remove from MicrovmX64
>>> - Reference BZ#3744 (Jiewen Yao)
>>> - Add Jiewen Yao R-b tag
>>>
>>>  OvmfPkg/AmdSev/AmdSevX64.dsc   | 1 -
>>>  OvmfPkg/Bhyve/BhyveX64.dsc     | 1 -
>>>  OvmfPkg/Microvm/MicrovmX64.dsc | 1 -
>>>  OvmfPkg/OvmfPkgIa32.dsc        | 1 -
>>>  OvmfPkg/OvmfPkgIa32X64.dsc     | 1 -
>>>  OvmfPkg/OvmfPkgX64.dsc         | 1 -
>>>  OvmfPkg/OvmfXen.dsc            | 1 -
>>>  OvmfPkg/AmdSev/AmdSevX64.fdf   | 1 -
>>>  OvmfPkg/Bhyve/BhyveX64.fdf     | 1 -
>>>  OvmfPkg/Microvm/MicrovmX64.fdf | 1 -
>>>  OvmfPkg/OvmfPkgIa32.fdf        | 1 -
>>>  OvmfPkg/OvmfPkgIa32X64.fdf     | 1 -
>>>  OvmfPkg/OvmfPkgX64.fdf         | 1 -
>>>  OvmfPkg/OvmfXen.fdf            | 1 -
>>>  14 files changed, 14 deletions(-)
>>>
>>> diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc
>>> index 5ee54451169b..24f228936703 100644
>>> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc
>>> +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc
>>> @@ -731,7 +731,6 @@ [Components]
>>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>>    }
>>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
>>> index d8fe607d1cf7..268c18fe3bfc 100644
>>> --- a/OvmfPkg/Bhyve/BhyveX64.dsc
>>> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
>>> @@ -675,7 +675,6 @@ [Components]
>>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>>    }
>>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc
>>> index 617f92539518..a8c975a6bd04 100644
>>> --- a/OvmfPkg/Microvm/MicrovmX64.dsc
>>> +++ b/OvmfPkg/Microvm/MicrovmX64.dsc
>>> @@ -710,7 +710,6 @@ [Components]
>>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>>    }
>>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
>>> index 6a5be97c059d..074c77826344 100644
>>> --- a/OvmfPkg/OvmfPkgIa32.dsc
>>> +++ b/OvmfPkg/OvmfPkgIa32.dsc
>>> @@ -825,7 +825,6 @@ [Components]
>>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>>    }
>>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
>>> index 71227d1b709a..cf17e63c6319 100644
>>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
>>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
>>> @@ -839,7 +839,6 @@ [Components.X64]
>>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>>    }
>>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
>>> index 52f7598cf1c7..787d1086ee7e 100644
>>> --- a/OvmfPkg/OvmfPkgX64.dsc
>>> +++ b/OvmfPkg/OvmfPkgX64.dsc
>>> @@ -837,7 +837,6 @@ [Components]
>>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>>    }
>>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
>>> index a31519e356b7..fcf1188a3c47 100644
>>> --- a/OvmfPkg/OvmfXen.dsc
>>> +++ b/OvmfPkg/OvmfXen.dsc
>>> @@ -614,7 +614,6 @@ [Components]
>>>        DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>>>        PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>>>    }
>>> -  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>    MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>    MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>    MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf
>>> index 56626098862c..5a84393b00a0 100644
>>> --- a/OvmfPkg/AmdSev/AmdSevX64.fdf
>>> +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf
>>> @@ -245,7 +245,6 @@ [FV.DXEFV]
>>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf
>>> index b3b4d44cef34..e8227f865f75 100644
>>> --- a/OvmfPkg/Bhyve/BhyveX64.fdf
>>> +++ b/OvmfPkg/Bhyve/BhyveX64.fdf
>>> @@ -233,7 +233,6 @@ [FV.DXEFV]
>>>  INF  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
>>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/Microvm/MicrovmX64.fdf b/OvmfPkg/Microvm/MicrovmX64.fdf
>>> index 6314014f3de7..b6f080768835 100644
>>> --- a/OvmfPkg/Microvm/MicrovmX64.fdf
>>> +++ b/OvmfPkg/Microvm/MicrovmX64.fdf
>>> @@ -244,7 +244,6 @@ [FV.DXEFV]
>>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf
>>> index 775ea2d71098..c30e5281872f 100644
>>> --- a/OvmfPkg/OvmfPkgIa32.fdf
>>> +++ b/OvmfPkg/OvmfPkgIa32.fdf
>>> @@ -255,7 +255,6 @@ [FV.DXEFV]
>>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf
>>> index 9d8695922f97..78a01b6663ad 100644
>>> --- a/OvmfPkg/OvmfPkgIa32X64.fdf
>>> +++ b/OvmfPkg/OvmfPkgIa32X64.fdf
>>> @@ -259,7 +259,6 @@ [FV.DXEFV]
>>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
>>> index b6cc3cabdd69..a2c7a4d7a48d 100644
>>> --- a/OvmfPkg/OvmfPkgX64.fdf
>>> +++ b/OvmfPkg/OvmfPkgX64.fdf
>>> @@ -275,7 +275,6 @@ [FV.DXEFV]
>>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>> diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf
>>> index 8b5823555937..a6acf3b835aa 100644
>>> --- a/OvmfPkg/OvmfXen.fdf
>>> +++ b/OvmfPkg/OvmfXen.fdf
>>> @@ -326,7 +326,6 @@ [FV.DXEFV]
>>>  INF  MdeModulePkg/Application/UiApp/UiApp.inf
>>>  INF  OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf
>>>  INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
>>> -INF  MdeModulePkg/Universal/PrintDxe/PrintDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>>>  INF  MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>>>
>>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84523): https://edk2.groups.io/g/devel/message/84523
Mute This Topic: https://groups.io/mt/87153227/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)
Posted by Ard Biesheuvel 2 years, 4 months ago 
On Wed, 8 Dec 2021 at 18:22, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 12/8/21 17:47, Ard Biesheuvel wrote:
> > On Wed, 8 Dec 2021 at 17:43, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> >>
> >> Ping?
> >>
> >
> > I'll pick this up once the stable tag is released.
>
> Oh, I read "The hard freeze has ended and normal development
> activities can continue." in https://edk2.groups.io/g/devel/message/84458
> but didn't notice the tag was not yet pushed.
>
> Thanks for picking this patch Ard :)
>

Merged as #2284


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84634): https://edk2.groups.io/g/devel/message/84634
Mute This Topic: https://groups.io/mt/87153227/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.