Socionext housekeeping

[edk2-devel] [PATCH edk2-platforms 0/2] Socionext housekeeping

Posted by Leif Lindholm 4 years, 2 months ago

Masami - while looking at your set from last Friday, patch 1/5 fails
to apply since the file being modified has the wrong line endings in
the tree.

2/2 fixes that.
(Obviously, the patch looks nonsensical since SMTP strips the added CR
back out.)

1/2 adds you as a reviewer to the Socionext platforms. (This means
that you will be cc:d on any future patches to these, and that I
can use your Reviewed-by for 2/2.)

Does this sound good to you?

Leif Lindholm (2):
  Maintainers.txt: add Masami as Socionext reviewer
  Silicon/Socionext: fix line endings

 Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 1162 ++++++++++----------
 Maintainers.txt                                                       |    1 +
 2 files changed, 582 insertions(+), 581 deletions(-)

-- 
2.30.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83641): https://edk2.groups.io/g/devel/message/83641
Mute This Topic: https://groups.io/mt/86979607/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Socionext housekeeping

Posted by Ard Biesheuvel 4 years, 2 months ago

On Thu, 11 Nov 2021 at 12:59, Leif Lindholm <leif@nuviainc.com> wrote:
>
> Masami - while looking at your set from last Friday, patch 1/5 fails
> to apply since the file being modified has the wrong line endings in
> the tree.
>
> 2/2 fixes that.
> (Obviously, the patch looks nonsensical since SMTP strips the added CR
> back out.)
>
> 1/2 adds you as a reviewer to the Socionext platforms. (This means
> that you will be cc:d on any future patches to these, and that I
> can use your Reviewed-by for 2/2.)
>
> Does this sound good to you?
>
> Leif Lindholm (2):
>   Maintainers.txt: add Masami as Socionext reviewer
>   Silicon/Socionext: fix line endings
>

Acked-by: Ard BIesheuvel <ardb@kernel.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83644): https://edk2.groups.io/g/devel/message/83644
Mute This Topic: https://groups.io/mt/86979607/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Socionext housekeeping

Posted by Masami Hiramatsu 4 years, 2 months ago

Hi Leif,

Sorry for replying late.

2021年11月11日(木) 20:59 Leif Lindholm <leif@nuviainc.com>:
>
> Masami - while looking at your set from last Friday, patch 1/5 fails
> to apply since the file being modified has the wrong line endings in
> the tree.

Oh, OK. is it CR/LF?

>
> 2/2 fixes that.
> (Obviously, the patch looks nonsensical since SMTP strips the added CR
> back out.)

Thanks for fixing!

>
> 1/2 adds you as a reviewer to the Socionext platforms. (This means
> that you will be cc:d on any future patches to these, and that I
> can use your Reviewed-by for 2/2.)
>
> Does this sound good to you?

Yes, these look good to me.

Acked-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>

for the series.

Thank you!

>
> Leif Lindholm (2):
>   Maintainers.txt: add Masami as Socionext reviewer
>   Silicon/Socionext: fix line endings
>
>  Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 1162 ++++++++++----------
>  Maintainers.txt                                                       |    1 +
>  2 files changed, 582 insertions(+), 581 deletions(-)
>
> --
> 2.30.2
>


-- 
Masami Hiramatsu


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84090): https://edk2.groups.io/g/devel/message/84090
Mute This Topic: https://groups.io/mt/86979607/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Socionext housekeeping

Posted by Leif Lindholm 4 years, 2 months ago

On Fri, Nov 26, 2021 at 09:56:29 +0900, Masami Hiramatsu wrote:
> Hi Leif,
> 
> Sorry for replying late.
> 
> 2021年11月11日(木) 20:59 Leif Lindholm <leif@nuviainc.com>:
> >
> > Masami - while looking at your set from last Friday, patch 1/5 fails
> > to apply since the file being modified has the wrong line endings in
> > the tree.
> 
> Oh, OK. is it CR/LF?
> 
> >
> > 2/2 fixes that.
> > (Obviously, the patch looks nonsensical since SMTP strips the added CR
> > back out.)
> 
> Thanks for fixing!
> 
> >
> > 1/2 adds you as a reviewer to the Socionext platforms. (This means
> > that you will be cc:d on any future patches to these, and that I
> > can use your Reviewed-by for 2/2.)
> >
> > Does this sound good to you?
> 
> Yes, these look good to me.
> 
> Acked-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> 
> for the series.

Thank you - pushed as:
7f86d9002533..3e73df157306

/
    Leif

> Thank you!
> 
> >
> > Leif Lindholm (2):
> >   Maintainers.txt: add Masami as Socionext reviewer
> >   Silicon/Socionext: fix line endings
> >
> >  Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 1162 ++++++++++----------
> >  Maintainers.txt                                                       |    1 +
> >  2 files changed, 582 insertions(+), 581 deletions(-)
> >
> > --
> > 2.30.2
> >
> 
> 
> -- 
> Masami Hiramatsu


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84099): https://edk2.groups.io/g/devel/message/84099
Mute This Topic: https://groups.io/mt/86979607/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-