1. Patchew
  2. EDK2
  3. [edk2-devel] [Patch 0/6] Fix package build issues
  4. View patch

[edk2-devel] [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64

Michael D Kinney posted 6 patches 4 years, 3 months ago
There is a newer version of this series
[edk2-devel] [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64
Posted by Michael D Kinney 4 years, 3 months ago 
Fix NetworkPkg build breaks for ARM and RISCV64 by adding RngLib
mapping.

Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Abner Chang <abner.chang@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 NetworkPkg/NetworkPkg.dsc | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
index cf2164aefe25..8691a0f5d07a 100644
--- a/NetworkPkg/NetworkPkg.dsc
+++ b/NetworkPkg/NetworkPkg.dsc
@@ -79,6 +79,12 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64]
   NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
   ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
 
+[LibraryClasses.ARM]
+  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
+
+[LibraryClasses.RISCV64]
+  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
+
 [PcdsFeatureFlag]
   gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE
   gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE
-- 
2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83207): https://edk2.groups.io/g/devel/message/83207
Mute This Topic: https://groups.io/mt/86783673/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64
Posted by Maciej Rabeda 4 years, 3 months ago 
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

Mike,

Who is going to do the PR?

Thanks,
Maciej

On 03-Nov-21 04:05, Michael D Kinney wrote:
> Fix NetworkPkg build breaks for ARM and RISCV64 by adding RngLib
> mapping.
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   NetworkPkg/NetworkPkg.dsc | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
> index cf2164aefe25..8691a0f5d07a 100644
> --- a/NetworkPkg/NetworkPkg.dsc
> +++ b/NetworkPkg/NetworkPkg.dsc
> @@ -79,6 +79,12 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64]
>     NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>     ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
>   
> +[LibraryClasses.ARM]
> +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> +
> +[LibraryClasses.RISCV64]
> +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> +
>   [PcdsFeatureFlag]
>     gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE
>     gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83287): https://edk2.groups.io/g/devel/message/83287
Mute This Topic: https://groups.io/mt/86783673/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64
Posted by Michael D Kinney 4 years, 3 months ago 
I will do the PR for the series once all the reviews are complete.

Thanks,

Mike

> -----Original Message-----
> From: Rabeda, Maciej <maciej.rabeda@linux.intel.com>
> Sent: Wednesday, November 3, 2021 2:25 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Chang,
> Abner <abner.chang@hpe.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>
> Subject: Re: [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64
> 
> Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> 
> Mike,
> 
> Who is going to do the PR?
> 
> Thanks,
> Maciej
> 
> On 03-Nov-21 04:05, Michael D Kinney wrote:
> > Fix NetworkPkg build breaks for ARM and RISCV64 by adding RngLib
> > mapping.
> >
> > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> > Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> > Cc: Siyuan Fu <siyuan.fu@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Abner Chang <abner.chang@hpe.com>
> > Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >   NetworkPkg/NetworkPkg.dsc | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
> > index cf2164aefe25..8691a0f5d07a 100644
> > --- a/NetworkPkg/NetworkPkg.dsc
> > +++ b/NetworkPkg/NetworkPkg.dsc
> > @@ -79,6 +79,12 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64]
> >     NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> >     ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> >
> > +[LibraryClasses.ARM]
> > +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> > +
> > +[LibraryClasses.RISCV64]
> > +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> > +
> >   [PcdsFeatureFlag]
> >     gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE
> >     gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83289): https://edk2.groups.io/g/devel/message/83289
Mute This Topic: https://groups.io/mt/86783673/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch 2/6] NetworkPkg/NetworkPkg.dsc: Add RngLib mapping for ARM and RISCV64
Posted by Daniel Schaefer 4 years, 3 months ago 
Perfect, thanks.
I think BaseRngLib has an implementation for ARM or perhaps only AARCH64.
I'm working one for RISCV64: https://bugzilla.tianocore.org/show_bug.cgi?id=3676

But until then this is good.

Reviewed-by: Daniel Schaefer <daniel.schaefer@hpe.com>

On 11/3/21 11:05, Michael D Kinney wrote:
> Fix NetworkPkg build breaks for ARM and RISCV64 by adding RngLib
> mapping.
> 
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  NetworkPkg/NetworkPkg.dsc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
> index cf2164aefe25..8691a0f5d07a 100644
> --- a/NetworkPkg/NetworkPkg.dsc
> +++ b/NetworkPkg/NetworkPkg.dsc
> @@ -79,6 +79,12 @@ [LibraryClasses.ARM, LibraryClasses.AARCH64]
>    NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>    ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
>  
> +[LibraryClasses.ARM]
> +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> +
> +[LibraryClasses.RISCV64]
> +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> +
>  [PcdsFeatureFlag]
>    gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE
>    gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83213): https://edk2.groups.io/g/devel/message/83213
Mute This Topic: https://groups.io/mt/86783673/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.