[edk2-devel] [Patch V2 5/7] NetworkPkg: Reproduce builds across source format changes

Michael D Kinney posted 7 patches 4 years, 3 months ago
[edk2-devel] [Patch V2 5/7] NetworkPkg: Reproduce builds across source format changes
Posted by Michael D Kinney 4 years, 3 months ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688

Use DEBUG_LINE_NUMBER instead of __LINE__.

Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 NetworkPkg/Include/Library/NetLib.h      | 8 ++++----
 NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/NetworkPkg/Include/Library/NetLib.h b/NetworkPkg/Include/Library/NetLib.h
index 858d0b6ba07c..6c0924863147 100644
--- a/NetworkPkg/Include/Library/NetLib.h
+++ b/NetworkPkg/Include/Library/NetLib.h
@@ -277,7 +277,7 @@ typedef struct {
     NETDEBUG_LEVEL_TRACE, \
     Module, \
     __FILE__, \
-    __LINE__, \
+    DEBUG_LINE_NUMBER, \
     NetDebugASPrint PrintArg \
     )
 
@@ -286,7 +286,7 @@ typedef struct {
     NETDEBUG_LEVEL_WARNING, \
     Module, \
     __FILE__, \
-    __LINE__, \
+    DEBUG_LINE_NUMBER, \
     NetDebugASPrint PrintArg \
     )
 
@@ -295,7 +295,7 @@ typedef struct {
     NETDEBUG_LEVEL_ERROR, \
     Module, \
     __FILE__, \
-    __LINE__, \
+    DEBUG_LINE_NUMBER, \
     NetDebugASPrint PrintArg \
     )
 
@@ -311,7 +311,7 @@ typedef struct {
            NETDEBUG_LEVEL_TRACE,
            "Tcp",
            __FILE__,
-           __LINE__,
+           DEBUG_LINE_NUMBER,
            NetDebugASPrint ("State transit to %a\n", Name)
          )
 
diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
index 2a555a7b90fa..0f95ce4b710d 100644
--- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
+++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
@@ -434,7 +434,7 @@ SyslogBuildPacket (
            NETDEBUG_LEVEL_TRACE,
            "Tcp",
            __FILE__,
-           __LINE__,
+           DEBUG_LINE_NUMBER,
            NetDebugASPrint ("State transit to %a\n", Name)
          )
 
-- 
2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83059): https://edk2.groups.io/g/devel/message/83059
Mute This Topic: https://groups.io/mt/86752906/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [Patch V2 5/7] NetworkPkg: Reproduce builds across source format changes
Posted by Maciej Rabeda 4 years, 3 months ago
Hey Mike,

Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

Thanks,
Maciej

On 01-Nov-21 22:37, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688
>
> Use DEBUG_LINE_NUMBER instead of __LINE__.
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   NetworkPkg/Include/Library/NetLib.h      | 8 ++++----
>   NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +-
>   2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/NetworkPkg/Include/Library/NetLib.h b/NetworkPkg/Include/Library/NetLib.h
> index 858d0b6ba07c..6c0924863147 100644
> --- a/NetworkPkg/Include/Library/NetLib.h
> +++ b/NetworkPkg/Include/Library/NetLib.h
> @@ -277,7 +277,7 @@ typedef struct {
>       NETDEBUG_LEVEL_TRACE, \
>       Module, \
>       __FILE__, \
> -    __LINE__, \
> +    DEBUG_LINE_NUMBER, \
>       NetDebugASPrint PrintArg \
>       )
>   
> @@ -286,7 +286,7 @@ typedef struct {
>       NETDEBUG_LEVEL_WARNING, \
>       Module, \
>       __FILE__, \
> -    __LINE__, \
> +    DEBUG_LINE_NUMBER, \
>       NetDebugASPrint PrintArg \
>       )
>   
> @@ -295,7 +295,7 @@ typedef struct {
>       NETDEBUG_LEVEL_ERROR, \
>       Module, \
>       __FILE__, \
> -    __LINE__, \
> +    DEBUG_LINE_NUMBER, \
>       NetDebugASPrint PrintArg \
>       )
>   
> @@ -311,7 +311,7 @@ typedef struct {
>              NETDEBUG_LEVEL_TRACE,
>              "Tcp",
>              __FILE__,
> -           __LINE__,
> +           DEBUG_LINE_NUMBER,
>              NetDebugASPrint ("State transit to %a\n", Name)
>            )
>   
> diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> index 2a555a7b90fa..0f95ce4b710d 100644
> --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c
> @@ -434,7 +434,7 @@ SyslogBuildPacket (
>              NETDEBUG_LEVEL_TRACE,
>              "Tcp",
>              __FILE__,
> -           __LINE__,
> +           DEBUG_LINE_NUMBER,
>              NetDebugASPrint ("State transit to %a\n", Name)
>            )
>   



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#83458): https://edk2.groups.io/g/devel/message/83458
Mute This Topic: https://groups.io/mt/86752906/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-