[edk2-devel] [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg

Abner Chang posted 9 patches 2 years, 6 months ago
Failed in applying to current master (apply log)
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc                       | 4 ++--
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                | 4 ++--
Platform/LeMaker/CelloBoard/CelloBoard.dsc                    | 4 ++--
Platform/Phytium/DurianPkg/DurianPkg.dsc                      | 2 +-
Platform/Qemu/SbsaQemu/SbsaQemu.dsc                           | 4 ++--
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc   | 4 ++--
.../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf     | 4 ++--
.../ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf  | 2 +-
.../AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf       | 4 ++--
.../Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf   | 2 +-
Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf               | 4 ++--
.../SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c       | 4 ++--
12 files changed, 21 insertions(+), 21 deletions(-)
[edk2-devel] [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg
Posted by Abner Chang 2 years, 6 months ago
In V3: Fix the commit message in each patch.
       ArmVirtPkg->ArmPkg
In V2: Fix the invalid email address.

This patch set fixes the build error caused by referring to
PcdPciMmio(32)64Translation under ArmPkg. It should use the ones from
MdePkg because of the PCD relocation (BZ:#3665).

https://bugzilla.tianocore.org/show_bug.cgi?id=3665

BZ:#3665 is to migrate some modules from ArmVirtPkg
to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage
those modules without the dependency with Arm*Pkg.
Refer to below message of the pacthes of edk2 portion.
https://edk2.groups.io/g/devel/message/81306

Below PCDs are moved to under MdePkg and leverage by RiscVVirtPkg.
- PcdPciMmio32Translation
- PcdPciMmio64Translation

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Cc: Pierre Gondois <pierre.gondois@arm.com>
Cc: Peng Xie <xiepeng@phytium.com.cn>
Cc: Ling Jia <jialing@phytium.com.cn>
Cc: Yiqi Shu <shuyiqi@phytium.com.cn>

Abner Chang (9):
  Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from
    MdePkg
  Platform/CelloBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
  Platform/Overdrive1000Board: Use PcdPciMmio(32)64Translation PCD from
    MdePkg
  Silicon/Styx: Use PcdPciMmio(32)64Translation PCD from MdePkg
  Platform/ARM: Use PcdPciMmio(32)64Translation PCD from MdePkg
  Platform/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
  Silicon/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
  Platform/DurianPkg: Use PcdPciMmio(32)64Translation PCD from MdePkg
  Silicon/FT2000-4Pkg: Use PcdPciMmio(32)64Translation PCD from MdePkg

 Platform/ARM/SgiPkg/SgiPlatform.dsc.inc                       | 4 ++--
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                | 4 ++--
 Platform/LeMaker/CelloBoard/CelloBoard.dsc                    | 4 ++--
 Platform/Phytium/DurianPkg/DurianPkg.dsc                      | 2 +-
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                           | 4 ++--
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc   | 4 ++--
 .../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf     | 4 ++--
 .../ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf  | 2 +-
 .../AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf       | 4 ++--
 .../Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf   | 2 +-
 Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf               | 4 ++--
 .../SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c       | 4 ++--
 12 files changed, 21 insertions(+), 21 deletions(-)

-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82116): https://edk2.groups.io/g/devel/message/82116
Mute This Topic: https://groups.io/mt/86334480/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg
Posted by Leif Lindholm 2 years, 6 months ago
On Fri, Oct 15, 2021 at 15:32:56 +0800, Abner Chang wrote:
> In V3: Fix the commit message in each patch.
>        ArmVirtPkg->ArmPkg
> In V2: Fix the invalid email address.

Less haste, more speed ;)

Acked-by: Leif Lindholm <leif@nuviainc.com>

> This patch set fixes the build error caused by referring to
> PcdPciMmio(32)64Translation under ArmPkg. It should use the ones from
> MdePkg because of the PCD relocation (BZ:#3665).
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=3665
> 
> BZ:#3665 is to migrate some modules from ArmVirtPkg
> to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage
> those modules without the dependency with Arm*Pkg.
> Refer to below message of the pacthes of edk2 portion.
> https://edk2.groups.io/g/devel/message/81306
> 
> Below PCDs are moved to under MdePkg and leverage by RiscVVirtPkg.
> - PcdPciMmio32Translation
> - PcdPciMmio64Translation
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Peng Xie <xiepeng@phytium.com.cn>
> Cc: Ling Jia <jialing@phytium.com.cn>
> Cc: Yiqi Shu <shuyiqi@phytium.com.cn>
> 
> Abner Chang (9):
>   Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from
>     MdePkg
>   Platform/CelloBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/Overdrive1000Board: Use PcdPciMmio(32)64Translation PCD from
>     MdePkg
>   Silicon/Styx: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/ARM: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Silicon/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/DurianPkg: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Silicon/FT2000-4Pkg: Use PcdPciMmio(32)64Translation PCD from MdePkg
> 
>  Platform/ARM/SgiPkg/SgiPlatform.dsc.inc                       | 4 ++--
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                | 4 ++--
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                    | 4 ++--
>  Platform/Phytium/DurianPkg/DurianPkg.dsc                      | 2 +-
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc                           | 4 ++--
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc   | 4 ++--
>  .../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf     | 4 ++--
>  .../ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf  | 2 +-
>  .../AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf       | 4 ++--
>  .../Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf   | 2 +-
>  Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf               | 4 ++--
>  .../SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c       | 4 ++--
>  12 files changed, 21 insertions(+), 21 deletions(-)
> 
> -- 
> 2.17.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82130): https://edk2.groups.io/g/devel/message/82130
Mute This Topic: https://groups.io/mt/86334480/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg
Posted by Abner Chang 2 years, 6 months ago
Merged.
The fastest review process I ever experienced. :-D

Thanks
Abner


________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Leif Lindholm <leif@nuviainc.com>
Sent: Friday, October 15, 2021 6:54 PM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Schaefer, Daniel <daniel.schaefer@hpe.com>; Thomas Abraham <thomas.abraham@arm.com>; Sami Mujawar <sami.mujawar@arm.com>; Graeme Gregory <graeme@nuviainc.com>; Radoslaw Biernacki <rad@semihalf.com>; Pierre Gondois <pierre.gondois@arm.com>; Peng Xie <xiepeng@phytium.com.cn>; Ling Jia <jialing@phytium.com.cn>; Yiqi Shu <shuyiqi@phytium.com.cn>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V3 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg

On Fri, Oct 15, 2021 at 15:32:56 +0800, Abner Chang wrote:
> In V3: Fix the commit message in each patch.
>        ArmVirtPkg->ArmPkg
> In V2: Fix the invalid email address.

Less haste, more speed ;)

Acked-by: Leif Lindholm <leif@nuviainc.com>

> This patch set fixes the build error caused by referring to
> PcdPciMmio(32)64Translation under ArmPkg. It should use the ones from
> MdePkg because of the PCD relocation (BZ:#3665).
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=3665
>
> BZ:#3665 is to migrate some modules from ArmVirtPkg
> to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage
> those modules without the dependency with Arm*Pkg.
> Refer to below message of the pacthes of edk2 portion.
> https://edk2.groups.io/g/devel/message/81306
>
> Below PCDs are moved to under MdePkg and leverage by RiscVVirtPkg.
> - PcdPciMmio32Translation
> - PcdPciMmio64Translation
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Peng Xie <xiepeng@phytium.com.cn>
> Cc: Ling Jia <jialing@phytium.com.cn>
> Cc: Yiqi Shu <shuyiqi@phytium.com.cn>
>
> Abner Chang (9):
>   Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from
>     MdePkg
>   Platform/CelloBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/Overdrive1000Board: Use PcdPciMmio(32)64Translation PCD from
>     MdePkg
>   Silicon/Styx: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/ARM: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Silicon/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Platform/DurianPkg: Use PcdPciMmio(32)64Translation PCD from MdePkg
>   Silicon/FT2000-4Pkg: Use PcdPciMmio(32)64Translation PCD from MdePkg
>
>  Platform/ARM/SgiPkg/SgiPlatform.dsc.inc                       | 4 ++--
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                | 4 ++--
>  Platform/LeMaker/CelloBoard/CelloBoard.dsc                    | 4 ++--
>  Platform/Phytium/DurianPkg/DurianPkg.dsc                      | 2 +-
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc                           | 4 ++--
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc   | 4 ++--
>  .../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf     | 4 ++--
>  .../ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf  | 2 +-
>  .../AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf       | 4 ++--
>  .../Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf   | 2 +-
>  Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf               | 4 ++--
>  .../SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c       | 4 ++--
>  12 files changed, 21 insertions(+), 21 deletions(-)
>
> --
> 2.17.1
>







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82134): https://edk2.groups.io/g/devel/message/82134
Mute This Topic: https://groups.io/mt/86334480/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-