[edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot

Guo Dong posted 1 patch 2 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20211015002735.1459-1-guo.dong@intel.com
There is a newer version of this series
UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot
Posted by Guo Dong 2 years, 6 months ago
From: Guo Dong <guo.dong@intel.com>

There is typo in previous change caused coreboot build failue.
This patch fixed the build issue.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
 UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
index f81aa0f301..4be5d66ba5 100644
--- a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
+++ b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
@@ -194,8 +194,8 @@ GetParameterBase (
     return NULL;
   }
 
-  PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
-  ASSERT_EFI_STATUS (Status);
+  Status = PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
+  ASSERT_EFI_ERROR (Status);
 
   return CbTablePtr;
 }
-- 
2.32.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82060): https://edk2.groups.io/g/devel/message/82060
Mute This Topic: https://groups.io/mt/86328739/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot
Posted by Ni, Ray 2 years, 6 months ago
Reviewed-by: Ray Ni <ray.ni@intel.com>

-----Original Message-----
From: Dong, Guo <guo.dong@intel.com> 
Sent: Friday, October 15, 2021 8:28 AM
To: devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot

From: Guo Dong <guo.dong@intel.com>

There is typo in previous change caused coreboot build failue.
This patch fixed the build issue.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
 UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
index f81aa0f301..4be5d66ba5 100644
--- a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
+++ b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
@@ -194,8 +194,8 @@ GetParameterBase (
     return NULL;

   }

 

-  PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);

-  ASSERT_EFI_STATUS (Status);

+  Status = PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);

+  ASSERT_EFI_ERROR (Status);

 

   return CbTablePtr;

 }

-- 
2.32.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82091): https://edk2.groups.io/g/devel/message/82091
Mute This Topic: https://groups.io/mt/86328739/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-