ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
As SMBIOS spec, bit-31 of maximum cache size 2 should be 1
for 64K granularity.
Signed-off-by: Ming Huang <huangming@linux.alibaba.com>
---
ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
index fb484086a4..4b409ff745 100644
--- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
+++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
@@ -219,7 +219,7 @@ ConfigureCacheArchitectureInformation (
CacheSize32 = CacheSize16;
} else if ((CacheSize64 / 64) < MAX_INT16) {
CacheSize16 = (1 << 15) | (CacheSize64 / 64);
- CacheSize32 = CacheSize16;
+ CacheSize32 = (1 << 31) | (CacheSize64 / 64);
} else {
if ((CacheSize64 / 1024) <= 2047) {
CacheSize32 = CacheSize64;
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81976): https://edk2.groups.io/g/devel/message/81976
Mute This Topic: https://groups.io/mt/86307250/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
+Rebecca On Thu, Oct 14, 2021 at 15:23:14 +0800, Ming Huang wrote: > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 > for 64K granularity. > > Signed-off-by: Ming Huang <huangming@linux.alibaba.com> > --- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > index fb484086a4..4b409ff745 100644 > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > @@ -219,7 +219,7 @@ ConfigureCacheArchitectureInformation ( > CacheSize32 = CacheSize16; > } else if ((CacheSize64 / 64) < MAX_INT16) { > CacheSize16 = (1 << 15) | (CacheSize64 / 64); > - CacheSize32 = CacheSize16; > + CacheSize32 = (1 << 31) | (CacheSize64 / 64); > } else { > if ((CacheSize64 / 1024) <= 2047) { > CacheSize32 = CacheSize64; > -- > 2.17.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82024): https://edk2.groups.io/g/devel/message/82024 Mute This Topic: https://groups.io/mt/86307250/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Rebecca Cran <rebecca@nuviainc.com> On 10/14/21 1:23 AM, Ming Huang wrote: > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 > for 64K granularity. > > Signed-off-by: Ming Huang <huangming@linux.alibaba.com> > --- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > index fb484086a4..4b409ff745 100644 > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > @@ -219,7 +219,7 @@ ConfigureCacheArchitectureInformation ( > CacheSize32 = CacheSize16; > } else if ((CacheSize64 / 64) < MAX_INT16) { > CacheSize16 = (1 << 15) | (CacheSize64 / 64); > - CacheSize32 = CacheSize16; > + CacheSize32 = (1 << 31) | (CacheSize64 / 64); > } else { > if ((CacheSize64 / 1024) <= 2047) { > CacheSize32 = CacheSize64; -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82029): https://edk2.groups.io/g/devel/message/82029 Mute This Topic: https://groups.io/mt/86307250/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Thu, Oct 14, 2021 at 06:05:59 -0600, Rebecca Cran wrote: > Reviewed-by: Rebecca Cran <rebecca@nuviainc.com> Acked-by: Leif Lindholm <leif@nuviainc.com> Merged as 7e43d3e08611. Thanks! / Leif > > On 10/14/21 1:23 AM, Ming Huang wrote: > > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 > > for 64K granularity. > > > > Signed-off-by: Ming Huang <huangming@linux.alibaba.com> > > --- > > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > > index fb484086a4..4b409ff745 100644 > > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > > @@ -219,7 +219,7 @@ ConfigureCacheArchitectureInformation ( > > CacheSize32 = CacheSize16; > > } else if ((CacheSize64 / 64) < MAX_INT16) { > > CacheSize16 = (1 << 15) | (CacheSize64 / 64); > > - CacheSize32 = CacheSize16; > > + CacheSize32 = (1 << 31) | (CacheSize64 / 64); > > } else { > > if ((CacheSize64 / 1024) <= 2047) { > > CacheSize32 = CacheSize64; -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82129): https://edk2.groups.io/g/devel/message/82129 Mute This Topic: https://groups.io/mt/86307250/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.