[edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute

Mark Kettenis posted 1 patch 1 week, 4 days ago
Failed in applying to current master (apply log)
Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute

Posted by Mark Kettenis 1 week, 4 days ago
The MMIO host bridge window isn't translated as both the primary
and secondary side are MMIO.  So remove the incorrect
TypeTranslation attribute.

Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
---
 Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
index ee37b7a21e..f485c6b5d2 100644
--- a/Platform/RaspberryPi/AcpiTables/Pci.asl
+++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
@@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
             1,                              // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN
             SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW
             2                               // SANITIZED_PCIE_MMIO_LEN + 1
-            ,,,MMI1,,TypeTranslation
+            ,,,MMI1
           )
 
           // root port registers, not to be used if SMCCC is utilized
-- 
2.33.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81734): https://edk2.groups.io/g/devel/message/81734
Mute This Topic: https://groups.io/mt/86221449/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute

Posted by Ard Biesheuvel 1 week, 4 days ago
On Sun, 10 Oct 2021 at 21:48, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>
> The MMIO host bridge window isn't translated as both the primary
> and secondary side are MMIO.  So remove the incorrect
> TypeTranslation attribute.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Pushed as bbb431a0c658..ab6fcc28fd99

Thanks,

> ---
>  Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
> index ee37b7a21e..f485c6b5d2 100644
> --- a/Platform/RaspberryPi/AcpiTables/Pci.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
> @@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
>              1,                              // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN
>              SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW
>              2                               // SANITIZED_PCIE_MMIO_LEN + 1
> -            ,,,MMI1,,TypeTranslation
> +            ,,,MMI1
>            )
>
>            // root port registers, not to be used if SMCCC is utilized
> --
> 2.33.0
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#81734): https://edk2.groups.io/g/devel/message/81734
> Mute This Topic: https://groups.io/mt/86221449/1131722
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org]
> ------------
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81736): https://edk2.groups.io/g/devel/message/81736
Mute This Topic: https://groups.io/mt/86221449/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute

Posted by Jeremy Linton 1 week ago
Hi,

On 10/10/21 4:10 PM, Ard Biesheuvel wrote:
> On Sun, 10 Oct 2021 at 21:48, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>>
>> The MMIO host bridge window isn't translated as both the primary
>> and secondary side are MMIO.  So remove the incorrect
>> TypeTranslation attribute.
>>
>> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> 
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> 
> Pushed as bbb431a0c658..ab6fcc28fd99
> 
> Thanks,
> 
>> ---
>>   Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
>> index ee37b7a21e..f485c6b5d2 100644
>> --- a/Platform/RaspberryPi/AcpiTables/Pci.asl
>> +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
>> @@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
>>               1,                              // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN
>>               SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW
>>               2                               // SANITIZED_PCIE_MMIO_LEN + 1
>> -            ,,,MMI1,,TypeTranslation
>> +            ,,,MMI1
>>             )

Its a bit late, but this looks fine.

THanks!

>>
>>             // root port registers, not to be used if SMCCC is utilized
>> --
>> 2.33.0
>>
>>
>>
>> ------------
>> Groups.io Links: You receive all messages sent to this group.
>> View/Reply Online (#81734): https://edk2.groups.io/g/devel/message/81734
>> Mute This Topic: https://groups.io/mt/86221449/1131722
>> Group Owner: devel+owner@edk2.groups.io
>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org]
>> ------------
>>
>>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#82053): https://edk2.groups.io/g/devel/message/82053
Mute This Topic: https://groups.io/mt/86221449/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute

Posted by Mark Kettenis 1 week, 4 days ago
Sorry. Used an old mail address for ardb.  Can resend this if necessary.

> From: Mark Kettenis <kettenis@openbsd.org>
> Date: Sun, 10 Oct 2021 21:48:14 +0200
> 
> The MMIO host bridge window isn't translated as both the primary
> and secondary side are MMIO.  So remove the incorrect
> TypeTranslation attribute.
> 
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
>  Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
> index ee37b7a21e..f485c6b5d2 100644
> --- a/Platform/RaspberryPi/AcpiTables/Pci.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
> @@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
>              1,                              // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN
>              SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW
>              2                               // SANITIZED_PCIE_MMIO_LEN + 1
> -            ,,,MMI1,,TypeTranslation
> +            ,,,MMI1
>            )
>  
>            // root port registers, not to be used if SMCCC is utilized
> -- 
> 2.33.0
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81735): https://edk2.groups.io/g/devel/message/81735
Mute This Topic: https://groups.io/mt/86221449/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-