Hi Pierre,
Thank you for this patch. These changes look good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 07/10/2021 04:31 PM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> Some includes are not necessary. Remove then.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>
> Notes:
> v2:
> - New patch. [Pierre]
>
> .../Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c | 2 --
> .../Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c | 3 ---
> .../Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c | 1 -
> 3 files changed, 6 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
> index 19b7b128a08d..b46ad25cdd26 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCmn600LibArm/SsdtCmn600Generator.c
> @@ -10,13 +10,11 @@
> - Generic ACPI for Arm Components 1.0 Platform Design Document
> **/
>
> -#include <IndustryStandard/DebugPort2Table.h>
> #include <Library/AcpiLib.h>
> #include <Library/BaseLib.h>
> #include <Library/BaseMemoryLib.h>
> #include <Library/DebugLib.h>
> #include <Library/MemoryAllocationLib.h>
> -#include <Library/UefiBootServicesTableLib.h>
> #include <Protocol/AcpiTable.h>
>
> // Module specific include files.
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c
> index 1b70fe1db1d7..d62aee1056ad 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtSerialPortLibArm/SsdtSerialPortGenerator.c
> @@ -6,13 +6,11 @@
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
>
> -#include <IndustryStandard/DebugPort2Table.h>
> #include <Library/AcpiLib.h>
> #include <Library/BaseLib.h>
> #include <Library/BaseMemoryLib.h>
> #include <Library/DebugLib.h>
> #include <Library/MemoryAllocationLib.h>
> -#include <Library/UefiBootServicesTableLib.h>
> #include <Protocol/AcpiTable.h>
>
> // Module specific include files.
> @@ -20,7 +18,6 @@
> #include <ConfigurationManagerObject.h>
> #include <ConfigurationManagerHelper.h>
> #include <Library/AcpiHelperLib.h>
> -#include <Library/AmlLib/AmlLib.h>
> #include <Library/SsdtSerialPortFixupLib.h>
> #include <Protocol/ConfigurationManagerProtocol.h>
>
> diff --git a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
> index 6966410b2c34..79e1fabc9223 100644
> --- a/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
> +++ b/DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFixupLib.c
> @@ -16,7 +16,6 @@
> #include <Library/BaseMemoryLib.h>
> #include <Library/DebugLib.h>
> #include <Library/MemoryAllocationLib.h>
> -#include <Library/UefiBootServicesTableLib.h>
> #include <Protocol/AcpiTable.h>
>
> // Module specific include files.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81673): https://edk2.groups.io/g/devel/message/81673
Mute This Topic: https://groups.io/mt/86148192/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-