Set default Makefile name

[edk2-devel] [PATCH v1 0/4] Set default Makefile name

Posted by PierreGondois 2 years, 7 months ago

From: Pierre Gondois <Pierre.Gondois@arm.com>

A Makefile name is not set in BaseTools when only building modules
or libraries. This patch-set sets a default Makefile name for the
"build" command.

The patch-set also:
- Removes unsused Makefile variables
- Removes hard-coded references to "target.txt" and "tools_def.txt"

The changes can be seen at: https://github.com/PierreARM/edk2/tree/1868_BaseTools_build_py_corrections_v1

Pierre Gondois (4):
  BaseTools/GenMake: Use ToolDefinition as fallback option
  BaseTools/build: Set MakefileName
  BaseTools: Remove Makefile/MakefileName fields
  BaseTools: Remove hard-coded strings for target and tools_def

 BaseTools/Source/Python/AutoGen/GenMake.py            |  8 ++++----
 BaseTools/Source/Python/AutoGen/ModuleAutoGen.py      |  1 -
 BaseTools/Source/Python/GenFds/GenFds.py              |  4 ++--
 .../Source/Python/GenFds/GenFdsGlobalVariable.py      |  4 ++--
 BaseTools/Source/Python/TargetTool/TargetTool.py      |  3 ++-
 BaseTools/Source/Python/Workspace/BuildClassObject.py |  2 --
 BaseTools/Source/Python/Workspace/DscBuildData.py     |  9 ++++-----
 BaseTools/Source/Python/build/build.py                | 11 ++++-------
 8 files changed, 18 insertions(+), 24 deletions(-)

-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81020): https://edk2.groups.io/g/devel/message/81020
Mute This Topic: https://groups.io/mt/85809767/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/4] Set default Makefile name

Posted by Chris Jones 2 years, 7 months ago

For this patch series:

Reviewed-by: Chris Jones <christopher.jones@arm.com>


Regards,
Chris
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of PierreGondois via groups.io <pierre.gondois=arm.com@groups.io>
Sent: Thursday, September 23, 2021 9:58 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Bob Feng <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Sami Mujawar <Sami.Mujawar@arm.com>
Subject: [edk2-devel] [PATCH v1 0/4] Set default Makefile name

From: Pierre Gondois <Pierre.Gondois@arm.com>

A Makefile name is not set in BaseTools when only building modules
or libraries. This patch-set sets a default Makefile name for the
"build" command.

The patch-set also:
- Removes unsused Makefile variables
- Removes hard-coded references to "target.txt" and "tools_def.txt"

The changes can be seen at: https://github.com/PierreARM/edk2/tree/1868_BaseTools_build_py_corrections_v1

Pierre Gondois (4):
  BaseTools/GenMake: Use ToolDefinition as fallback option
  BaseTools/build: Set MakefileName
  BaseTools: Remove Makefile/MakefileName fields
  BaseTools: Remove hard-coded strings for target and tools_def

 BaseTools/Source/Python/AutoGen/GenMake.py            |  8 ++++----
 BaseTools/Source/Python/AutoGen/ModuleAutoGen.py      |  1 -
 BaseTools/Source/Python/GenFds/GenFds.py              |  4 ++--
 .../Source/Python/GenFds/GenFdsGlobalVariable.py      |  4 ++--
 BaseTools/Source/Python/TargetTool/TargetTool.py      |  3 ++-
 BaseTools/Source/Python/Workspace/BuildClassObject.py |  2 --
 BaseTools/Source/Python/Workspace/DscBuildData.py     |  9 ++++-----
 BaseTools/Source/Python/build/build.py                | 11 ++++-------
 8 files changed, 18 insertions(+), 24 deletions(-)

--
2.17.1






IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81025): https://edk2.groups.io/g/devel/message/81025
Mute This Topic: https://groups.io/mt/85809767/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/4] Set default Makefile name

Posted by Bob Feng 2 years, 7 months ago

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com> 
Sent: Thursday, September 23, 2021 4:59 PM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Sami Mujawar <sami.mujawar@arm.com>
Subject: [PATCH v1 0/4] Set default Makefile name

From: Pierre Gondois <Pierre.Gondois@arm.com>

A Makefile name is not set in BaseTools when only building modules or libraries. This patch-set sets a default Makefile name for the "build" command.

The patch-set also:
- Removes unsused Makefile variables
- Removes hard-coded references to "target.txt" and "tools_def.txt"

The changes can be seen at: https://github.com/PierreARM/edk2/tree/1868_BaseTools_build_py_corrections_v1

Pierre Gondois (4):
  BaseTools/GenMake: Use ToolDefinition as fallback option
  BaseTools/build: Set MakefileName
  BaseTools: Remove Makefile/MakefileName fields
  BaseTools: Remove hard-coded strings for target and tools_def

 BaseTools/Source/Python/AutoGen/GenMake.py            |  8 ++++----
 BaseTools/Source/Python/AutoGen/ModuleAutoGen.py      |  1 -
 BaseTools/Source/Python/GenFds/GenFds.py              |  4 ++--
 .../Source/Python/GenFds/GenFdsGlobalVariable.py      |  4 ++--
 BaseTools/Source/Python/TargetTool/TargetTool.py      |  3 ++-
 BaseTools/Source/Python/Workspace/BuildClassObject.py |  2 --
 BaseTools/Source/Python/Workspace/DscBuildData.py     |  9 ++++-----
 BaseTools/Source/Python/build/build.py                | 11 ++++-------
 8 files changed, 18 insertions(+), 24 deletions(-)

--
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81278): https://edk2.groups.io/g/devel/message/81278
Mute This Topic: https://groups.io/mt/85809767/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v1 0/4] Set default Makefile name

Posted by gaoliming 2 years, 7 months ago

Pierre:
  Can you submit BZ for this change request? 

Thanks
Liming
> -----邮件原件-----
> 发件人: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> 发送时间: 2021年9月23日 16:59
> 收件人: devel@edk2.groups.io; Bob Feng <bob.c.feng@intel.com>; Liming
> Gao <gaoliming@byosoft.com.cn>; Sami Mujawar <sami.mujawar@arm.com>
> 主题: [PATCH v1 0/4] Set default Makefile name
> 
> From: Pierre Gondois <Pierre.Gondois@arm.com>
> 
> A Makefile name is not set in BaseTools when only building modules
> or libraries. This patch-set sets a default Makefile name for the
> "build" command.
> 
> The patch-set also:
> - Removes unsused Makefile variables
> - Removes hard-coded references to "target.txt" and "tools_def.txt"
> 
> The changes can be seen at:
> https://github.com/PierreARM/edk2/tree/1868_BaseTools_build_py_correcti
> ons_v1
> 
> Pierre Gondois (4):
>   BaseTools/GenMake: Use ToolDefinition as fallback option
>   BaseTools/build: Set MakefileName
>   BaseTools: Remove Makefile/MakefileName fields
>   BaseTools: Remove hard-coded strings for target and tools_def
> 
>  BaseTools/Source/Python/AutoGen/GenMake.py            |  8
> ++++----
>  BaseTools/Source/Python/AutoGen/ModuleAutoGen.py      |  1 -
>  BaseTools/Source/Python/GenFds/GenFds.py              |  4 ++--
>  .../Source/Python/GenFds/GenFdsGlobalVariable.py      |  4 ++--
>  BaseTools/Source/Python/TargetTool/TargetTool.py      |  3 ++-
>  BaseTools/Source/Python/Workspace/BuildClassObject.py |  2 --
>  BaseTools/Source/Python/Workspace/DscBuildData.py     |  9 ++++-----
>  BaseTools/Source/Python/build/build.py                | 11 ++++-------
>  8 files changed, 18 insertions(+), 24 deletions(-)
> 
> --
> 2.17.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81055): https://edk2.groups.io/g/devel/message/81055
Mute This Topic: https://groups.io/mt/85829206/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: [PATCH v1 0/4] Set default Makefile name

Posted by PierreGondois 2 years, 7 months ago

Hi Liming,

I created: https://bugzilla.tianocore.org/show_bug.cgi?id=3653

Regards,

Pierre

On 9/24/21 1:48 AM, gaoliming wrote:
> Pierre:
>   Can you submit BZ for this change request? 
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
>> 发送时间: 2021年9月23日 16:59
>> 收件人: devel@edk2.groups.io; Bob Feng <bob.c.feng@intel.com>; Liming
>> Gao <gaoliming@byosoft.com.cn>; Sami Mujawar <sami.mujawar@arm.com>
>> 主题: [PATCH v1 0/4] Set default Makefile name
>>
>> From: Pierre Gondois <Pierre.Gondois@arm.com>
>>
>> A Makefile name is not set in BaseTools when only building modules
>> or libraries. This patch-set sets a default Makefile name for the
>> "build" command.
>>
>> The patch-set also:
>> - Removes unsused Makefile variables
>> - Removes hard-coded references to "target.txt" and "tools_def.txt"
>>
>> The changes can be seen at:
>> https://github.com/PierreARM/edk2/tree/1868_BaseTools_build_py_correcti
>> ons_v1
>>
>> Pierre Gondois (4):
>>   BaseTools/GenMake: Use ToolDefinition as fallback option
>>   BaseTools/build: Set MakefileName
>>   BaseTools: Remove Makefile/MakefileName fields
>>   BaseTools: Remove hard-coded strings for target and tools_def
>>
>>  BaseTools/Source/Python/AutoGen/GenMake.py            |  8
>> ++++----
>>  BaseTools/Source/Python/AutoGen/ModuleAutoGen.py      |  1 -
>>  BaseTools/Source/Python/GenFds/GenFds.py              |  4 ++--
>>  .../Source/Python/GenFds/GenFdsGlobalVariable.py      |  4 ++--
>>  BaseTools/Source/Python/TargetTool/TargetTool.py      |  3 ++-
>>  BaseTools/Source/Python/Workspace/BuildClassObject.py |  2 --
>>  BaseTools/Source/Python/Workspace/DscBuildData.py     |  9 ++++-----
>>  BaseTools/Source/Python/build/build.py                | 11 ++++-------
>>  8 files changed, 18 insertions(+), 24 deletions(-)
>>
>> --
>> 2.17.1
>
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81094): https://edk2.groups.io/g/devel/message/81094
Mute This Topic: https://groups.io/mt/85829206/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] 回复: [PATCH v1 0/4] Set default Makefile name

Posted by gaoliming 2 years, 7 months ago

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表
> PierreGondois
> 发送时间: 2021年9月24日 19:57
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 'Bob
> Feng' <bob.c.feng@intel.com>; 'Sami Mujawar' <sami.mujawar@arm.com>
> 抄送: 'Christopher Jones' <Christopher.Jones@arm.com>
> 主题: Re: [edk2-devel] 回复: [PATCH v1 0/4] Set default Makefile name
> 
> Hi Liming,
> 
> I created: https://bugzilla.tianocore.org/show_bug.cgi?id=3653
> 
> Regards,
> 
> Pierre
> 
> On 9/24/21 1:48 AM, gaoliming wrote:
> > Pierre:
> >   Can you submit BZ for this change request?
> >
> > Thanks
> > Liming
> >> -----邮件原件-----
> >> 发件人: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> >> 发送时间: 2021年9月23日 16:59
> >> 收件人: devel@edk2.groups.io; Bob Feng <bob.c.feng@intel.com>;
> Liming
> >> Gao <gaoliming@byosoft.com.cn>; Sami Mujawar
> <sami.mujawar@arm.com>
> >> 主题: [PATCH v1 0/4] Set default Makefile name
> >>
> >> From: Pierre Gondois <Pierre.Gondois@arm.com>
> >>
> >> A Makefile name is not set in BaseTools when only building modules
> >> or libraries. This patch-set sets a default Makefile name for the
> >> "build" command.
> >>
> >> The patch-set also:
> >> - Removes unsused Makefile variables
> >> - Removes hard-coded references to "target.txt" and "tools_def.txt"
> >>
> >> The changes can be seen at:
> >>
> https://github.com/PierreARM/edk2/tree/1868_BaseTools_build_py_correcti
> >> ons_v1
> >>
> >> Pierre Gondois (4):
> >>   BaseTools/GenMake: Use ToolDefinition as fallback option
> >>   BaseTools/build: Set MakefileName
> >>   BaseTools: Remove Makefile/MakefileName fields
> >>   BaseTools: Remove hard-coded strings for target and tools_def
> >>
> >>  BaseTools/Source/Python/AutoGen/GenMake.py            |  8
> >> ++++----
> >>  BaseTools/Source/Python/AutoGen/ModuleAutoGen.py      |  1 -
> >>  BaseTools/Source/Python/GenFds/GenFds.py              |  4 ++--
> >>  .../Source/Python/GenFds/GenFdsGlobalVariable.py      |  4 ++--
> >>  BaseTools/Source/Python/TargetTool/TargetTool.py      |  3 ++-
> >>  BaseTools/Source/Python/Workspace/BuildClassObject.py |  2 --
> >>  BaseTools/Source/Python/Workspace/DscBuildData.py     |  9
> ++++-----
> >>  BaseTools/Source/Python/build/build.py                | 11
> ++++-------
> >>  8 files changed, 18 insertions(+), 24 deletions(-)
> >>
> >> --
> >> 2.17.1
> >
> >
> >
> >
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81258): https://edk2.groups.io/g/devel/message/81258
Mute This Topic: https://groups.io/mt/85939699/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-