[edk2-devel] [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment

Nate DeSimone posted 1 patch 2 years, 8 months ago
Failed in applying to current master (apply log)
.../TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc      | 1 -
1 file changed, 1 deletion(-)
[edk2-devel] [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment
Posted by Nate DeSimone 2 years, 8 months ago
A comment in OpenBoardPkgPcd.dsc states that FSP
dispatch mode is not supported, which is inaccurate.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc      | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
index a048efcc18..ebbbc7b9f9 100644
--- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
@@ -30,7 +30,6 @@
   #
   # 0: FSP Wrapper is running in Dispatch mode.
   # 1: FSP Wrapper is running in API mode.
-  # Note: Dispatch mode is currently NOT supported for this board.
   #
   gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0
 
-- 
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79920): https://edk2.groups.io/g/devel/message/79920
Mute This Topic: https://groups.io/mt/85220695/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment
Posted by Chaganty, Rangasai V 2 years, 8 months ago
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Saturday, August 28, 2021 6:19 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Luo, Heng <heng.luo@intel.com>
Subject: [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment

A comment in OpenBoardPkgPcd.dsc states that FSP dispatch mode is not supported, which is inaccurate.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc      | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
index a048efcc18..ebbbc7b9f9 100644
--- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd
+++ .dsc
@@ -30,7 +30,6 @@
   #
   # 0: FSP Wrapper is running in Dispatch mode.
   # 1: FSP Wrapper is running in API mode.
-  # Note: Dispatch mode is currently NOT supported for this board.
   #
   gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0
 
--
2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79924): https://edk2.groups.io/g/devel/message/79924
Mute This Topic: https://groups.io/mt/85220695/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment
Posted by Heng Luo 2 years, 8 months ago
Reviewed-by: Heng Luo <heng.luo@intel.com>

> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Sunday, August 29, 2021 9:19 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Luo, Heng
> <heng.luo@intel.com>
> Subject: [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove
> inaccurate comment
> 
> A comment in OpenBoardPkgPcd.dsc states that FSP dispatch mode is not
> supported, which is inaccurate.
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc      | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> index a048efcc18..ebbbc7b9f9 100644
> ---
> a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> +++
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd
> +++ .dsc
> @@ -30,7 +30,6 @@
>    #
>    # 0: FSP Wrapper is running in Dispatch mode.
>    # 1: FSP Wrapper is running in API mode.
> -  # Note: Dispatch mode is currently NOT supported for this board.
>    #
>    gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0
> 
> --
> 2.27.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79925): https://edk2.groups.io/g/devel/message/79925
Mute This Topic: https://groups.io/mt/85220695/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-