[v3] Fix OvmfXen boot failure due to s3 support state

[edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state

Posted by Lin, Gary (HPS OE-Linux) 2 years, 8 months ago

When using HVM Direct kernel boot with OvmfXen, it could fail at the
S3BootScript due to the inconsistency between QemuFwCfgS3Enabled()
and PcdAcpiS3Enable.

This patch series initializes PcdAcpiS3Enable in 
. Besides, QemuFwCfgS3Enabled() is
replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the
potential inconsistency.

Bugzilla links:
  https://bugzilla.tianocore.org/show_bug.cgi?id=3573

v3:
  - Update the description per Anthony's suggestion
  - Add the bugzilla links
  - Move the QemuKernelLoaderFsDxe patch out of this patch series
    and make it an independent patch
v2:
  - Amend the description and address "HVM Direct Kernel Boot"
  - Add the comment for the conditional test of QemuFwCfgS3Enabled()
  - Remove unused QemuFwCfgLib
  - Update my email address

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Julien Grall <julien@xen.org>
Cc: Jim Fehlig <jfehlig@suse.com>
Cc: Joey Li <jlee@suse.com>

Gary Lin (4):
  OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
  OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support
  OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3
    support
  OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support

 OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf        |  3 +--
 .../PlatformBootManagerLib.inf                      |  1 +
 OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf           |  2 ++
 OvmfPkg/XenPlatformPei/XenPlatformPei.inf           |  2 ++
 OvmfPkg/Library/LockBoxLib/LockBoxDxe.c             |  4 +---
 .../Library/PlatformBootManagerLib/BdsPlatform.c    |  2 +-
 OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c             |  4 +---
 OvmfPkg/XenPlatformPei/Platform.c                   | 13 +++++++++++++
 8 files changed, 22 insertions(+), 9 deletions(-)

-- 
2.31.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79707): https://edk2.groups.io/g/devel/message/79707
Mute This Topic: https://groups.io/mt/85080300/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state

Posted by Yao, Jiewen 2 years, 8 months ago

Series reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Lin, Gary
> (HPS OE-Linux)
> Sent: Monday, August 23, 2021 3:09 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Anthony Perard <anthony.perard@citrix.com>; Julien Grall <julien@xen.org>;
> Jim Fehlig <jfehlig@suse.com>; Joey Li <jlee@suse.com>
> Subject: [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support
> state
> 
> When using HVM Direct kernel boot with OvmfXen, it could fail at the
> S3BootScript due to the inconsistency between QemuFwCfgS3Enabled()
> and PcdAcpiS3Enable.
> 
> This patch series initializes PcdAcpiS3Enable in
> . Besides, QemuFwCfgS3Enabled() is
> replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the
> potential inconsistency.
> 
> Bugzilla links:
>   https://bugzilla.tianocore.org/show_bug.cgi?id=3573
> 
> v3:
>   - Update the description per Anthony's suggestion
>   - Add the bugzilla links
>   - Move the QemuKernelLoaderFsDxe patch out of this patch series
>     and make it an independent patch
> v2:
>   - Amend the description and address "HVM Direct Kernel Boot"
>   - Add the comment for the conditional test of QemuFwCfgS3Enabled()
>   - Remove unused QemuFwCfgLib
>   - Update my email address
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Jim Fehlig <jfehlig@suse.com>
> Cc: Joey Li <jlee@suse.com>
> 
> Gary Lin (4):
>   OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
>   OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support
>   OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3
>     support
>   OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support
> 
>  OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf        |  3 +--
>  .../PlatformBootManagerLib.inf                      |  1 +
>  OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf           |  2 ++
>  OvmfPkg/XenPlatformPei/XenPlatformPei.inf           |  2 ++
>  OvmfPkg/Library/LockBoxLib/LockBoxDxe.c             |  4 +---
>  .../Library/PlatformBootManagerLib/BdsPlatform.c    |  2 +-
>  OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c             |  4 +---
>  OvmfPkg/XenPlatformPei/Platform.c                   | 13 +++++++++++++
>  8 files changed, 22 insertions(+), 9 deletions(-)
> 
> --
> 2.31.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79718): https://edk2.groups.io/g/devel/message/79718
Mute This Topic: https://groups.io/mt/85080300/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state

Posted by Jim Fehlig via groups.io 2 years, 8 months ago

On 8/23/21 1:09 AM, Gary Lin wrote:
> When using HVM Direct kernel boot with OvmfXen, it could fail at the
> S3BootScript due to the inconsistency between QemuFwCfgS3Enabled()
> and PcdAcpiS3Enable.
> 
> This patch series initializes PcdAcpiS3Enable in
> . Besides, QemuFwCfgS3Enabled() is
> replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the
> potential inconsistency.
> 
> Bugzilla links:
>    https://bugzilla.tianocore.org/show_bug.cgi?id=3573
> 
> v3:
>    - Update the description per Anthony's suggestion
>    - Add the bugzilla links
>    - Move the QemuKernelLoaderFsDxe patch out of this patch series
>      and make it an independent patch
> v2:
>    - Amend the description and address "HVM Direct Kernel Boot"
>    - Add the comment for the conditional test of QemuFwCfgS3Enabled()
>    - Remove unused QemuFwCfgLib
>    - Update my email address
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Jim Fehlig <jfehlig@suse.com>
> Cc: Joey Li <jlee@suse.com>
> 
> Gary Lin (4):
>    OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
>    OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support
>    OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3
>      support
>    OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support
> 
>   OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf        |  3 +--
>   .../PlatformBootManagerLib.inf                      |  1 +
>   OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf           |  2 ++
>   OvmfPkg/XenPlatformPei/XenPlatformPei.inf           |  2 ++
>   OvmfPkg/Library/LockBoxLib/LockBoxDxe.c             |  4 +---
>   .../Library/PlatformBootManagerLib/BdsPlatform.c    |  2 +-
>   OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c             |  4 +---
>   OvmfPkg/XenPlatformPei/Platform.c                   | 13 +++++++++++++
>   8 files changed, 22 insertions(+), 9 deletions(-)

Tested-by: Jim Fehlig <jfehlig@suse.com>

Regards,
Jim



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79778): https://edk2.groups.io/g/devel/message/79778
Mute This Topic: https://groups.io/mt/85080300/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state

Posted by Ard Biesheuvel 2 years, 8 months ago

On Tue, 24 Aug 2021 at 19:21, Jim Fehlig <jfehlig@suse.com> wrote:
>
> On 8/23/21 1:09 AM, Gary Lin wrote:
> > When using HVM Direct kernel boot with OvmfXen, it could fail at the
> > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled()
> > and PcdAcpiS3Enable.
> >
> > This patch series initializes PcdAcpiS3Enable in
> > . Besides, QemuFwCfgS3Enabled() is
> > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the
> > potential inconsistency.
> >
> > Bugzilla links:
> >    https://bugzilla.tianocore.org/show_bug.cgi?id=3573
> >
> > v3:
> >    - Update the description per Anthony's suggestion
> >    - Add the bugzilla links
> >    - Move the QemuKernelLoaderFsDxe patch out of this patch series
> >      and make it an independent patch
> > v2:
> >    - Amend the description and address "HVM Direct Kernel Boot"
> >    - Add the comment for the conditional test of QemuFwCfgS3Enabled()
> >    - Remove unused QemuFwCfgLib
> >    - Update my email address
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: Julien Grall <julien@xen.org>
> > Cc: Jim Fehlig <jfehlig@suse.com>
> > Cc: Joey Li <jlee@suse.com>
> >
> > Gary Lin (4):
> >    OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
> >    OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support
> >    OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3
> >      support
> >    OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support
> >
> >   OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf        |  3 +--
> >   .../PlatformBootManagerLib.inf                      |  1 +
> >   OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf           |  2 ++
> >   OvmfPkg/XenPlatformPei/XenPlatformPei.inf           |  2 ++
> >   OvmfPkg/Library/LockBoxLib/LockBoxDxe.c             |  4 +---
> >   .../Library/PlatformBootManagerLib/BdsPlatform.c    |  2 +-
> >   OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c             |  4 +---
> >   OvmfPkg/XenPlatformPei/Platform.c                   | 13 +++++++++++++
> >   8 files changed, 22 insertions(+), 9 deletions(-)
>
> Tested-by: Jim Fehlig <jfehlig@suse.com>
>


Thanks for this series, and thanks all for the reviews.

Gary, could you please resend it with the following changes so it
applies cleanly:
- Move the bugzilla link into the signoff block, preceded by Ref:
- Remove v[23] etc version information from the patches, or move it
below the three dashes line so it does not end up in the commit log
- Incorporate all the review tags given in response to this v3
- Please find a way to send these patches that doesn't result in
mangled whitespace (hint: using Outlook/Exchange is probably not the
best choice)


Thanks,
Ard.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79894): https://edk2.groups.io/g/devel/message/79894
Mute This Topic: https://groups.io/mt/85080300/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/4] Fix OvmfXen boot failure due to s3 support state

Posted by Lin, Gary (HPS OE-Linux) 2 years, 8 months ago

On Fri, Aug 27, 2021 at 03:16:43PM +0200, Ard Biesheuvel wrote:
> On Tue, 24 Aug 2021 at 19:21, Jim Fehlig <jfehlig@suse.com> wrote:
> >
> > On 8/23/21 1:09 AM, Gary Lin wrote:
> > > When using HVM Direct kernel boot with OvmfXen, it could fail at the
> > > S3BootScript due to the inconsistency between QemuFwCfgS3Enabled()
> > > and PcdAcpiS3Enable.
> > >
> > > This patch series initializes PcdAcpiS3Enable in
> > > . Besides, QemuFwCfgS3Enabled() is
> > > replaced with PcdAcpiS3Enable in several OVMF libraries to avoid the
> > > potential inconsistency.
> > >
> > > Bugzilla links:
> > >    https://bugzilla.tianocore.org/show_bug.cgi?id=3573
> > >
> > > v3:
> > >    - Update the description per Anthony's suggestion
> > >    - Add the bugzilla links
> > >    - Move the QemuKernelLoaderFsDxe patch out of this patch series
> > >      and make it an independent patch
> > > v2:
> > >    - Amend the description and address "HVM Direct Kernel Boot"
> > >    - Add the comment for the conditional test of QemuFwCfgS3Enabled()
> > >    - Remove unused QemuFwCfgLib
> > >    - Update my email address
> > >
> > > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > > Cc: Anthony Perard <anthony.perard@citrix.com>
> > > Cc: Julien Grall <julien@xen.org>
> > > Cc: Jim Fehlig <jfehlig@suse.com>
> > > Cc: Joey Li <jlee@suse.com>
> > >
> > > Gary Lin (4):
> > >    OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization
> > >    OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support
> > >    OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3
> > >      support
> > >    OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support
> > >
> > >   OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf        |  3 +--
> > >   .../PlatformBootManagerLib.inf                      |  1 +
> > >   OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf           |  2 ++
> > >   OvmfPkg/XenPlatformPei/XenPlatformPei.inf           |  2 ++
> > >   OvmfPkg/Library/LockBoxLib/LockBoxDxe.c             |  4 +---
> > >   .../Library/PlatformBootManagerLib/BdsPlatform.c    |  2 +-
> > >   OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c             |  4 +---
> > >   OvmfPkg/XenPlatformPei/Platform.c                   | 13 +++++++++++++
> > >   8 files changed, 22 insertions(+), 9 deletions(-)
> >
> > Tested-by: Jim Fehlig <jfehlig@suse.com>
> >
> 
> 
> Thanks for this series, and thanks all for the reviews.
> 
> Gary, could you please resend it with the following changes so it
> applies cleanly:
> - Move the bugzilla link into the signoff block, preceded by Ref:
> - Remove v[23] etc version information from the patches, or move it
> below the three dashes line so it does not end up in the commit log
> - Incorporate all the review tags given in response to this v3
Will update the patches.

> - Please find a way to send these patches that doesn't result in
> mangled whitespace (hint: using Outlook/Exchange is probably not the
> best choice)
> 
Sorry for that. I forgot to set sendemail.transferEncoding to 8bit and
git chose quoted-printable automatically. I've updated my git config and
it should be fixed next time.

Thanks,

Gary Lin


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79935): https://edk2.groups.io/g/devel/message/79935
Mute This Topic: https://groups.io/mt/85080300/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-