1. Patchew
  2. EDK2
  3. [edk2-devel] [PATCH 0/2] Enable Core ci for UefiPayloadPkg.
  4. View patch

[edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py

duntan posted 2 patches 4 years, 5 months ago
[edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Posted by duntan 4 years, 5 months ago 
Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg.
Add UefiPayloadPkg to supported Packages in CISettings.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: DunTan <dun.tan@intel.com>
---
 .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
 .pytool/CISettings.py                           | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 207acc7631..d5b16c127f 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -48,6 +48,9 @@ jobs:
       TARGET_SECURITY:
         Build.Pkgs: 'SecurityPkg'
         Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_UEFIPAYLOAD:
+        Build.Pkgs: 'UefiPayloadPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
       TARGET_PLATFORMS:
         # For Platforms only check code. Leave it to Platform CI
         # to build them.
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 96e6baa519..ce330e2c73 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
                 "CryptoPkg",
                 "UnitTestFrameworkPkg",
                 "OvmfPkg",
-                "RedfishPkg"
+                "RedfishPkg",
+                "UefiPayloadPkg"
                 )
 
     def GetArchitecturesSupported(self):
-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79628): https://edk2.groups.io/g/devel/message/79628
Mute This Topic: https://groups.io/mt/85015726/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Posted by duntan 4 years, 5 months ago 
Hi all,
    Since the CI for UefiPayloadPkg is important to our develop progress, would you please speed up the review process? Thanks a lot!

Thanks,
Dun Tan
-----Original Message-----
From: Tan, Dun <dun.tan@intel.com> 
Sent: Friday, August 20, 2021 2:44 PM
To: devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Tan, Dun <dun.tan@intel.com>
Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py

Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg.
Add UefiPayloadPkg to supported Packages in CISettings.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: DunTan <dun.tan@intel.com>
---
 .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
 .pytool/CISettings.py                           | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 207acc7631..d5b16c127f 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -48,6 +48,9 @@ jobs:
       TARGET_SECURITY:
         Build.Pkgs: 'SecurityPkg'
         Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_UEFIPAYLOAD:
+        Build.Pkgs: 'UefiPayloadPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
       TARGET_PLATFORMS:
         # For Platforms only check code. Leave it to Platform CI
         # to build them.
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index 96e6baa519..ce330e2c73 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, UpdateSettingsManager, SetupSettingsManag
                 "CryptoPkg",
                 "UnitTestFrameworkPkg",
                 "OvmfPkg",
-                "RedfishPkg"
+                "RedfishPkg",
+                "UefiPayloadPkg"
                 )
 
     def GetArchitecturesSupported(self):
--
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79760): https://edk2.groups.io/g/devel/message/79760
Mute This Topic: https://groups.io/mt/85015726/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Posted by gaoliming 4 years, 5 months ago 
Dun:
  I don't see the issues to enable UefiPayloadPkg in CI. Have you created
the private PR to verify this change? 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> 发送时间: 2021年8月24日 17:24
> 收件人: devel@edk2.groups.io
> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> gate-build-job.yml and CISetting.py
> 
> Hi all,
>     Since the CI for UefiPayloadPkg is important to our develop progress,
> would you please speed up the review process? Thanks a lot!
> 
> Thanks,
> Dun Tan
> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Friday, August 20, 2021 2:44 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Tan, Dun <dun.tan@intel.com>
> Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> gate-build-job.yml and CISetting.py
> 
> Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for
> UefiPayloadPkg.
> Add UefiPayloadPkg to supported Packages in CISettings.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: DunTan <dun.tan@intel.com>
> ---
>  .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>  .pytool/CISettings.py                           | 3 ++-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> b/.azurepipelines/templates/pr-gate-build-job.yml
> index 207acc7631..d5b16c127f 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -48,6 +48,9 @@ jobs:
>        TARGET_SECURITY:
>          Build.Pkgs: 'SecurityPkg'
>          Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +      TARGET_UEFIPAYLOAD:
> +        Build.Pkgs: 'UefiPayloadPkg'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>        TARGET_PLATFORMS:
>          # For Platforms only check code. Leave it to Platform CI
>          # to build them.
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> 96e6baa519..ce330e2c73 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager,
> UpdateSettingsManager, SetupSettingsManag
>                  "CryptoPkg",
>                  "UnitTestFrameworkPkg",
>                  "OvmfPkg",
> -                "RedfishPkg"
> +                "RedfishPkg",
> +                "UefiPayloadPkg"
>                  )
> 
>      def GetArchitecturesSupported(self):
> --
> 2.31.1.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79937): https://edk2.groups.io/g/devel/message/79937
Mute This Topic: https://groups.io/mt/85243201/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Posted by duntan 4 years, 5 months ago 
Hi Liming,

Here is the link of the PR to verify the change in Tiano EDKII. It passed the CI by GCC and VS both.
https://github.com/tianocore/edk2/pull/1931

Thanks,
Dun
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Monday, August 30, 2021 11:26 AM
To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py

Dun:
  I don't see the issues to enable UefiPayloadPkg in CI. Have you created the private PR to verify this change? 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> 发送时间: 2021年8月24日 17:24
> 收件人: devel@edk2.groups.io
> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew 
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg 
> in gate-build-job.yml and CISetting.py
> 
> Hi all,
>     Since the CI for UefiPayloadPkg is important to our develop 
> progress, would you please speed up the review process? Thanks a lot!
> 
> Thanks,
> Dun Tan
> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Friday, August 20, 2021 2:44 PM
> To: devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew 
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; 
> Tan, Dun <dun.tan@intel.com>
> Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in 
> gate-build-job.yml and CISetting.py
> 
> Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for 
> UefiPayloadPkg.
> Add UefiPayloadPkg to supported Packages in CISettings.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: DunTan <dun.tan@intel.com>
> ---
>  .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>  .pytool/CISettings.py                           | 3 ++-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> b/.azurepipelines/templates/pr-gate-build-job.yml
> index 207acc7631..d5b16c127f 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -48,6 +48,9 @@ jobs:
>        TARGET_SECURITY:
>          Build.Pkgs: 'SecurityPkg'
>          Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +      TARGET_UEFIPAYLOAD:
> +        Build.Pkgs: 'UefiPayloadPkg'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>        TARGET_PLATFORMS:
>          # For Platforms only check code. Leave it to Platform CI
>          # to build them.
> diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> 96e6baa519..ce330e2c73 100644
> --- a/.pytool/CISettings.py
> +++ b/.pytool/CISettings.py
> @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, 
> UpdateSettingsManager, SetupSettingsManag
>                  "CryptoPkg",
>                  "UnitTestFrameworkPkg",
>                  "OvmfPkg",
> -                "RedfishPkg"
> +                "RedfishPkg",
> +                "UefiPayloadPkg"
>                  )
> 
>      def GetArchitecturesSupported(self):
> --
> 2.31.1.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79946): https://edk2.groups.io/g/devel/message/79946
Mute This Topic: https://groups.io/mt/85246319/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Posted by gaoliming 4 years, 5 months ago 
Dun:
  This PR also includes one additional commit to fix the build issue. Have you send the patch for it? 

  For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>. It will be merged after the build issue has been fixed. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Tan, Dun <dun.tan@intel.com>
> 发送时间: 2021年8月30日 16:31
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> gate-build-job.yml and CISetting.py
> 
> Hi Liming,
> 
> Here is the link of the PR to verify the change in Tiano EDKII. It passed the CI
> by GCC and VS both.
> https://github.com/tianocore/edk2/pull/1931
> 
> Thanks,
> Dun
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, August 30, 2021 11:26 AM
> To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> in gate-build-job.yml and CISetting.py
> 
> Dun:
>   I don't see the issues to enable UefiPayloadPkg in CI. Have you created the
> private PR to verify this change?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> > 发送时间: 2021年8月24日 17:24
> > 收件人: devel@edk2.groups.io
> > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> > in gate-build-job.yml and CISetting.py
> >
> > Hi all,
> >     Since the CI for UefiPayloadPkg is important to our develop
> > progress, would you please speed up the review process? Thanks a lot!
> >
> > Thanks,
> > Dun Tan
> > -----Original Message-----
> > From: Tan, Dun <dun.tan@intel.com>
> > Sent: Friday, August 20, 2021 2:44 PM
> > To: devel@edk2.groups.io
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Tan, Dun <dun.tan@intel.com>
> > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> > gate-build-job.yml and CISetting.py
> >
> > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for
> > UefiPayloadPkg.
> > Add UefiPayloadPkg to supported Packages in CISettings.
> >
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: DunTan <dun.tan@intel.com>
> > ---
> >  .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> >  .pytool/CISettings.py                           | 3 ++-
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 207acc7631..d5b16c127f 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -48,6 +48,9 @@ jobs:
> >        TARGET_SECURITY:
> >          Build.Pkgs: 'SecurityPkg'
> >          Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > +      TARGET_UEFIPAYLOAD:
> > +        Build.Pkgs: 'UefiPayloadPkg'
> > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >        TARGET_PLATFORMS:
> >          # For Platforms only check code. Leave it to Platform CI
> >          # to build them.
> > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> > 96e6baa519..ce330e2c73 100644
> > --- a/.pytool/CISettings.py
> > +++ b/.pytool/CISettings.py
> > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager,
> > UpdateSettingsManager, SetupSettingsManag
> >                  "CryptoPkg",
> >                  "UnitTestFrameworkPkg",
> >                  "OvmfPkg",
> > -                "RedfishPkg"
> > +                "RedfishPkg",
> > +                "UefiPayloadPkg"
> >                  )
> >
> >      def GetArchitecturesSupported(self):
> > --
> > 2.31.1.windows.1
> >
> >
> >
> > 
> >
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79962): https://edk2.groups.io/g/devel/message/79962
Mute This Topic: https://groups.io/mt/85266573/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Posted by duntan 4 years, 5 months ago 
Hi Liming,

The patch to fix the build issue has been merged this morning. 
Would you please help to merge the two patches to enable core CI for UefiPayloadPkg? 

Thanks,
Dun
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Tuesday, August 31, 2021 9:05 AM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py

Dun:
  This PR also includes one additional commit to fix the build issue. Have you send the patch for it? 

  For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>. It will be merged after the build issue has been fixed. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Tan, Dun <dun.tan@intel.com>
> 发送时间: 2021年8月30日 16:31
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg 
> in gate-build-job.yml and CISetting.py
> 
> Hi Liming,
> 
> Here is the link of the PR to verify the change in Tiano EDKII. It 
> passed the CI by GCC and VS both.
> https://github.com/tianocore/edk2/pull/1931
> 
> Thanks,
> Dun
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, August 30, 2021 11:26 AM
> To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add 
> UefiPayloadPkg in gate-build-job.yml and CISetting.py
> 
> Dun:
>   I don't see the issues to enable UefiPayloadPkg in CI. Have you 
> created the private PR to verify this change?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> > 发送时间: 2021年8月24日 17:24
> > 收件人: devel@edk2.groups.io
> > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew 
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg 
> > in gate-build-job.yml and CISetting.py
> >
> > Hi all,
> >     Since the CI for UefiPayloadPkg is important to our develop 
> > progress, would you please speed up the review process? Thanks a lot!
> >
> > Thanks,
> > Dun Tan
> > -----Original Message-----
> > From: Tan, Dun <dun.tan@intel.com>
> > Sent: Friday, August 20, 2021 2:44 PM
> > To: devel@edk2.groups.io
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew 
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; 
> > Tan, Dun <dun.tan@intel.com>
> > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in 
> > gate-build-job.yml and CISetting.py
> >
> > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for 
> > UefiPayloadPkg.
> > Add UefiPayloadPkg to supported Packages in CISettings.
> >
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: DunTan <dun.tan@intel.com>
> > ---
> >  .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> >  .pytool/CISettings.py                           | 3 ++-
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 207acc7631..d5b16c127f 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -48,6 +48,9 @@ jobs:
> >        TARGET_SECURITY:
> >          Build.Pkgs: 'SecurityPkg'
> >          Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > +      TARGET_UEFIPAYLOAD:
> > +        Build.Pkgs: 'UefiPayloadPkg'
> > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >        TARGET_PLATFORMS:
> >          # For Platforms only check code. Leave it to Platform CI
> >          # to build them.
> > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> > 96e6baa519..ce330e2c73 100644
> > --- a/.pytool/CISettings.py
> > +++ b/.pytool/CISettings.py
> > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, 
> > UpdateSettingsManager, SetupSettingsManag
> >                  "CryptoPkg",
> >                  "UnitTestFrameworkPkg",
> >                  "OvmfPkg",
> > -                "RedfishPkg"
> > +                "RedfishPkg",
> > +                "UefiPayloadPkg"
> >                  )
> >
> >      def GetArchitecturesSupported(self):
> > --
> > 2.31.1.windows.1
> >
> >
> >
> > 
> >
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80044): https://edk2.groups.io/g/devel/message/80044
Mute This Topic: https://groups.io/mt/85293834/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Posted by duntan 4 years, 5 months ago 
Hi Liming,

I have seen the link to push my commits to master of edk2. The result shows that the Ci test failed in ArmPlatformPkg. But I think my commits will not affect the ArmPlatformPkg. Here is the link.
https://github.com/tianocore/edk2/pull/1940the 
So is there anything I need to do?

Thanks,
Dun
-----Original Message-----
From: Tan, Dun 
Sent: Wednesday, September 1, 2021 11:32 AM
To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py

Hi Liming,

The patch to fix the build issue has been merged this morning. 
Would you please help to merge the two patches to enable core CI for UefiPayloadPkg? 

Thanks,
Dun
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Tuesday, August 31, 2021 9:05 AM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py

Dun:
  This PR also includes one additional commit to fix the build issue. Have you send the patch for it? 

  For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>. It will be merged after the build issue has been fixed. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Tan, Dun <dun.tan@intel.com>
> 发送时间: 2021年8月30日 16:31
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg 
> in gate-build-job.yml and CISetting.py
> 
> Hi Liming,
> 
> Here is the link of the PR to verify the change in Tiano EDKII. It 
> passed the CI by GCC and VS both.
> https://github.com/tianocore/edk2/pull/1931
> 
> Thanks,
> Dun
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, August 30, 2021 11:26 AM
> To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add 
> UefiPayloadPkg in gate-build-job.yml and CISetting.py
> 
> Dun:
>   I don't see the issues to enable UefiPayloadPkg in CI. Have you 
> created the private PR to verify this change?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> > 发送时间: 2021年8月24日 17:24
> > 收件人: devel@edk2.groups.io
> > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew 
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg 
> > in gate-build-job.yml and CISetting.py
> >
> > Hi all,
> >     Since the CI for UefiPayloadPkg is important to our develop 
> > progress, would you please speed up the review process? Thanks a lot!
> >
> > Thanks,
> > Dun Tan
> > -----Original Message-----
> > From: Tan, Dun <dun.tan@intel.com>
> > Sent: Friday, August 20, 2021 2:44 PM
> > To: devel@edk2.groups.io
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew 
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; 
> > Tan, Dun <dun.tan@intel.com>
> > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in 
> > gate-build-job.yml and CISetting.py
> >
> > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for 
> > UefiPayloadPkg.
> > Add UefiPayloadPkg to supported Packages in CISettings.
> >
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: DunTan <dun.tan@intel.com>
> > ---
> >  .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> >  .pytool/CISettings.py                           | 3 ++-
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 207acc7631..d5b16c127f 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -48,6 +48,9 @@ jobs:
> >        TARGET_SECURITY:
> >          Build.Pkgs: 'SecurityPkg'
> >          Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > +      TARGET_UEFIPAYLOAD:
> > +        Build.Pkgs: 'UefiPayloadPkg'
> > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >        TARGET_PLATFORMS:
> >          # For Platforms only check code. Leave it to Platform CI
> >          # to build them.
> > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> > 96e6baa519..ce330e2c73 100644
> > --- a/.pytool/CISettings.py
> > +++ b/.pytool/CISettings.py
> > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, 
> > UpdateSettingsManager, SetupSettingsManag
> >                  "CryptoPkg",
> >                  "UnitTestFrameworkPkg",
> >                  "OvmfPkg",
> > -                "RedfishPkg"
> > +                "RedfishPkg",
> > +                "UefiPayloadPkg"
> >                  )
> >
> >      def GetArchitecturesSupported(self):
> > --
> > 2.31.1.windows.1
> >
> >
> >
> > 
> >
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80143): https://edk2.groups.io/g/devel/message/80143
Mute This Topic: https://groups.io/mt/85293834/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Posted by gaoliming 4 years, 5 months ago 
I upload it again. Now, it has been merged. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> 发送时间: 2021年9月2日 9:24
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> gate-build-job.yml and CISetting.py
> 
> Hi Liming,
> 
> I have seen the link to push my commits to master of edk2. The result shows
> that the Ci test failed in ArmPlatformPkg. But I think my commits will not
> affect the ArmPlatformPkg. Here is the link.
> https://github.com/tianocore/edk2/pull/1940the
> So is there anything I need to do?
> 
> Thanks,
> Dun
> -----Original Message-----
> From: Tan, Dun
> Sent: Wednesday, September 1, 2021 11:32 AM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> gate-build-job.yml and CISetting.py
> 
> Hi Liming,
> 
> The patch to fix the build issue has been merged this morning.
> Would you please help to merge the two patches to enable core CI for
> UefiPayloadPkg?
> 
> Thanks,
> Dun
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, August 31, 2021 9:05 AM
> To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> in gate-build-job.yml and CISetting.py
> 
> Dun:
>   This PR also includes one additional commit to fix the build issue. Have you
> send the patch for it?
> 
>   For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>.
> It will be merged after the build issue has been fixed.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Tan, Dun <dun.tan@intel.com>
> > 发送时间: 2021年8月30日 16:31
> > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> > in gate-build-job.yml and CISetting.py
> >
> > Hi Liming,
> >
> > Here is the link of the PR to verify the change in Tiano EDKII. It
> > passed the CI by GCC and VS both.
> > https://github.com/tianocore/edk2/pull/1931
> >
> > Thanks,
> > Dun
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Monday, August 30, 2021 11:26 AM
> > To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
> > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add
> > UefiPayloadPkg in gate-build-job.yml and CISetting.py
> >
> > Dun:
> >   I don't see the issues to enable UefiPayloadPkg in CI. Have you
> > created the private PR to verify this change?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> > > 发送时间: 2021年8月24日 17:24
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> > > in gate-build-job.yml and CISetting.py
> > >
> > > Hi all,
> > >     Since the CI for UefiPayloadPkg is important to our develop
> > > progress, would you please speed up the review process? Thanks a lot!
> > >
> > > Thanks,
> > > Dun Tan
> > > -----Original Message-----
> > > From: Tan, Dun <dun.tan@intel.com>
> > > Sent: Friday, August 20, 2021 2:44 PM
> > > To: devel@edk2.groups.io
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > > Tan, Dun <dun.tan@intel.com>
> > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> > > gate-build-job.yml and CISetting.py
> > >
> > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for
> > > UefiPayloadPkg.
> > > Add UefiPayloadPkg to supported Packages in CISettings.
> > >
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Signed-off-by: DunTan <dun.tan@intel.com>
> > > ---
> > >  .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> > >  .pytool/CISettings.py                           | 3 ++-
> > >  2 files changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > > b/.azurepipelines/templates/pr-gate-build-job.yml
> > > index 207acc7631..d5b16c127f 100644
> > > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > > @@ -48,6 +48,9 @@ jobs:
> > >        TARGET_SECURITY:
> > >          Build.Pkgs: 'SecurityPkg'
> > >          Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > > +      TARGET_UEFIPAYLOAD:
> > > +        Build.Pkgs: 'UefiPayloadPkg'
> > > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >        TARGET_PLATFORMS:
> > >          # For Platforms only check code. Leave it to Platform CI
> > >          # to build them.
> > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> > > 96e6baa519..ce330e2c73 100644
> > > --- a/.pytool/CISettings.py
> > > +++ b/.pytool/CISettings.py
> > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager,
> > > UpdateSettingsManager, SetupSettingsManag
> > >                  "CryptoPkg",
> > >                  "UnitTestFrameworkPkg",
> > >                  "OvmfPkg",
> > > -                "RedfishPkg"
> > > +                "RedfishPkg",
> > > +                "UefiPayloadPkg"
> > >                  )
> > >
> > >      def GetArchitecturesSupported(self):
> > > --
> > > 2.31.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80145): https://edk2.groups.io/g/devel/message/80145
Mute This Topic: https://groups.io/mt/85319448/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Posted by duntan 4 years, 5 months ago 
Thanks a lot!

Thanks,
Dun
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Thursday, September 2, 2021 10:10 AM
To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew' <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py

I upload it again. Now, it has been merged. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> 发送时间: 2021年9月2日 9:24
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg 
> in gate-build-job.yml and CISetting.py
> 
> Hi Liming,
> 
> I have seen the link to push my commits to master of edk2. The result 
> shows that the Ci test failed in ArmPlatformPkg. But I think my 
> commits will not affect the ArmPlatformPkg. Here is the link.
> https://github.com/tianocore/edk2/pull/1940the
> So is there anything I need to do?
> 
> Thanks,
> Dun
> -----Original Message-----
> From: Tan, Dun
> Sent: Wednesday, September 1, 2021 11:32 AM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add 
> UefiPayloadPkg in gate-build-job.yml and CISetting.py
> 
> Hi Liming,
> 
> The patch to fix the build issue has been merged this morning.
> Would you please help to merge the two patches to enable core CI for 
> UefiPayloadPkg?
> 
> Thanks,
> Dun
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, August 31, 2021 9:05 AM
> To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add 
> UefiPayloadPkg in gate-build-job.yml and CISetting.py
> 
> Dun:
>   This PR also includes one additional commit to fix the build issue. 
> Have you send the patch for it?
> 
>   For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>.
> It will be merged after the build issue has been fixed.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Tan, Dun <dun.tan@intel.com>
> > 发送时间: 2021年8月30日 16:31
> > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> > <michael.d.kinney@intel.com>
> > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg 
> > in gate-build-job.yml and CISetting.py
> >
> > Hi Liming,
> >
> > Here is the link of the PR to verify the change in Tiano EDKII. It 
> > passed the CI by GCC and VS both.
> > https://github.com/tianocore/edk2/pull/1931
> >
> > Thanks,
> > Dun
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Monday, August 30, 2021 11:26 AM
> > To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
> > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> > <michael.d.kinney@intel.com>
> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add 
> > UefiPayloadPkg in gate-build-job.yml and CISetting.py
> >
> > Dun:
> >   I don't see the issues to enable UefiPayloadPkg in CI. Have you 
> > created the private PR to verify this change?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> > > 发送时间: 2021年8月24日 17:24
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew 
> > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> > > <michael.d.kinney@intel.com>; Liming Gao 
> > > <gaoliming@byosoft.com.cn>
> > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add 
> > > UefiPayloadPkg in gate-build-job.yml and CISetting.py
> > >
> > > Hi all,
> > >     Since the CI for UefiPayloadPkg is important to our develop 
> > > progress, would you please speed up the review process? Thanks a lot!
> > >
> > > Thanks,
> > > Dun Tan
> > > -----Original Message-----
> > > From: Tan, Dun <dun.tan@intel.com>
> > > Sent: Friday, August 20, 2021 2:44 PM
> > > To: devel@edk2.groups.io
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew 
> > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D 
> > > <michael.d.kinney@intel.com>; Liming Gao 
> > > <gaoliming@byosoft.com.cn>; Tan, Dun <dun.tan@intel.com>
> > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in 
> > > gate-build-job.yml and CISetting.py
> > >
> > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for 
> > > UefiPayloadPkg.
> > > Add UefiPayloadPkg to supported Packages in CISettings.
> > >
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Signed-off-by: DunTan <dun.tan@intel.com>
> > > ---
> > >  .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> > >  .pytool/CISettings.py                           | 3 ++-
> > >  2 files changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > > b/.azurepipelines/templates/pr-gate-build-job.yml
> > > index 207acc7631..d5b16c127f 100644
> > > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > > @@ -48,6 +48,9 @@ jobs:
> > >        TARGET_SECURITY:
> > >          Build.Pkgs: 'SecurityPkg'
> > >          Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > > +      TARGET_UEFIPAYLOAD:
> > > +        Build.Pkgs: 'UefiPayloadPkg'
> > > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >        TARGET_PLATFORMS:
> > >          # For Platforms only check code. Leave it to Platform CI
> > >          # to build them.
> > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> > > 96e6baa519..ce330e2c73 100644
> > > --- a/.pytool/CISettings.py
> > > +++ b/.pytool/CISettings.py
> > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager, 
> > > UpdateSettingsManager, SetupSettingsManag
> > >                  "CryptoPkg",
> > >                  "UnitTestFrameworkPkg",
> > >                  "OvmfPkg",
> > > -                "RedfishPkg"
> > > +                "RedfishPkg",
> > > +                "UefiPayloadPkg"
> > >                  )
> > >
> > >      def GetArchitecturesSupported(self):
> > > --
> > > 2.31.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80146): https://edk2.groups.io/g/devel/message/80146
Mute This Topic: https://groups.io/mt/85319676/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py
Posted by gaoliming 4 years, 5 months ago 
Create PR https://github.com/tianocore/edk2/pull/1940 for this patch set. 

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> 发送时间: 2021年9月1日 11:32
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> gate-build-job.yml and CISetting.py
> 
> Hi Liming,
> 
> The patch to fix the build issue has been merged this morning.
> Would you please help to merge the two patches to enable core CI for
> UefiPayloadPkg?
> 
> Thanks,
> Dun
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, August 31, 2021 9:05 AM
> To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
> Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> in gate-build-job.yml and CISetting.py
> 
> Dun:
>   This PR also includes one additional commit to fix the build issue. Have you
> send the patch for it?
> 
>   For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>.
> It will be merged after the build issue has been fixed.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Tan, Dun <dun.tan@intel.com>
> > 发送时间: 2021年8月30日 16:31
> > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > 主题: RE: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> > in gate-build-job.yml and CISetting.py
> >
> > Hi Liming,
> >
> > Here is the link of the PR to verify the change in Tiano EDKII. It
> > passed the CI by GCC and VS both.
> > https://github.com/tianocore/edk2/pull/1931
> >
> > Thanks,
> > Dun
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Monday, August 30, 2021 11:26 AM
> > To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com>
> > Cc: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: 回复: [edk2-devel] [PATCH 2/2] .azurepipelines: Add
> > UefiPayloadPkg in gate-build-job.yml and CISetting.py
> >
> > Dun:
> >   I don't see the issues to enable UefiPayloadPkg in CI. Have you
> > created the private PR to verify this change?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 duntan
> > > 发送时间: 2021年8月24日 17:24
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > > 主题: Re: [edk2-devel] [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg
> > > in gate-build-job.yml and CISetting.py
> > >
> > > Hi all,
> > >     Since the CI for UefiPayloadPkg is important to our develop
> > > progress, would you please speed up the review process? Thanks a lot!
> > >
> > > Thanks,
> > > Dun Tan
> > > -----Original Message-----
> > > From: Tan, Dun <dun.tan@intel.com>
> > > Sent: Friday, August 20, 2021 2:44 PM
> > > To: devel@edk2.groups.io
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > > <Bret.Barkelew@microsoft.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > > Tan, Dun <dun.tan@intel.com>
> > > Subject: [PATCH 2/2] .azurepipelines: Add UefiPayloadPkg in
> > > gate-build-job.yml and CISetting.py
> > >
> > > Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for
> > > UefiPayloadPkg.
> > > Add UefiPayloadPkg to supported Packages in CISettings.
> > >
> > > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Signed-off-by: DunTan <dun.tan@intel.com>
> > > ---
> > >  .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> > >  .pytool/CISettings.py                           | 3 ++-
> > >  2 files changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > > b/.azurepipelines/templates/pr-gate-build-job.yml
> > > index 207acc7631..d5b16c127f 100644
> > > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > > @@ -48,6 +48,9 @@ jobs:
> > >        TARGET_SECURITY:
> > >          Build.Pkgs: 'SecurityPkg'
> > >          Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > > +      TARGET_UEFIPAYLOAD:
> > > +        Build.Pkgs: 'UefiPayloadPkg'
> > > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >        TARGET_PLATFORMS:
> > >          # For Platforms only check code. Leave it to Platform CI
> > >          # to build them.
> > > diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
> > > 96e6baa519..ce330e2c73 100644
> > > --- a/.pytool/CISettings.py
> > > +++ b/.pytool/CISettings.py
> > > @@ -67,7 +67,8 @@ class Settings(CiBuildSettingsManager,
> > > UpdateSettingsManager, SetupSettingsManag
> > >                  "CryptoPkg",
> > >                  "UnitTestFrameworkPkg",
> > >                  "OvmfPkg",
> > > -                "RedfishPkg"
> > > +                "RedfishPkg",
> > > +                "UefiPayloadPkg"
> > >                  )
> > >
> > >      def GetArchitecturesSupported(self):
> > > --
> > > 2.31.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80049): https://edk2.groups.io/g/devel/message/80049
Mute This Topic: https://groups.io/mt/85295596/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.