[v1] Update for edk2/master and VS2017/VS2019

[edk2-devel] [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build

Posted by Michael D Kinney 3 years, 1 month ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549

SocketDxe generates build failures with VS2017 and VS2019 due to
use of weak references and /WHOLEARCHIVE.  Disable SocketDxe until
weak references can be removed.

Cc: Rebecca Cran <rebecca@nuviainc.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 StdLib/StdLib.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/StdLib/StdLib.inc b/StdLib/StdLib.inc
index d0a0c8a..4c72b4f 100644
--- a/StdLib/StdLib.inc
+++ b/StdLib/StdLib.inc
@@ -99,7 +99,7 @@
 ##########
 #  Socket Layer
 ##########
-  StdLib/SocketDxe/SocketDxe.inf
+#  StdLib/SocketDxe/SocketDxe.inf
 
 
 ##############################################################################
-- 
2.32.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79464): https://edk2.groups.io/g/devel/message/79464
Mute This Topic: https://groups.io/mt/84966616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build

Posted by Rebecca Cran 3 years, 1 month ago

Maybe add a comment saying why it's disabled, in case fixing it takes 
some time?


-- 
Rebecca Cran


On 8/17/21 11:42 PM, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
>
> SocketDxe generates build failures with VS2017 and VS2019 due to
> use of weak references and /WHOLEARCHIVE.  Disable SocketDxe until
> weak references can be removed.
>
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   StdLib/StdLib.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/StdLib/StdLib.inc b/StdLib/StdLib.inc
> index d0a0c8a..4c72b4f 100644
> --- a/StdLib/StdLib.inc
> +++ b/StdLib/StdLib.inc
> @@ -99,7 +99,7 @@
>   ##########
>   #  Socket Layer
>   ##########
> -  StdLib/SocketDxe/SocketDxe.inf
> +#  StdLib/SocketDxe/SocketDxe.inf
>   
>   
>   ##############################################################################


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79496): https://edk2.groups.io/g/devel/message/79496
Mute This Topic: https://groups.io/mt/84966616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build

Posted by Michael D Kinney 3 years, 1 month ago

Good idea.

I was going to enter a BZ too.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> Sent: Wednesday, August 18, 2021 11:32 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-libc Patch 3/9] StdLib: Remove SocketDxe from build
> 
> Maybe add a comment saying why it's disabled, in case fixing it takes
> some time?
> 
> 
> --
> Rebecca Cran
> 
> 
> On 8/17/21 11:42 PM, Michael D Kinney wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3549
> >
> > SocketDxe generates build failures with VS2017 and VS2019 due to
> > use of weak references and /WHOLEARCHIVE.  Disable SocketDxe until
> > weak references can be removed.
> >
> > Cc: Rebecca Cran <rebecca@nuviainc.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >   StdLib/StdLib.inc | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/StdLib/StdLib.inc b/StdLib/StdLib.inc
> > index d0a0c8a..4c72b4f 100644
> > --- a/StdLib/StdLib.inc
> > +++ b/StdLib/StdLib.inc
> > @@ -99,7 +99,7 @@
> >   ##########
> >   #  Socket Layer
> >   ##########
> > -  StdLib/SocketDxe/SocketDxe.inf
> > +#  StdLib/SocketDxe/SocketDxe.inf
> >
> >
> >   ##############################################################################
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79508): https://edk2.groups.io/g/devel/message/79508
Mute This Topic: https://groups.io/mt/84966616/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-