ACPI 6.4 SBSA generic watchdog renaming

[edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

Posted by Chris Jones 2 years, 8 months ago

Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565)

This patch series updates the Acpiview GTDT parser and DynamicTables
GTDT generator to support ACPI 6.4. This involves the use of Acpi64.h
which requires the "SBSA Generic Watchdog" structure to be renamed to the
"Arm Generic Watchdog" strucutre.

The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1822_64_acpi_generic_watchdog_v1

Chris Jones (2):
  DynamicTablesPkg: Rename SBSA generic watchdog
  ShellPkg: Update Acpiview GTDT parser to ACPI 6.4

 .../Include/ArmNameSpaceObjects.h             |  8 +--
 .../Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c   | 60 +++++++++----------
 .../Parsers/Gtdt/GtdtParser.c                 | 14 ++---
 .../UefiShellAcpiViewCommandLib.c             |  2 +-
 4 files changed, 42 insertions(+), 42 deletions(-)

-- 
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79362): https://edk2.groups.io/g/devel/message/79362
Mute This Topic: https://groups.io/mt/84925099/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

Posted by Sami Mujawar 2 years, 8 months ago

This patch series looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 16/08/2021, 15:52, "Chris Jones" <christopher.jones@arm.com> wrote:

    Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565)

    This patch series updates the Acpiview GTDT parser and DynamicTables
    GTDT generator to support ACPI 6.4. This involves the use of Acpi64.h
    which requires the "SBSA Generic Watchdog" structure to be renamed to the
    "Arm Generic Watchdog" strucutre.

    The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1822_64_acpi_generic_watchdog_v1

    Chris Jones (2):
      DynamicTablesPkg: Rename SBSA generic watchdog
      ShellPkg: Update Acpiview GTDT parser to ACPI 6.4

     .../Include/ArmNameSpaceObjects.h             |  8 +--
     .../Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c   | 60 +++++++++----------
     .../Parsers/Gtdt/GtdtParser.c                 | 14 ++---
     .../UefiShellAcpiViewCommandLib.c             |  2 +-
     4 files changed, 42 insertions(+), 42 deletions(-)

    -- 
    Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79486): https://edk2.groups.io/g/devel/message/79486
Mute This Topic: https://groups.io/mt/84925099/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

Posted by Chris Jones 2 years, 7 months ago

I believe this patch series is just waiting for approval from the ShellPkg maintainers. As this has been waiting for several weeks, please could this get reviewed soon.


Thanks,
Chris

________________________________
From: Sami Mujawar <Sami.Mujawar@arm.com>
Sent: Wednesday, August 18, 2021 10:57 AM
To: Christopher Jones <Christopher.Jones@arm.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: ray.ni@intel.com <ray.ni@intel.com>; zhichao.gao@intel.com <zhichao.gao@intel.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; Akanksha Jain <Akanksha.Jain2@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>
Subject: Re: [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

This patch series looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 16/08/2021, 15:52, "Chris Jones" <christopher.jones@arm.com> wrote:

    Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565)

    This patch series updates the Acpiview GTDT parser and DynamicTables
    GTDT generator to support ACPI 6.4. This involves the use of Acpi64.h
    which requires the "SBSA Generic Watchdog" structure to be renamed to the
    "Arm Generic Watchdog" strucutre.

    The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1822_64_acpi_generic_watchdog_v1

    Chris Jones (2):
      DynamicTablesPkg: Rename SBSA generic watchdog
      ShellPkg: Update Acpiview GTDT parser to ACPI 6.4

     .../Include/ArmNameSpaceObjects.h             |  8 +--
     .../Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c   | 60 +++++++++----------
     .../Parsers/Gtdt/GtdtParser.c                 | 14 ++---
     .../UefiShellAcpiViewCommandLib.c             |  2 +-
     4 files changed, 42 insertions(+), 42 deletions(-)

    --
    Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80364): https://edk2.groups.io/g/devel/message/80364
Mute This Topic: https://groups.io/mt/84925099/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

Posted by Gao, Zhichao 2 years, 7 months ago

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar@arm.com>
> Sent: Wednesday, August 18, 2021 5:57 PM
> To: Christopher Jones <Christopher.Jones@arm.com>;
> devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> Alexei Fedorov <Alexei.Fedorov@arm.com>; Ben Adderson
> <Ben.Adderson@arm.com>; Akanksha Jain <Akanksha.Jain2@arm.com>;
> Matteo Carlini <Matteo.Carlini@arm.com>; nd <nd@arm.com>
> Subject: Re: [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming
> 
> This patch series looks good to me.
> 
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> 
> Regards,
> 
> Sami Mujawar
> 
> On 16/08/2021, 15:52, "Chris Jones" <christopher.jones@arm.com> wrote:
> 
>     Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565)
> 
>     This patch series updates the Acpiview GTDT parser and DynamicTables
>     GTDT generator to support ACPI 6.4. This involves the use of Acpi64.h
>     which requires the "SBSA Generic Watchdog" structure to be renamed to
> the
>     "Arm Generic Watchdog" strucutre.
> 
>     The changes can be seen at: https://github.com/chris-jones-
> arm/edk2/tree/1822_64_acpi_generic_watchdog_v1
> 
>     Chris Jones (2):
>       DynamicTablesPkg: Rename SBSA generic watchdog
>       ShellPkg: Update Acpiview GTDT parser to ACPI 6.4
> 
>      .../Include/ArmNameSpaceObjects.h             |  8 +--
>      .../Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c   | 60 +++++++++----------
>      .../Parsers/Gtdt/GtdtParser.c                 | 14 ++---
>      .../UefiShellAcpiViewCommandLib.c             |  2 +-
>      4 files changed, 42 insertions(+), 42 deletions(-)
> 
>     --
>     Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#80395): https://edk2.groups.io/g/devel/message/80395
Mute This Topic: https://groups.io/mt/84925099/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

Posted by Sami Mujawar 2 years, 7 months ago

Hi Zhichao,

The following patch series have been reviewed and have received r-b from the maintainers.

· https://edk2.groups.io/g/devel/topic/84925099#79362 (ShellPkg & DynamicTablesPkg)

· https://edk2.groups.io/g/devel/topic/84868164#79285 (ShellPkg)

· https://edk2.groups.io/g/devel/topic/84968868#79489 (ShellPkg)

Some of the patch series have DynamicTablesPkg patches as well.
If you agree I can merge the 3 patch series listed above in edk2 master. Kindly let me know.

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81018): https://edk2.groups.io/g/devel/message/81018
Mute This Topic: https://groups.io/mt/84925099/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

Posted by Gao, Zhichao 2 years, 7 months ago

You can create the PR by yourself.

Thanks,
Zhichao

From: Sami Mujawar <sami.mujawar@arm.com>
Sent: Thursday, September 23, 2021 4:37 PM
To: Gao; Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

Hi Zhichao,

The following patch series have been reviewed and have received r-b from the maintainers.

•         https://edk2.groups.io/g/devel/topic/84925099#79362 (ShellPkg & DynamicTablesPkg)

•         https://edk2.groups.io/g/devel/topic/84868164#79285 (ShellPkg)

•         https://edk2.groups.io/g/devel/topic/84968868#79489 (ShellPkg)

Some of the patch series have DynamicTablesPkg patches as well.
If you agree I can merge the 3 patch series listed above in edk2 master. Kindly let me know.

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81056): https://edk2.groups.io/g/devel/message/81056
Mute This Topic: https://groups.io/mt/84925099/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 0/2] ACPI 6.4 SBSA generic watchdog renaming

Posted by Sami Mujawar 2 years, 6 months ago

Merged as 06a326caf125..942c9bd357d8

Thanks.

Regards,

Sami Mujawar


On 16/08/2021 03:52 PM, Chris Jones wrote:
> Bugzilla: 3565 (https://bugzilla.tianocore.org/show_bug.cgi?id=3565)
>
> This patch series updates the Acpiview GTDT parser and DynamicTables
> GTDT generator to support ACPI 6.4. This involves the use of Acpi64.h
> which requires the "SBSA Generic Watchdog" structure to be renamed to the
> "Arm Generic Watchdog" strucutre.
>
> The changes can be seen at: https://github.com/chris-jones-arm/edk2/tree/1822_64_acpi_generic_watchdog_v1
>
> Chris Jones (2):
>    DynamicTablesPkg: Rename SBSA generic watchdog
>    ShellPkg: Update Acpiview GTDT parser to ACPI 6.4
>
>   .../Include/ArmNameSpaceObjects.h             |  8 +--
>   .../Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c   | 60 +++++++++----------
>   .../Parsers/Gtdt/GtdtParser.c                 | 14 ++---
>   .../UefiShellAcpiViewCommandLib.c             |  2 +-
>   4 files changed, 42 insertions(+), 42 deletions(-)
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81516): https://edk2.groups.io/g/devel/message/81516
Mute This Topic: https://groups.io/mt/84925099/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-