1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error message

Seonghyun Park posted 1 patch 2 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20210729010119.653113-1-shpark1@protonmail.com
MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error message
Posted by Seonghyun Park 2 years, 8 months ago 
Fix typo in error message in CapsuleApp.

Signed-off-by: Seonghyun Park <shpark1@protonmail.com>
---
 MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
index dba50b3202..712cf2e1f7 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
@@ -509,7 +509,7 @@ GetUpdateFileSystem (
     DevicePath = DuplicateDevicePath (MappedDevicePath);
     Status = GetEfiSysPartitionFromDevPath (DevicePath, &FullPath, Fs);
     if (EFI_ERROR (Status)) {
-      Print (L"Error: Cannot get EFI system partiion from '%s' - %r\n", Map, Status);
+      Print (L"Error: Cannot get EFI system partition from '%s' - %r\n", Map, Status);
       return EFI_NOT_FOUND;
     }
     Print (L"Warning: Cannot find Boot Option on '%s'!\n", Map);
-- 
2.32.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78376): https://edk2.groups.io/g/devel/message/78376
Mute This Topic: https://groups.io/mt/84528989/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error message
Posted by Wu, Hao A 2 years, 8 months ago 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Seonghyun Park
> Sent: Thursday, July 29, 2021 9:01 AM
> To: devel@edk2.groups.io
> Cc: Chen, Chen A <chen.a.chen@intel.com>; Seonghyun Park
> <shpark1@protonmail.com>
> Subject: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error
> message
> 
> Fix typo in error message in CapsuleApp.
> 
> Signed-off-by: Seonghyun Park <shpark1@protonmail.com>
> ---
>  MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> index dba50b3202..712cf2e1f7 100644
> --- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> @@ -509,7 +509,7 @@ GetUpdateFileSystem (
>      DevicePath = DuplicateDevicePath (MappedDevicePath);
> 
>      Status = GetEfiSysPartitionFromDevPath (DevicePath, &FullPath, Fs);
> 
>      if (EFI_ERROR (Status)) {
> 
> -      Print (L"Error: Cannot get EFI system partiion from '%s' - %r\n", Map,
> Status);
> 
> +      Print (L"Error: Cannot get EFI system partition from '%s' - %r\n", Map,
> Status);


Thanks for the patch.

I will change the commit title a little bit when merging:
MdeModulePkg/CapsuleApp: Fix typo in error message

The change itself is good to me:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> 
>        return EFI_NOT_FOUND;
> 
>      }
> 
>      Print (L"Warning: Cannot find Boot Option on '%s'!\n", Map);
> 
> --
> 2.32.0
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#78376): https://edk2.groups.io/g/devel/message/78376
> Mute This Topic: https://groups.io/mt/84528989/1768737
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78405): https://edk2.groups.io/g/devel/message/78405
Mute This Topic: https://groups.io/mt/84528989/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error message
Posted by Wu, Hao A 2 years, 8 months ago 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao
> A
> Sent: Friday, July 30, 2021 4:51 PM
> To: devel@edk2.groups.io; shpark.zilla@gmail.com
> Cc: Chen, Chen A <chen.a.chen@intel.com>; Seonghyun Park
> <shpark1@protonmail.com>
> Subject: Re: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error
> message
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Seonghyun Park
> > Sent: Thursday, July 29, 2021 9:01 AM
> > To: devel@edk2.groups.io
> > Cc: Chen, Chen A <chen.a.chen@intel.com>; Seonghyun Park
> > <shpark1@protonmail.com>
> > Subject: [edk2-devel] [edk2 PATCH] MdeModulePkg: Fix typo in error
> > message
> >
> > Fix typo in error message in CapsuleApp.
> >
> > Signed-off-by: Seonghyun Park <shpark1@protonmail.com>
> > ---
> >  MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> > b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> > index dba50b3202..712cf2e1f7 100644
> > --- a/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> > +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleOnDisk.c
> > @@ -509,7 +509,7 @@ GetUpdateFileSystem (
> >      DevicePath = DuplicateDevicePath (MappedDevicePath);
> >
> >      Status = GetEfiSysPartitionFromDevPath (DevicePath, &FullPath,
> > Fs);
> >
> >      if (EFI_ERROR (Status)) {
> >
> > -      Print (L"Error: Cannot get EFI system partiion from '%s' - %r\n", Map,
> > Status);
> >
> > +      Print (L"Error: Cannot get EFI system partition from '%s' -
> > + %r\n", Map,
> > Status);
> 
> 
> Thanks for the patch.
> 
> I will change the commit title a little bit when merging:
> MdeModulePkg/CapsuleApp: Fix typo in error message
> 
> The change itself is good to me:
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>


Pushed via:
PR - https://github.com/tianocore/edk2/pull/1852
Commit - https://github.com/tianocore/edk2/commit/3445058aea4f64a994e4ec040135258a135d36ce

Best Regards,
Hao Wu


> 
> Best Regards,
> Hao Wu
> 
> 
> >
> >        return EFI_NOT_FOUND;
> >
> >      }
> >
> >      Print (L"Warning: Cannot find Boot Option on '%s'!\n", Map);
> >
> > --
> > 2.32.0
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#78376):
> > https://edk2.groups.io/g/devel/message/78376
> > Mute This Topic: https://groups.io/mt/84528989/1768737
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com]
> > -=-=-=-=-=-=
> >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78477): https://edk2.groups.io/g/devel/message/78477
Mute This Topic: https://groups.io/mt/84528989/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.