SpcrFeaturePkg: Close the event after first callback.

[edk2-devel] [PATCH] SpcrFeaturePkg: Close the event after first callback.

Posted by Abdul Lateef Attar via groups.io 2 years, 9 months ago

Adds CloseEvent in callback routine OutOfBandACPITableConstruction(),
to avoid multiple installation of SPCR table.

Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
---
 .../OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c   | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c
index 85ac48cfa5..86c40e90b8 100644
--- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c
+++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c
@@ -368,6 +368,8 @@ OutOfBandACPITableConstruction (
 
   Handle          = NULL;
 
+  gBS->CloseEvent (Event);
+
   SavedDevicePath = GetSpcrDevice();
   if (SavedDevicePath == NULL) {
     return;
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78184): https://edk2.groups.io/g/devel/message/78184
Mute This Topic: https://groups.io/mt/84473711/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] SpcrFeaturePkg: Close the event after first callback.

Posted by Nate DeSimone 2 years, 6 months ago

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Monday, July 26, 2021 12:30 AM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [PATCH] SpcrFeaturePkg: Close the event after first callback.
> 
> Adds CloseEvent in callback routine OutOfBandACPITableConstruction(), to
> avoid multiple installation of SPCR table.
> 
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
>  .../OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c   | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spc
> rAcpi.c
> b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Sp
> crAcpi.c
> index 85ac48cfa5..86c40e90b8 100644
> ---
> a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spc
> rAcpi.c
> +++
> b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Sp
> cr
> +++ Acpi.c
> @@ -368,6 +368,8 @@ OutOfBandACPITableConstruction (
> 
>    Handle          = NULL;
> 
> +  gBS->CloseEvent (Event);
> +
>    SavedDevicePath = GetSpcrDevice();
>    if (SavedDevicePath == NULL) {
>      return;
> --
> 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81778): https://edk2.groups.io/g/devel/message/81778
Mute This Topic: https://groups.io/mt/84473711/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] SpcrFeaturePkg: Close the event after first callback.

Posted by Nate DeSimone 2 years, 6 months ago

Pushed: https://github.com/tianocore/edk2-platforms/commit/f539647

> -----Original Message-----
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Sent: Monday, July 26, 2021 12:30 AM
> To: devel@edk2.groups.io
> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> Subject: [PATCH] SpcrFeaturePkg: Close the event after first callback.
> 
> Adds CloseEvent in callback routine OutOfBandACPITableConstruction(), to
> avoid multiple installation of SPCR table.
> 
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
>  .../OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c   | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spc
> rAcpi.c
> b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Sp
> crAcpi.c
> index 85ac48cfa5..86c40e90b8 100644
> ---
> a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spc
> rAcpi.c
> +++
> b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Sp
> cr
> +++ Acpi.c
> @@ -368,6 +368,8 @@ OutOfBandACPITableConstruction (
> 
>    Handle          = NULL;
> 
> +  gBS->CloseEvent (Event);
> +
>    SavedDevicePath = GetSpcrDevice();
>    if (SavedDevicePath == NULL) {
>      return;
> --
> 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81779): https://edk2.groups.io/g/devel/message/81779
Mute This Topic: https://groups.io/mt/84473711/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-