[edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt

Abner Chang posted 2 patches 4 years, 6 months ago
[edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt
Posted by Abner Chang 4 years, 6 months ago
Add maintainer and reviewer to RedfishClinetPkg.

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 Maintainers.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index e9dda5c5ca..55068c9140 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -519,6 +519,11 @@ F: RedfishPkg/
 M: Abner Chang <abner.chang@hpe.com>
 R: Nickle Wang <nickle.wang@hpe.com>
 
+RedfishClientPkg: Redfish Client related modules
+F: RedfishClientPkg/
+M: Abner Chang <abner.chang@hpe.com>
+R: Nickle Wang <nickle.wang@hpe.com>
+
 SecurityPkg
 F: SecurityPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77941): https://edk2.groups.io/g/devel/message/77941
Mute This Topic: https://groups.io/mt/84326489/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt
Posted by Leif Lindholm 4 years, 6 months ago
On Tue, Jul 20, 2021 at 11:53:58 +0800, Abner Chang wrote:
> Add maintainer and reviewer to RedfishClinetPkg.
> 
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index e9dda5c5ca..55068c9140 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -519,6 +519,11 @@ F: RedfishPkg/
>  M: Abner Chang <abner.chang@hpe.com>
>  R: Nickle Wang <nickle.wang@hpe.com>
>  
> +RedfishClientPkg: Redfish Client related modules

My interpretation of the normal use of this field is that we can add a
comment if the entry applies only to a subset of a package.
This adds an entry for a whole new package, and as such should only
state the name of the package.

With everything from the : until the end of line dropped:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

/
    Leif

> +F: RedfishClientPkg/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Nickle Wang <nickle.wang@hpe.com>
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> -- 
> 2.17.1
> 
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78589): https://edk2.groups.io/g/devel/message/78589
Mute This Topic: https://groups.io/mt/84326489/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt
Posted by Abner Chang 4 years, 6 months ago
Thanks Leif, I remove the description from the package name.

Abner

> -----Original Message-----
> From: Leif Lindholm [mailto:leif@nuviainc.com]
> Sent: Tuesday, August 3, 2021 7:16 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com>; Michael D
> Kinney <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2:
> Update Maintainers.txt
> 
> On Tue, Jul 20, 2021 at 11:53:58 +0800, Abner Chang wrote:
> > Add maintainer and reviewer to RedfishClinetPkg.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >  Maintainers.txt | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index e9dda5c5ca..55068c9140 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -519,6 +519,11 @@ F: RedfishPkg/
> >  M: Abner Chang <abner.chang@hpe.com>
> >  R: Nickle Wang <nickle.wang@hpe.com>
> >
> > +RedfishClientPkg: Redfish Client related modules
> 
> My interpretation of the normal use of this field is that we can add a
> comment if the entry applies only to a subset of a package.
> This adds an entry for a whole new package, and as such should only
> state the name of the package.
> 
> With everything from the : until the end of line dropped:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> 
> /
>     Leif
> 
> > +F: RedfishClientPkg/
> > +M: Abner Chang <abner.chang@hpe.com>
> > +R: Nickle Wang <nickle.wang@hpe.com>
> > +
> >  SecurityPkg
> >  F: SecurityPkg/
> >  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> > --
> > 2.17.1
> >
> >
> >
> > 
> >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78596): https://edk2.groups.io/g/devel/message/78596
Mute This Topic: https://groups.io/mt/84326489/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt
Posted by Nickle Wang 4 years, 6 months ago
Reviewed-by: Nickle Wang <nickle.wang@hpe.com>

Nickle

-----Original Message-----
From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com> 
Sent: Tuesday, July 20, 2021 11:54 AM
To: devel@edk2.groups.io
Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Liming Gao <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>; Michael D Kinney <michael.d.kinney@intel.com>
Subject: [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt

Add maintainer and reviewer to RedfishClinetPkg.

Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 Maintainers.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt index e9dda5c5ca..55068c9140 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -519,6 +519,11 @@ F: RedfishPkg/
 M: Abner Chang <abner.chang@hpe.com>
 R: Nickle Wang <nickle.wang@hpe.com>
 
+RedfishClientPkg: Redfish Client related modules
+F: RedfishClientPkg/
+M: Abner Chang <abner.chang@hpe.com>
+R: Nickle Wang <nickle.wang@hpe.com>
+
 SecurityPkg
 F: SecurityPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
--
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78871): https://edk2.groups.io/g/devel/message/78871
Mute This Topic: https://groups.io/mt/84326489/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-