Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index 2d51fdbacb..041fed842c 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -34,6 +34,7 @@ FV = PLDFV
################################################################################
[FV.PLDFV]
+FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45
BlockSize = $(FD_BLOCK_SIZE)
FvAlignment = 16
ERASE_POLARITY = 1
@@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-E77F1DB2D793 {
################################################################################
[FV.DXEFV]
+FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23
BlockSize = $(FD_BLOCK_SIZE)
FvForceRebase = FALSE
FvAlignment = 16
--
2.30.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762
Mute This Topic: https://groups.io/mt/84196221/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Ray Ni <ray.ni@intel.com> -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhiguang Liu Sent: Wednesday, July 14, 2021 2:25 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com> --- UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf index 2d51fdbacb..041fed842c 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.fdf +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf @@ -34,6 +34,7 @@ FV = PLDFV ################################################################################ [FV.PLDFV]+FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45 BlockSize = $(FD_BLOCK_SIZE) FvAlignment = 16 ERASE_POLARITY = 1@@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B-E77F1DB2D793 { ################################################################################ [FV.DXEFV]+FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23 BlockSize = $(FD_BLOCK_SIZE) FvForceRebase = FALSE FvAlignment = 16-- 2.30.0.windows.2 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762 Mute This Topic: https://groups.io/mt/84196221/1712937 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77764): https://edk2.groups.io/g/devel/message/77764 Mute This Topic: https://groups.io/mt/84196221/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Signed-off-by: Guo Dong <guo.dong@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Zhiguang Liu > Sent: Tuesday, July 13, 2021 11:25 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and > PLDFV > > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com> > --- > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index 2d51fdbacb..041fed842c 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -34,6 +34,7 @@ FV = PLDFV > > > > ########################################################## > ###################### > > [FV.PLDFV] > > +FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45 > > BlockSize = $(FD_BLOCK_SIZE) > > FvAlignment = 16 > > ERASE_POLARITY = 1 > > @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B- > E77F1DB2D793 { > > ########################################################## > ###################### > > > > [FV.DXEFV] > > +FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23 > > BlockSize = $(FD_BLOCK_SIZE) > > FvForceRebase = FALSE > > FvAlignment = 16 > > -- > 2.30.0.windows.2 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762 > Mute This Topic: https://groups.io/mt/84196221/1781375 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#77796): https://edk2.groups.io/g/devel/message/77796 Mute This Topic: https://groups.io/mt/84196221/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi All, This patch broke the coreboot payload loading. Tested with: build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image: "Not a usable UEFI firmware volume" Trying to boot coreboot results in an exception and the following error message: "Payload not loaded" Probably it broke the interface. commit 4bac086e8e007c7143e33f87bb96238326d1d6ba Author: Zhiguang Liu <zhiguang.liu@intel.com> Date: Wed Jul 14 14:24:45 2021 +0800 UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Reviewed-by: Guo Dong <guo.dong@intel.com> Kind regards, Sumo On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@intel.com> wrote: > > Signed-off-by: Guo Dong <guo.dong@intel.com> > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > > Zhiguang Liu > > Sent: Tuesday, July 13, 2021 11:25 PM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and > > PLDFV > > > > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com> > > --- > > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > > b/UefiPayloadPkg/UefiPayloadPkg.fdf > > index 2d51fdbacb..041fed842c 100644 > > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > > @@ -34,6 +34,7 @@ FV = PLDFV > > > > > > > > ########################################################## > > ###################### > > > > [FV.PLDFV] > > > > +FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45 > > > > BlockSize = $(FD_BLOCK_SIZE) > > > > FvAlignment = 16 > > > > ERASE_POLARITY = 1 > > > > @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B- > > E77F1DB2D793 { > > > > ########################################################## > > ###################### > > > > > > > > [FV.DXEFV] > > > > +FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23 > > > > BlockSize = $(FD_BLOCK_SIZE) > > > > FvForceRebase = FALSE > > > > FvAlignment = 16 > > > > -- > > 2.30.0.windows.2 > > > > > > > > -=-=-=-=-=-= > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762 > > Mute This Topic: https://groups.io/mt/84196221/1781375 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com] > > -=-=-=-=-=-= > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79729): https://edk2.groups.io/g/devel/message/79729 Mute This Topic: https://groups.io/mt/84196221/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
It seems like the coreboot cannot support FV that contains GUID in its header. From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of King Sumo Sent: Tuesday, August 24, 2021 1:02 AM To: devel@edk2.groups.io; Dong, Guo <guo.dong@intel.com> Cc: Liu, Zhiguang <zhiguang.liu@intel.com> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Hi All, This patch broke the coreboot payload loading. Tested with: build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image: "Not a usable UEFI firmware volume" Trying to boot coreboot results in an exception and the following error message: "Payload not loaded" Probably it broke the interface. commit 4bac086e8e007c7143e33f87bb96238326d1d6ba Author: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Date: Wed Jul 14 14:24:45 2021 +0800 UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Reviewed-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> Kind regards, Sumo On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> wrote: Signed-off-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of > Zhiguang Liu > Sent: Tuesday, July 13, 2021 11:25 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and > PLDFV > > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> > --- > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index 2d51fdbacb..041fed842c 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -34,6 +34,7 @@ FV = PLDFV > > > > ########################################################## > ###################### > > [FV.PLDFV] > > +FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45 > > BlockSize = $(FD_BLOCK_SIZE) > > FvAlignment = 16 > > ERASE_POLARITY = 1 > > @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B- > E77F1DB2D793 { > > ########################################################## > ###################### > > > > [FV.DXEFV] > > +FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23 > > BlockSize = $(FD_BLOCK_SIZE) > > FvForceRebase = FALSE > > FvAlignment = 16 > > -- > 2.30.0.windows.2 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762 > Mute This Topic: https://groups.io/mt/84196221/1781375 > Group Owner: devel+owner@edk2.groups.io<mailto:devel%2Bowner@edk2.groups.io> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com<mailto:guo.dong@intel.com>] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79762): https://edk2.groups.io/g/devel/message/79762 Mute This Topic: https://groups.io/mt/84196221/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
I have filed a bug report: https://bugzilla.tianocore.org/show_bug.cgi?id=3585 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79776): https://edk2.groups.io/g/devel/message/79776 Mute This Topic: https://groups.io/mt/84196221/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Zhiguang, This patch just uses an actual FV GUID to replace the dummy FV GUID (all zero FV GUID) and no FV layout change, right? If so, this change should not impact the coreboot FV parse to find the FV entrypoint. https://github.com/coreboot/coreboot/blob/master/util/cbfstool/cbfs-mkpayload.c Thanks, Guo From: Ni, Ray <ray.ni@intel.com> Sent: Tuesday, August 24, 2021 4:45 AM To: devel@edk2.groups.io; kingsumos@gmail.com; Dong, Guo <guo.dong@intel.com> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Tan, Dun <dun.tan@intel.com> Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV It seems like the coreboot cannot support FV that contains GUID in its header. From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of King Sumo Sent: Tuesday, August 24, 2021 1:02 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> Cc: Liu, Zhiguang <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Hi All, This patch broke the coreboot payload loading. Tested with: build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image: "Not a usable UEFI firmware volume" Trying to boot coreboot results in an exception and the following error message: "Payload not loaded" Probably it broke the interface. commit 4bac086e8e007c7143e33f87bb96238326d1d6ba Author: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Date: Wed Jul 14 14:24:45 2021 +0800 UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Reviewed-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> Kind regards, Sumo On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> wrote: Signed-off-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of > Zhiguang Liu > Sent: Tuesday, July 13, 2021 11:25 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and > PLDFV > > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> > --- > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index 2d51fdbacb..041fed842c 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -34,6 +34,7 @@ FV = PLDFV > > > > ########################################################## > ###################### > > [FV.PLDFV] > > +FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45 > > BlockSize = $(FD_BLOCK_SIZE) > > FvAlignment = 16 > > ERASE_POLARITY = 1 > > @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B- > E77F1DB2D793 { > > ########################################################## > ###################### > > > > [FV.DXEFV] > > +FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23 > > BlockSize = $(FD_BLOCK_SIZE) > > FvForceRebase = FALSE > > FvAlignment = 16 > > -- > 2.30.0.windows.2 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762 > Mute This Topic: https://groups.io/mt/84196221/1781375 > Group Owner: devel+owner@edk2.groups.io<mailto:devel%2Bowner@edk2.groups.io> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com<mailto:guo.dong@intel.com>] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79779): https://edk2.groups.io/g/devel/message/79779 Mute This Topic: https://groups.io/mt/84196221/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Dun will investigate this issue. There might be some issue in coreboot implementation that doesn’t handle the existence of EFI_FIRMWARE_VOLUME_EXT_HEADER. From: Dong, Guo <guo.dong@intel.com> Sent: Wednesday, August 25, 2021 2:53 AM To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; kingsumos@gmail.com Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Tan, Dun <dun.tan@intel.com> Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Hi Zhiguang, This patch just uses an actual FV GUID to replace the dummy FV GUID (all zero FV GUID) and no FV layout change, right? If so, this change should not impact the coreboot FV parse to find the FV entrypoint. https://github.com/coreboot/coreboot/blob/master/util/cbfstool/cbfs-mkpayload.c Thanks, Guo From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Tuesday, August 24, 2021 4:45 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; kingsumos@gmail.com<mailto:kingsumos@gmail.com>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> Cc: Liu, Zhiguang <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>; Tan, Dun <dun.tan@intel.com<mailto:dun.tan@intel.com>> Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV It seems like the coreboot cannot support FV that contains GUID in its header. From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of King Sumo Sent: Tuesday, August 24, 2021 1:02 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> Cc: Liu, Zhiguang <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Hi All, This patch broke the coreboot payload loading. Tested with: build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image: "Not a usable UEFI firmware volume" Trying to boot coreboot results in an exception and the following error message: "Payload not loaded" Probably it broke the interface. commit 4bac086e8e007c7143e33f87bb96238326d1d6ba Author: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Date: Wed Jul 14 14:24:45 2021 +0800 UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Reviewed-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> Kind regards, Sumo On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> wrote: Signed-off-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of > Zhiguang Liu > Sent: Tuesday, July 13, 2021 11:25 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and > PLDFV > > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> > --- > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index 2d51fdbacb..041fed842c 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -34,6 +34,7 @@ FV = PLDFV > > > > ########################################################## > ###################### > > [FV.PLDFV] > > +FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45 > > BlockSize = $(FD_BLOCK_SIZE) > > FvAlignment = 16 > > ERASE_POLARITY = 1 > > @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B- > E77F1DB2D793 { > > ########################################################## > ###################### > > > > [FV.DXEFV] > > +FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23 > > BlockSize = $(FD_BLOCK_SIZE) > > FvForceRebase = FALSE > > FvAlignment = 16 > > -- > 2.30.0.windows.2 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762 > Mute This Topic: https://groups.io/mt/84196221/1781375 > Group Owner: devel+owner@edk2.groups.io<mailto:devel%2Bowner@edk2.groups.io> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com<mailto:guo.dong@intel.com>] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#79780): https://edk2.groups.io/g/devel/message/79780 Mute This Topic: https://groups.io/mt/84196221/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi all, I have push the commit to fix this issue to coreboot.org. Here is the link. https://review.coreboot.org/c/coreboot/+/57296 This issue is caused because the coreboot implementation doesn’t handle the existence of EFI_FIRMWARE_VOLUME_EXT_HEADER, resulting in address of UefiPayloadEntry to be found incorrectly when parsing Fv. Can you please help to review and merge this commit? Thanks, Dun From: Ni, Ray <ray.ni@intel.com> Sent: Wednesday, August 25, 2021 8:28 AM To: Dong, Guo <guo.dong@intel.com>; devel@edk2.groups.io; kingsumos@gmail.com Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Tan, Dun <dun.tan@intel.com> Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Dun will investigate this issue. There might be some issue in coreboot implementation that doesn’t handle the existence of EFI_FIRMWARE_VOLUME_EXT_HEADER. From: Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> Sent: Wednesday, August 25, 2021 2:53 AM To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; kingsumos@gmail.com<mailto:kingsumos@gmail.com> Cc: Liu, Zhiguang <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>; Tan, Dun <dun.tan@intel.com<mailto:dun.tan@intel.com>> Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Hi Zhiguang, This patch just uses an actual FV GUID to replace the dummy FV GUID (all zero FV GUID) and no FV layout change, right? If so, this change should not impact the coreboot FV parse to find the FV entrypoint. https://github.com/coreboot/coreboot/blob/master/util/cbfstool/cbfs-mkpayload.c Thanks, Guo From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>> Sent: Tuesday, August 24, 2021 4:45 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; kingsumos@gmail.com<mailto:kingsumos@gmail.com>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> Cc: Liu, Zhiguang <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>; Tan, Dun <dun.tan@intel.com<mailto:dun.tan@intel.com>> Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV It seems like the coreboot cannot support FV that contains GUID in its header. From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of King Sumo Sent: Tuesday, August 24, 2021 1:02 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>> Cc: Liu, Zhiguang <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Hi All, This patch broke the coreboot payload loading. Tested with: build -a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc -b RELEASE -t GCC5 -D BOOTLOADER=COREBOOT Basically the coreboot cbfstool reports the following error when creating the CBFS / flash image: "Not a usable UEFI firmware volume" Trying to boot coreboot results in an exception and the following error message: "Payload not loaded" Probably it broke the interface. commit 4bac086e8e007c7143e33f87bb96238326d1d6ba Author: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Date: Wed Jul 14 14:24:45 2021 +0800 UefiPayloadPkg: Add FV Guid for DXEFV and PLDFV Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Reviewed-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> Kind regards, Sumo On Wed, Jul 14, 2021 at 1:08 PM Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> wrote: Signed-off-by: Guo Dong <guo.dong@intel.com<mailto:guo.dong@intel.com>> > -----Original Message----- > From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of > Zhiguang Liu > Sent: Tuesday, July 13, 2021 11:25 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add FV Guid for DXEFV and > PLDFV > > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>> > --- > UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index 2d51fdbacb..041fed842c 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -34,6 +34,7 @@ FV = PLDFV > > > > ########################################################## > ###################### > > [FV.PLDFV] > > +FvNameGuid = 96E75986-6FDD-491E-9FD5-35E21AC45B45 > > BlockSize = $(FD_BLOCK_SIZE) > > FvAlignment = 16 > > ERASE_POLARITY = 1 > > @@ -62,6 +63,7 @@ FILE FV_IMAGE = 4E35FD93-9C72-4c15-8C4B- > E77F1DB2D793 { > > ########################################################## > ###################### > > > > [FV.DXEFV] > > +FvNameGuid = 8063C21A-8E58-4576-95CE-089E87975D23 > > BlockSize = $(FD_BLOCK_SIZE) > > FvForceRebase = FALSE > > FvAlignment = 16 > > -- > 2.30.0.windows.2 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#77762): https://edk2.groups.io/g/devel/message/77762 > Mute This Topic: https://groups.io/mt/84196221/1781375 > Group Owner: devel+owner@edk2.groups.io<mailto:devel%2Bowner@edk2.groups.io> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [guo.dong@intel.com<mailto:guo.dong@intel.com>] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80053): https://edk2.groups.io/g/devel/message/80053 Mute This Topic: https://groups.io/mt/84196221/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.