[edk2-devel] [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail to build this package.

Chiu, Chasel posted 2 patches 4 years, 7 months ago
[edk2-devel] [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail to build this package.
Posted by Chiu, Chasel 4 years, 7 months ago
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484

Fixed the build failure of this package.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
index ced0a97c37..0c7a29cc75 100644
--- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
+++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
@@ -7,7 +7,7 @@
 # 1. Present a consolidated and simplified view of all available advanced features to board packages.
 # 2. Provide a simple, single package build for all available advanced features.
 #
-# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -30,7 +30,12 @@
   PEI_ARCH                            = IA32
   DXE_ARCH                            = X64
 
-!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc

+[Packages]
+  MdePkg/MdePkg.dec
+  MinPlatformPkg/MinPlatformPkg.dec
+
+!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
 
 ################################################################################
 #
@@ -48,6 +53,16 @@
   gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable    |TRUE
   gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable                      |TRUE
   gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable                              |FALSE
+  gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable                |FALSE
+  gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable                   |FALSE
+  gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable                      |FALSE
+
+#
+# Include common library
+#
+!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
+!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
 
 #
 # This package builds all advanced features.
-- 
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77600): https://edk2.groups.io/g/devel/message/77600
Mute This Topic: https://groups.io/mt/84069087/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail to build this package.
Posted by Chaganty, Rangasai V 4 years, 7 months ago
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>  

-----Original Message-----
From: Chiu, Chasel <chasel.chiu@intel.com> 
Sent: Thursday, July 08, 2021 7:41 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Oram, Isaac W <isaac.w.oram@intel.com>
Subject: [edk2-platforms: PATCH 2/2] AdvancedFeaturePkg: Fail to build this package.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3484

Fixed the build failure of this package.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
index ced0a97c37..0c7a29cc75 100644
--- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
+++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
@@ -7,7 +7,7 @@
 # 1. Present a consolidated and simplified view of all available advanced features to board packages.

 # 2. Provide a simple, single package build for all available advanced features.

 #

-# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>

+# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.<BR>

 #

 # SPDX-License-Identifier: BSD-2-Clause-Patent

 #

@@ -30,7 +30,12 @@
   PEI_ARCH                            = IA32

   DXE_ARCH                            = X64

 

-!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc


+[Packages]

+  MdePkg/MdePkg.dec

+  MinPlatformPkg/MinPlatformPkg.dec

+

+!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc

+

 

 ################################################################################

 #

@@ -48,6 +53,16 @@
   gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable    |TRUE

   gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable                      |TRUE

   gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable                              |FALSE

+  gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable                |FALSE

+  gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable                   |FALSE

+  gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable                      |FALSE

+

+#

+# Include common library

+#

+!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc

+!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc

+!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc

 

 #

 # This package builds all advanced features.

-- 
2.28.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77628): https://edk2.groups.io/g/devel/message/77628
Mute This Topic: https://groups.io/mt/84069087/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-