[v2] Allow EccCheck to run on other repositories

[edk2-devel] [PATCH v2 0/4] Allow EccCheck to run on other repositories

Posted by PierreGondois 3 years, 4 months ago

From: Pierre Gondois <Pierre.Gondois@arm.com>

EccCheck currently makes some assumptions on its working
environment that prevent it from running it in other repositories.
For instance, the workspace is assumed to be pointing to the edk2
repository path, which can be wrong.
This patch-set aims to allow the EccCheck tool to run on the
edk2-platforms repository, with edk2 being a submodule of
edk2-platforms.

The changes can be seen at: https://github.com/PierreARM/edk2/commits/1628_Ecc_environment_paths_update_v2

v2:
 - Use ';' path separator for Windows host [Liming]  

Pierre Gondois (4):
  .pytool/EccCheck: Locate BaseTools dir with EDK_TOOLS_PATH
  .pytool/EccCheck: Rename edk2_path as workspace_path
  .pytool/EccCheck: Check ecc_csv exists
  .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc

 .pytool/Plugin/EccCheck/EccCheck.py | 46 +++++++++++++++--------------
 1 file changed, 24 insertions(+), 22 deletions(-)

-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77533): https://edk2.groups.io/g/devel/message/77533
Mute This Topic: https://groups.io/mt/84030563/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] Allow EccCheck to run on other repositories

Posted by PierreGondois 3 years, 4 months ago

Hi Sean and Bret,
Do you have any comments on the patchset ?

Regards,
Pierre


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78013): https://edk2.groups.io/g/devel/message/78013
Mute This Topic: https://groups.io/mt/84030563/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v2 0/4] Allow EccCheck to run on other repositories

Posted by gaoliming 3 years, 4 months ago

Pierre:

 I have merged this patch set at 40a9066439cbab235933525810f46f03806c6ef1..fb5b6220a9718fc28ae67f317d3611214a05589c

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 PierreGondois
发送时间: 2021年7月21日 16:20
收件人: PierreGondois <pierre.gondois@arm.com>; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 0/4] Allow EccCheck to run on other repositories

 

Hi Sean and Bret,
Do you have any comments on the patchset ?

Regards,
Pierre





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#78016): https://edk2.groups.io/g/devel/message/78016
Mute This Topic: https://groups.io/mt/84352403/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH v2 0/4] Allow EccCheck to run on other repositories

Posted by gaoliming 3 years, 4 months ago

This version is good to me. Reviewed-by: Liming Gao
<gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> 发送时间: 2021年7月7日 4:56
> 收件人: devel@edk2.groups.io; Sean Brogan <sean.brogan@microsoft.com>;
> Bret Barkelew <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Sami Mujawar <sami.mujawar@arm.com>
> 主题: [PATCH v2 0/4] Allow EccCheck to run on other repositories
> 
> From: Pierre Gondois <Pierre.Gondois@arm.com>
> 
> EccCheck currently makes some assumptions on its working
> environment that prevent it from running it in other repositories.
> For instance, the workspace is assumed to be pointing to the edk2
> repository path, which can be wrong.
> This patch-set aims to allow the EccCheck tool to run on the
> edk2-platforms repository, with edk2 being a submodule of
> edk2-platforms.
> 
> The changes can be seen at:
> https://github.com/PierreARM/edk2/commits/1628_Ecc_environment_paths
> _update_v2
> 
> v2:
>  - Use ';' path separator for Windows host [Liming]
> 
> Pierre Gondois (4):
>   .pytool/EccCheck: Locate BaseTools dir with EDK_TOOLS_PATH
>   .pytool/EccCheck: Rename edk2_path as workspace_path
>   .pytool/EccCheck: Check ecc_csv exists
>   .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc
> 
>  .pytool/Plugin/EccCheck/EccCheck.py | 46 +++++++++++++++--------------
>  1 file changed, 24 insertions(+), 22 deletions(-)
> 
> --
> 2.17.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77543): https://edk2.groups.io/g/devel/message/77543
Mute This Topic: https://groups.io/mt/84036372/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-