[edk2-devel] [PATCH v2 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP

Laszlo Ersek posted 6 patches 2 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20210629163337.14120-1-lersek@redhat.com
NetworkPkg/IScsiDxe/IScsiCHAP.c        | 204 ++++++++++++++++----
NetworkPkg/IScsiDxe/IScsiCHAP.h        |  95 +++++++--
NetworkPkg/IScsiDxe/IScsiDriver.c      |   2 +
NetworkPkg/IScsiDxe/IScsiProto.c       |  21 ++
NetworkPkg/NetworkBuildOptions.dsc.inc |   2 +-
NetworkPkg/NetworkDefines.dsc.inc      |  20 ++
6 files changed, 293 insertions(+), 51 deletions(-)
[edk2-devel] [PATCH v2 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP
Posted by Laszlo Ersek 2 years, 10 months ago
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
Repo:     https://pagure.io/lersek/edk2.git
Branch:   iscsi_sha256_bz3355_v2 (at commit 73b92e85b4de)
CI:       https://github.com/tianocore/edk2/pull/1772

v1 was posted at:

* [edk2-devel] [PATCH 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP

  Message-Id: <20210608130652.2434-1-lersek@redhat.com>
  https://listman.redhat.com/archives/edk2-devel-archive/2021-June/msg00331.html
  https://edk2.groups.io/g/devel/message/76213
  https://bugzilla.tianocore.org/show_bug.cgi?id=3355#c3

v2 addresses the v1 review feedback. Please see the Notes section on
every patch.

v2 has been retested, with results identical to those of v1. (Please see
the v1 blurb for details.)

Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>

Thanks,
Laszlo

Laszlo Ersek (6):
  NetworkPkg/IScsiDxe: re-set session-level authentication state before
    login
  NetworkPkg/IScsiDxe: add horizontal whitespace to IScsiCHAP files
  NetworkPkg/IScsiDxe: distinguish "maximum" and "selected" CHAP digest
    sizes
  NetworkPkg/IScsiDxe: support multiple hash algorithms for CHAP
  NetworkPkg/IScsiDxe: support SHA256 in CHAP
  NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro

 NetworkPkg/IScsiDxe/IScsiCHAP.c        | 204 ++++++++++++++++----
 NetworkPkg/IScsiDxe/IScsiCHAP.h        |  95 +++++++--
 NetworkPkg/IScsiDxe/IScsiDriver.c      |   2 +
 NetworkPkg/IScsiDxe/IScsiProto.c       |  21 ++
 NetworkPkg/NetworkBuildOptions.dsc.inc |   2 +-
 NetworkPkg/NetworkDefines.dsc.inc      |  20 ++
 6 files changed, 293 insertions(+), 51 deletions(-)


base-commit: b37cfdd2807181aed2fee1e17bd7ec1190db266a
-- 
2.19.1.3.g30247aa5d201



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77282): https://edk2.groups.io/g/devel/message/77282
Mute This Topic: https://groups.io/mt/83872634/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP
Posted by Maciej Rabeda 2 years, 10 months ago
Thanks, Laszlo. I really like moving the condition out of 'if' clause in 
IScsiCHAPAuthTarget :)

For the patchset:
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

On 29-Jun-21 18:33, Laszlo Ersek wrote:
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
> Repo:     https://pagure.io/lersek/edk2.git
> Branch:   iscsi_sha256_bz3355_v2 (at commit 73b92e85b4de)
> CI:       https://github.com/tianocore/edk2/pull/1772
>
> v1 was posted at:
>
> * [edk2-devel] [PATCH 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP
>
>    Message-Id: <20210608130652.2434-1-lersek@redhat.com>
>    https://listman.redhat.com/archives/edk2-devel-archive/2021-June/msg00331.html
>    https://edk2.groups.io/g/devel/message/76213
>    https://bugzilla.tianocore.org/show_bug.cgi?id=3355#c3
>
> v2 addresses the v1 review feedback. Please see the Notes section on
> every patch.
>
> v2 has been retested, with results identical to those of v1. (Please see
> the v1 blurb for details.)
>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (6):
>    NetworkPkg/IScsiDxe: re-set session-level authentication state before
>      login
>    NetworkPkg/IScsiDxe: add horizontal whitespace to IScsiCHAP files
>    NetworkPkg/IScsiDxe: distinguish "maximum" and "selected" CHAP digest
>      sizes
>    NetworkPkg/IScsiDxe: support multiple hash algorithms for CHAP
>    NetworkPkg/IScsiDxe: support SHA256 in CHAP
>    NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro
>
>   NetworkPkg/IScsiDxe/IScsiCHAP.c        | 204 ++++++++++++++++----
>   NetworkPkg/IScsiDxe/IScsiCHAP.h        |  95 +++++++--
>   NetworkPkg/IScsiDxe/IScsiDriver.c      |   2 +
>   NetworkPkg/IScsiDxe/IScsiProto.c       |  21 ++
>   NetworkPkg/NetworkBuildOptions.dsc.inc |   2 +-
>   NetworkPkg/NetworkDefines.dsc.inc      |  20 ++
>   6 files changed, 293 insertions(+), 51 deletions(-)
>
>
> base-commit: b37cfdd2807181aed2fee1e17bd7ec1190db266a



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77300): https://edk2.groups.io/g/devel/message/77300
Mute This Topic: https://groups.io/mt/83872634/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v2 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP
Posted by Laszlo Ersek 2 years, 10 months ago
On 06/29/21 20:44, Maciej Rabeda wrote:
> Thanks, Laszlo. I really like moving the condition out of 'if' clause in
> IScsiCHAPAuthTarget :)
> 
> For the patchset:
> Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

Thank you!

Merged as commit range 3cde0d553d93..bb33c27fbed6, via
<https://github.com/tianocore/edk2/pull/1780>.

Laszlo

> 
> On 29-Jun-21 18:33, Laszlo Ersek wrote:
>> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3355
>> Repo:     https://pagure.io/lersek/edk2.git
>> Branch:   iscsi_sha256_bz3355_v2 (at commit 73b92e85b4de)
>> CI:       https://github.com/tianocore/edk2/pull/1772
>>
>> v1 was posted at:
>>
>> * [edk2-devel] [PATCH 0/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP
>>
>>    Message-Id: <20210608130652.2434-1-lersek@redhat.com>
>>   
>> https://listman.redhat.com/archives/edk2-devel-archive/2021-June/msg00331.html
>>
>>    https://edk2.groups.io/g/devel/message/76213
>>    https://bugzilla.tianocore.org/show_bug.cgi?id=3355#c3
>>
>> v2 addresses the v1 review feedback. Please see the Notes section on
>> every patch.
>>
>> v2 has been retested, with results identical to those of v1. (Please see
>> the v1 blurb for details.)
>>
>> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Siyuan Fu <siyuan.fu@intel.com>
>>
>> Thanks,
>> Laszlo
>>
>> Laszlo Ersek (6):
>>    NetworkPkg/IScsiDxe: re-set session-level authentication state before
>>      login
>>    NetworkPkg/IScsiDxe: add horizontal whitespace to IScsiCHAP files
>>    NetworkPkg/IScsiDxe: distinguish "maximum" and "selected" CHAP digest
>>      sizes
>>    NetworkPkg/IScsiDxe: support multiple hash algorithms for CHAP
>>    NetworkPkg/IScsiDxe: support SHA256 in CHAP
>>    NetworkPkg: introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro
>>
>>   NetworkPkg/IScsiDxe/IScsiCHAP.c        | 204 ++++++++++++++++----
>>   NetworkPkg/IScsiDxe/IScsiCHAP.h        |  95 +++++++--
>>   NetworkPkg/IScsiDxe/IScsiDriver.c      |   2 +
>>   NetworkPkg/IScsiDxe/IScsiProto.c       |  21 ++
>>   NetworkPkg/NetworkBuildOptions.dsc.inc |   2 +-
>>   NetworkPkg/NetworkDefines.dsc.inc      |  20 ++
>>   6 files changed, 293 insertions(+), 51 deletions(-)
>>
>>
>> base-commit: b37cfdd2807181aed2fee1e17bd7ec1190db266a
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77377): https://edk2.groups.io/g/devel/message/77377
Mute This Topic: https://groups.io/mt/83872634/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-