On 06/23/21 16:06, PierreGondois wrote:
> From: Sami Mujawar <sami.mujawar@arm.com>
>
> Most ACPI tables for Kvmtool firmware are dynamically
> generated. The AML code is also generated at runtime
> for most components in appropriate SSDTs.
>
> Although there may not be much to describe in the DSDT,
> the DSDT table is mandatory.
>
> Therefore, add an empty stub for DSDT.
>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
> .../KvmtoolCfgMgrDxe/AslTables/Dsdt.asl | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 ArmVirtPkg/KvmtoolCfgMgrDxe/AslTables/Dsdt.asl
>
> diff --git a/ArmVirtPkg/KvmtoolCfgMgrDxe/AslTables/Dsdt.asl b/ArmVirtPkg/KvmtoolCfgMgrDxe/AslTables/Dsdt.asl
> new file mode 100644
> index 000000000000..8467d1ede4ec
> --- /dev/null
> +++ b/ArmVirtPkg/KvmtoolCfgMgrDxe/AslTables/Dsdt.asl
> @@ -0,0 +1,19 @@
> +/** @file
> + Differentiated System Description Table Fields (DSDT)
> +
> + Copyright (c) 2021, ARM Ltd. All rights reserved.<BR>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-KVMT", 1) {
> + Scope (_SB) {
> + // Most ACPI tables for Kvmtool firmware are
> + // dynamically generated. The AML code is also
> + // generated at runtime for most components in
> + // appropriate SSDTs.
> + // Although there may not be much to describe
> + // in the DSDT, the DSDT table is mandatory.
> + // Therefore, add an empty stub for DSDT.
> + } // Scope (_SB)
> +}
>
Please insert empty // lines at the top and bottom of the comment block,
to stick more closely with the edk2 coding style.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77055): https://edk2.groups.io/g/devel/message/77055
Mute This Topic: https://groups.io/mt/83738488/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-