Hi Pierre,
Thank you for this patch. This patch looks good to me.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 23/06/2021 12:40 PM, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> Remove the STATIC qualifier for the AmlUtility function
> AmlNodeGetIntegerValue() and add the definition to the
> header file so that it can be used by other AmlLib
> sub-modules.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
> .../Library/Common/AmlLib/Utils/AmlUtility.c | 3 +--
> .../Library/Common/AmlLib/Utils/AmlUtility.h | 18 +++++++++++++++++-
> 2 files changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.c b/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.c
> index 7ebd08f945c0..3c8927acda6a 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.c
> @@ -1,7 +1,7 @@
> /** @file
> AML Utility.
>
> - Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.<BR>
> + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
> @@ -192,7 +192,6 @@ AmlComputeSize (
> @retval EFI_SUCCESS The function completed successfully.
> @retval EFI_INVALID_PARAMETER Invalid parameter.
> **/
> -STATIC
> EFI_STATUS
> EFIAPI
> AmlNodeGetIntegerValue (
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.h b/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.h
> index c57d780140d4..5013bfb81d2d 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.h
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/Utils/AmlUtility.h
> @@ -1,7 +1,7 @@
> /** @file
> AML Utility.
>
> - Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.<BR>
> + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
> @@ -39,6 +39,22 @@ AmlComputeSize (
> IN OUT UINT32 * Size
> );
>
> +/** Get the value contained in an integer node.
> +
> + @param [in] Node Pointer to an integer node.
> + Must be an object node.
> + @param [out] Value Value contained in the integer node.
> +
> + @retval EFI_SUCCESS The function completed successfully.
> + @retval EFI_INVALID_PARAMETER Invalid parameter.
> +**/
> +EFI_STATUS
> +EFIAPI
> +AmlNodeGetIntegerValue (
> + IN AML_OBJECT_NODE * Node,
> + OUT UINT64 * Value
> + );
> +
> /** Set the value contained in an integer node.
>
> The OpCode is updated accordingly to the new value
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81365): https://edk2.groups.io/g/devel/message/81365
Mute This Topic: https://groups.io/mt/83735648/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-