[edk2-devel] [PATCH v1 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc

PierreGondois posted 4 patches 4 years, 7 months ago
There is a newer version of this series
[edk2-devel] [PATCH v1 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc
Posted by PierreGondois 4 years, 7 months ago
From: Pierre Gondois <Pierre.Gondois@arm.com>

When running Ecc on other repositories (e.g.: edk2-platforms with
edk2 as a submodule), edk2 modules are referenced.
E.g.: MdePkg/..
The PACKAGES_PATH env var can be used to reference other directories
containing packages. Set it so that Ecc can find these packages.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
 .pytool/Plugin/EccCheck/EccCheck.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.pytool/Plugin/EccCheck/EccCheck.py b/.pytool/Plugin/EccCheck/EccCheck.py
index 87f0e65a140f..49d143b32f91 100644
--- a/.pytool/Plugin/EccCheck/EccCheck.py
+++ b/.pytool/Plugin/EccCheck/EccCheck.py
@@ -67,6 +67,7 @@ class EccCheck(ICiBuildPlugin):
         env = shell_environment.GetEnvironment()
         env.set_shell_var('PYTHONPATH', python_path)
         env.set_shell_var('WORKSPACE', workspace_path)
+        env.set_shell_var('PACKAGES_PATH', ":".join(Edk2pathObj.PackagePathList))
         self.ECC_PASS = True
         self.ApplyConfig(pkgconfig, workspace_path, basetools_path, packagename)
         modify_dir_list = self.GetModifyDir(packagename)
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76906): https://edk2.groups.io/g/devel/message/76906
Mute This Topic: https://groups.io/mt/83732991/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


[edk2-devel] 回复: [PATCH v1 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc
Posted by gaoliming 4 years, 7 months ago
Pierre:

> -----邮件原件-----
> 发件人: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> 发送时间: 2021年6月23日 15:23
> 收件人: devel@edk2.groups.io; Sean Brogan <sean.brogan@microsoft.com>;
> Bret Barkelew <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Sami Mujawar <sami.mujawar@arm.com>
> 主题: [PATCH v1 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc
> 
> From: Pierre Gondois <Pierre.Gondois@arm.com>
> 
> When running Ecc on other repositories (e.g.: edk2-platforms with
> edk2 as a submodule), edk2 modules are referenced.
> E.g.: MdePkg/..
> The PACKAGES_PATH env var can be used to reference other directories
> containing packages. Set it so that Ecc can find these packages.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>  .pytool/Plugin/EccCheck/EccCheck.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
> b/.pytool/Plugin/EccCheck/EccCheck.py
> index 87f0e65a140f..49d143b32f91 100644
> --- a/.pytool/Plugin/EccCheck/EccCheck.py
> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> @@ -67,6 +67,7 @@ class EccCheck(ICiBuildPlugin):
>          env = shell_environment.GetEnvironment()
>          env.set_shell_var('PYTHONPATH', python_path)
>          env.set_shell_var('WORKSPACE', workspace_path)
> +        env.set_shell_var('PACKAGES_PATH',
> ":".join(Edk2pathObj.PackagePathList))
":" is Linux OS path separator. Windows OS path separator is ";". 

Thanks
Liming
>          self.ECC_PASS = True
>          self.ApplyConfig(pkgconfig, workspace_path, basetools_path,
> packagename)
>          modify_dir_list = self.GetModifyDir(packagename)
> --
> 2.17.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#77030): https://edk2.groups.io/g/devel/message/77030
Mute This Topic: https://groups.io/mt/83752265/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-