Add a new structure for BootManagerMenu HOB and consume it

[edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add new structure for BootManagerMenuFile HOB

Posted by duntan 4 years, 7 months ago

Add new structure for BootManagerMenuFile HOB in UefiPayloadPkg

Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>

Signed-off-by: DunTan <dun.tan@intel.com>
---
 UefiPayloadPkg/Include/Guid/BootManagerMenu.h | 27 +++++++++++++++++++++++++++
 UefiPayloadPkg/UefiPayloadPkg.dec             |  3 +++
 2 files changed, 30 insertions(+)

diff --git a/UefiPayloadPkg/Include/Guid/BootManagerMenu.h b/UefiPayloadPkg/Include/Guid/BootManagerMenu.h
new file mode 100644
index 0000000000..10fb874640
--- /dev/null
+++ b/UefiPayloadPkg/Include/Guid/BootManagerMenu.h
@@ -0,0 +1,27 @@
+/** @file
+  Define the structure for the Boot Manager Menu File.
+
+Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU_H_
+#define UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU_H_
+
+#include <Uefi.h>
+#include <UniversalPayload/UniversalPayload.h>
+
+#pragma pack (1)
+
+typedef struct {
+  UNIVERSAL_PAYLOAD_GENERIC_HEADER   Header;
+  GUID                               FileName;
+} UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU;
+
+#pragma pack()
+
+#define UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU_REVISION 1
+
+extern GUID gUniversalPayloadBootManagerMenuFileGuid;
+#endif
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec b/UefiPayloadPkg/UefiPayloadPkg.dec
index 105e1f5a1c..850592976d 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dec
+++ b/UefiPayloadPkg/UefiPayloadPkg.dec
@@ -29,6 +29,9 @@
   #
   gBmpImageGuid                           = { 0x878AC2CC, 0x5343, 0x46F2, { 0xB5, 0x63, 0x51, 0xF8, 0x9D, 0xAF, 0x56, 0xBA } }
 
+  ##include/Guid/BootManagerMenu.h
+  gUniversalPayloadBootManagerMenuFileGuid = { 0xdf939333, 0x42fc, 0x4b2a, { 0xa5, 0x9e, 0xbb, 0xae, 0x82, 0x81, 0xfe, 0xef }}
+
   gUefiSystemTableInfoGuid = {0x16c8a6d0, 0xfe8a, 0x4082, {0xa2, 0x8, 0xcf, 0x89, 0xc4, 0x29, 0x4, 0x33}}
   gUefiAcpiBoardInfoGuid   = {0xad3d31b, 0xb3d8, 0x4506, {0xae, 0x71, 0x2e, 0xf1, 0x10, 0x6, 0xd9, 0xf}}
   gUefiSerialPortInfoGuid  = { 0x6c6872fe, 0x56a9, 0x4403, { 0xbb, 0x98, 0x95, 0x8d, 0x62, 0xde, 0x87, 0xf1 } }
-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76810): https://edk2.groups.io/g/devel/message/76810
Mute This Topic: https://groups.io/mt/83696284/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add new structure for BootManagerMenuFile HOB

Posted by Guo Dong 4 years, 7 months ago

+  gUniversalPayloadBootManagerMenuFileGuid

Had better rename this guid to remove "UniversalPayload" from the name since this guid is not defined in universal payload specification. 

Thanks,
Guo
> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Monday, June 21, 2021 1:47 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo
> <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>; Tan,
> Dun <dun.tan@intel.com>
> Subject: [PATCH 1/2] UefiPayloadPkg: Add new structure for
> BootManagerMenuFile HOB
> 
> Add new structure for BootManagerMenuFile HOB in UefiPayloadPkg
> 
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> 
> Signed-off-by: DunTan <dun.tan@intel.com>
> ---
>  UefiPayloadPkg/Include/Guid/BootManagerMenu.h | 27
> +++++++++++++++++++++++++++
>  UefiPayloadPkg/UefiPayloadPkg.dec             |  3 +++
>  2 files changed, 30 insertions(+)
> 
> diff --git a/UefiPayloadPkg/Include/Guid/BootManagerMenu.h
> b/UefiPayloadPkg/Include/Guid/BootManagerMenu.h
> new file mode 100644
> index 0000000000..10fb874640
> --- /dev/null
> +++ b/UefiPayloadPkg/Include/Guid/BootManagerMenu.h
> @@ -0,0 +1,27 @@
> +/** @file
> +  Define the structure for the Boot Manager Menu File.
> +
> +Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU_H_
> +#define UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU_H_
> +
> +#include <Uefi.h>
> +#include <UniversalPayload/UniversalPayload.h>
> +
> +#pragma pack (1)
> +
> +typedef struct {
> +  UNIVERSAL_PAYLOAD_GENERIC_HEADER   Header;
> +  GUID                               FileName;
> +} UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU;
> +
> +#pragma pack()
> +
> +#define UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU_REVISION 1
> +
> +extern GUID gUniversalPayloadBootManagerMenuFileGuid;
> +#endif
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec
> b/UefiPayloadPkg/UefiPayloadPkg.dec
> index 105e1f5a1c..850592976d 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dec
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dec
> @@ -29,6 +29,9 @@
>    #
>    gBmpImageGuid                           = { 0x878AC2CC, 0x5343, 0x46F2, { 0xB5, 0x63,
> 0x51, 0xF8, 0x9D, 0xAF, 0x56, 0xBA } }
> 
> +  ##include/Guid/BootManagerMenu.h
> +  gUniversalPayloadBootManagerMenuFileGuid = { 0xdf939333, 0x42fc,
> 0x4b2a, { 0xa5, 0x9e, 0xbb, 0xae, 0x82, 0x81, 0xfe, 0xef }}
> +
>    gUefiSystemTableInfoGuid = {0x16c8a6d0, 0xfe8a, 0x4082, {0xa2, 0x8, 0xcf,
> 0x89, 0xc4, 0x29, 0x4, 0x33}}
>    gUefiAcpiBoardInfoGuid   = {0xad3d31b, 0xb3d8, 0x4506, {0xae, 0x71, 0x2e,
> 0xf1, 0x10, 0x6, 0xd9, 0xf}}
>    gUefiSerialPortInfoGuid  = { 0x6c6872fe, 0x56a9, 0x4403, { 0xbb, 0x98, 0x95,
> 0x8d, 0x62, 0xde, 0x87, 0xf1 } }
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76875): https://edk2.groups.io/g/devel/message/76875
Mute This Topic: https://groups.io/mt/83696284/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add new structure for BootManagerMenuFile HOB

Posted by Ni, Ray 4 years, 7 months ago

I agree. We can use gEdkiiBootManagerMenuFileGuid.

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guo Dong
Sent: Wednesday, June 23, 2021 6:58 AM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add new structure for BootManagerMenuFile HOB


+  gUniversalPayloadBootManagerMenuFileGuid

Had better rename this guid to remove "UniversalPayload" from the name since this guid is not defined in universal payload specification. 

Thanks,
Guo
> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Monday, June 21, 2021 1:47 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo 
> <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>; Tan, Dun 
> <dun.tan@intel.com>
> Subject: [PATCH 1/2] UefiPayloadPkg: Add new structure for 
> BootManagerMenuFile HOB
> 
> Add new structure for BootManagerMenuFile HOB in UefiPayloadPkg
> 
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> 
> Signed-off-by: DunTan <dun.tan@intel.com>
> ---
>  UefiPayloadPkg/Include/Guid/BootManagerMenu.h | 27
> +++++++++++++++++++++++++++
>  UefiPayloadPkg/UefiPayloadPkg.dec             |  3 +++
>  2 files changed, 30 insertions(+)
> 
> diff --git a/UefiPayloadPkg/Include/Guid/BootManagerMenu.h
> b/UefiPayloadPkg/Include/Guid/BootManagerMenu.h
> new file mode 100644
> index 0000000000..10fb874640
> --- /dev/null
> +++ b/UefiPayloadPkg/Include/Guid/BootManagerMenu.h
> @@ -0,0 +1,27 @@
> +/** @file
> +  Define the structure for the Boot Manager Menu File.
> +
> +Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU_H_
> +#define UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU_H_
> +
> +#include <Uefi.h>
> +#include <UniversalPayload/UniversalPayload.h>
> +
> +#pragma pack (1)
> +
> +typedef struct {
> +  UNIVERSAL_PAYLOAD_GENERIC_HEADER   Header;
> +  GUID                               FileName;
> +} UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU;
> +
> +#pragma pack()
> +
> +#define UNIVERSAL_PAYLOAD_BOOT_MANAGER_MENU_REVISION 1
> +
> +extern GUID gUniversalPayloadBootManagerMenuFileGuid;
> +#endif
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dec
> b/UefiPayloadPkg/UefiPayloadPkg.dec
> index 105e1f5a1c..850592976d 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dec
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dec
> @@ -29,6 +29,9 @@
>    #
>    gBmpImageGuid                           = { 0x878AC2CC, 0x5343, 0x46F2, { 0xB5, 0x63,
> 0x51, 0xF8, 0x9D, 0xAF, 0x56, 0xBA } }
> 
> +  ##include/Guid/BootManagerMenu.h
> +  gUniversalPayloadBootManagerMenuFileGuid = { 0xdf939333, 0x42fc,
> 0x4b2a, { 0xa5, 0x9e, 0xbb, 0xae, 0x82, 0x81, 0xfe, 0xef }}
> +
>    gUefiSystemTableInfoGuid = {0x16c8a6d0, 0xfe8a, 0x4082, {0xa2, 0x8, 
> 0xcf, 0x89, 0xc4, 0x29, 0x4, 0x33}}
>    gUefiAcpiBoardInfoGuid   = {0xad3d31b, 0xb3d8, 0x4506, {0xae, 0x71, 0x2e,
> 0xf1, 0x10, 0x6, 0xd9, 0xf}}
>    gUefiSerialPortInfoGuid  = { 0x6c6872fe, 0x56a9, 0x4403, { 0xbb, 
> 0x98, 0x95, 0x8d, 0x62, 0xde, 0x87, 0xf1 } }
> --
> 2.31.1.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76885): https://edk2.groups.io/g/devel/message/76885
Mute This Topic: https://groups.io/mt/83696284/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add new structure for BootManagerMenuFile HOB
[edk2-devel] [PATCH 2/2] UefiPayloadPkg: consume the BootManagerMenuFile HOB