1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat

Rebecca Cran posted 1 patch 4 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20210613033506.95018-1-rebecca@bsdio.com
BaseTools/toolsetup.bat | 1 -
1 file changed, 1 deletion(-)
[edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat
Posted by Rebecca Cran 4 years, 8 months ago 
Split is now a Python tool, so BaseTools\Bin\Win32\Split.exe no longer
exists. Remove the check for it from toolsetup.bat to prevent the
erroneous claim that the binary C tools are missing.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 BaseTools/toolsetup.bat | 1 -
 1 file changed, 1 deletion(-)

diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
index 4b5256ab6e..a766a69f08 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -299,7 +299,6 @@ IF NOT EXIST "%EDK_TOOLS_BIN%\GenFfs.exe" goto check_c_tools
 IF NOT EXIST "%EDK_TOOLS_BIN%\GenFv.exe" goto check_c_tools
 IF NOT EXIST "%EDK_TOOLS_BIN%\GenFw.exe" goto check_c_tools
 IF NOT EXIST "%EDK_TOOLS_BIN%\GenSec.exe" goto check_c_tools
-IF NOT EXIST "%EDK_TOOLS_BIN%\Split.exe" goto check_c_tools
 IF NOT EXIST "%EDK_TOOLS_BIN%\TianoCompress.exe" goto check_c_tools
 IF NOT EXIST "%EDK_TOOLS_BIN%\VfrCompile.exe" goto check_c_tools
 IF NOT EXIST "%EDK_TOOLS_BIN%\VolInfo.exe" goto check_c_tools
-- 
2.32.0




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76441): https://edk2.groups.io/g/devel/message/76441
Mute This Topic: https://groups.io/mt/83503018/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat
Posted by gaoliming 4 years, 7 months ago 
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2021年6月13日 11:35
> 收件人: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in
> toolset.bat
> 
> Split is now a Python tool, so BaseTools\Bin\Win32\Split.exe no longer
> exists. Remove the check for it from toolsetup.bat to prevent the
> erroneous claim that the binary C tools are missing.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  BaseTools/toolsetup.bat | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
> index 4b5256ab6e..a766a69f08 100755
> --- a/BaseTools/toolsetup.bat
> +++ b/BaseTools/toolsetup.bat
> @@ -299,7 +299,6 @@ IF NOT EXIST "%EDK_TOOLS_BIN%\GenFfs.exe" goto
> check_c_tools
>  IF NOT EXIST "%EDK_TOOLS_BIN%\GenFv.exe" goto check_c_tools
> 
>  IF NOT EXIST "%EDK_TOOLS_BIN%\GenFw.exe" goto check_c_tools
> 
>  IF NOT EXIST "%EDK_TOOLS_BIN%\GenSec.exe" goto check_c_tools
> 
> -IF NOT EXIST "%EDK_TOOLS_BIN%\Split.exe" goto check_c_tools
> 
>  IF NOT EXIST "%EDK_TOOLS_BIN%\TianoCompress.exe" goto check_c_tools
> 
>  IF NOT EXIST "%EDK_TOOLS_BIN%\VfrCompile.exe" goto check_c_tools
> 
>  IF NOT EXIST "%EDK_TOOLS_BIN%\VolInfo.exe" goto check_c_tools
> 
> --
> 2.32.0
> 
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#76441): https://edk2.groups.io/g/devel/message/76441
> Mute This Topic: https://groups.io/mt/83503018/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76632): https://edk2.groups.io/g/devel/message/76632
Mute This Topic: https://groups.io/mt/83595685/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat
Posted by Bob Feng 4 years, 7 months ago 
Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Thursday, June 17, 2021 9:36 AM
To: devel@edk2.groups.io; rebecca@bsdio.com; Feng, Bob C <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2021年6月13日 11:35
> 收件人: Bob Feng <bob.c.feng@intel.com>; Liming Gao 
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in 
> toolset.bat
> 
> Split is now a Python tool, so BaseTools\Bin\Win32\Split.exe no longer 
> exists. Remove the check for it from toolsetup.bat to prevent the 
> erroneous claim that the binary C tools are missing.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  BaseTools/toolsetup.bat | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index 
> 4b5256ab6e..a766a69f08 100755
> --- a/BaseTools/toolsetup.bat
> +++ b/BaseTools/toolsetup.bat
> @@ -299,7 +299,6 @@ IF NOT EXIST "%EDK_TOOLS_BIN%\GenFfs.exe" goto 
> check_c_tools  IF NOT EXIST "%EDK_TOOLS_BIN%\GenFv.exe" goto 
> check_c_tools
> 
>  IF NOT EXIST "%EDK_TOOLS_BIN%\GenFw.exe" goto check_c_tools
> 
>  IF NOT EXIST "%EDK_TOOLS_BIN%\GenSec.exe" goto check_c_tools
> 
> -IF NOT EXIST "%EDK_TOOLS_BIN%\Split.exe" goto check_c_tools
> 
>  IF NOT EXIST "%EDK_TOOLS_BIN%\TianoCompress.exe" goto check_c_tools
> 
>  IF NOT EXIST "%EDK_TOOLS_BIN%\VfrCompile.exe" goto check_c_tools
> 
>  IF NOT EXIST "%EDK_TOOLS_BIN%\VolInfo.exe" goto check_c_tools
> 
> --
> 2.32.0
> 
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#76441): 
> https://edk2.groups.io/g/devel/message/76441
> Mute This Topic: https://groups.io/mt/83503018/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76643): https://edk2.groups.io/g/devel/message/76643
Mute This Topic: https://groups.io/mt/83597001/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.