From: Sean Brogan <sean.brogan@microsoft.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445

This change fixed a misspelling that was not caught by spell check.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>

Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
---
 StandaloneMmPkg/Core/Dispatcher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c
index dbd5332fa9d3..7e4bf5e94025 100644
--- a/StandaloneMmPkg/Core/Dispatcher.c
+++ b/StandaloneMmPkg/Core/Dispatcher.c
@@ -4,7 +4,7 @@
   Step #1 - When a FV protocol is added to the system every driver in the FV
             is added to the mDiscoveredList. The Before, and After Depex are
             pre-processed as drivers are added to the mDiscoveredList. If an Apriori
-            file exists in the FV those drivers are addeded to the
+            file exists in the FV those drivers are added to the
             mScheduledQueue. The mFwVolList is used to make sure a
             FV is only processed once.
 
-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76420): https://edk2.groups.io/g/devel/message/76420
Mute This Topic: https://groups.io/mt/83484181/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Sat, 12 Jun 2021 at 05:44, Kun Qin <kuqin12@gmail.com> wrote:
>
> From: Sean Brogan <sean.brogan@microsoft.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
>
> This change fixed a misspelling that was not caught by spell check.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
>
> Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>

Hello Kun Qin,

When you send patches to the list that were authored by someone else,
you should add your own signoff, and add it last. (The signoff means
that you attest that the patch is contributed under terms that are
compatible with the open source licenses we support. The signoff has
nothing to do with recognizing authorship, so even if someone else did
most of the work, if that person is not involved in contributing these
changes, their name does not need to appear in the Git log.)

Sean is the author, which will be reflected in the git log anyway, so
his signoff does not have any significance here, as he is not the one
sending the patch to the public mailing list.

Usually, I would fix up minor issues like these when merging the
changes, but adding a signoff on someone else's behalf is the one
thing I can never do.

So please fix this up, and then you can add

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

to the entire series.

Thanks,



> ---
>  StandaloneMmPkg/Core/Dispatcher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c
> index dbd5332fa9d3..7e4bf5e94025 100644
> --- a/StandaloneMmPkg/Core/Dispatcher.c
> +++ b/StandaloneMmPkg/Core/Dispatcher.c
> @@ -4,7 +4,7 @@
>    Step #1 - When a FV protocol is added to the system every driver in the FV
>              is added to the mDiscoveredList. The Before, and After Depex are
>              pre-processed as drivers are added to the mDiscoveredList. If an Apriori
> -            file exists in the FV those drivers are addeded to the
> +            file exists in the FV those drivers are added to the
>              mScheduledQueue. The mFwVolList is used to make sure a
>              FV is only processed once.
>
> --
> 2.31.1.windows.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76430): https://edk2.groups.io/g/devel/message/76430
Mute This Topic: https://groups.io/mt/83484181/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Ard,

Sorry for the confusion and thanks for providing the r-b tag.

This should be fixed in v2 patches: 
https://edk2.groups.io/g/devel/message/76479

Regards,
Kun

On 06/12/2021 01:22, Ard Biesheuvel wrote:
> On Sat, 12 Jun 2021 at 05:44, Kun Qin <kuqin12@gmail.com> wrote:
>>
>> From: Sean Brogan <sean.brogan@microsoft.com>
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
>>
>> This change fixed a misspelling that was not caught by spell check.
>>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>
>> Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
> 
> Hello Kun Qin,
> 
> When you send patches to the list that were authored by someone else,
> you should add your own signoff, and add it last. (The signoff means
> that you attest that the patch is contributed under terms that are
> compatible with the open source licenses we support. The signoff has
> nothing to do with recognizing authorship, so even if someone else did
> most of the work, if that person is not involved in contributing these
> changes, their name does not need to appear in the Git log.)
> 
> Sean is the author, which will be reflected in the git log anyway, so
> his signoff does not have any significance here, as he is not the one
> sending the patch to the public mailing list.
> 
> Usually, I would fix up minor issues like these when merging the
> changes, but adding a signoff on someone else's behalf is the one
> thing I can never do.
> 
> So please fix this up, and then you can add
> 
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> 
> to the entire series.
> 
> Thanks,
> 
> 
> 
>> ---
>>   StandaloneMmPkg/Core/Dispatcher.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c
>> index dbd5332fa9d3..7e4bf5e94025 100644
>> --- a/StandaloneMmPkg/Core/Dispatcher.c
>> +++ b/StandaloneMmPkg/Core/Dispatcher.c
>> @@ -4,7 +4,7 @@
>>     Step #1 - When a FV protocol is added to the system every driver in the FV
>>               is added to the mDiscoveredList. The Before, and After Depex are
>>               pre-processed as drivers are added to the mDiscoveredList. If an Apriori
>> -            file exists in the FV those drivers are addeded to the
>> +            file exists in the FV those drivers are added to the
>>               mScheduledQueue. The mFwVolList is used to make sure a
>>               FV is only processed once.
>>
>> --
>> 2.31.1.windows.1
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76484): https://edk2.groups.io/g/devel/message/76484
Mute This Topic: https://groups.io/mt/83484181/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-