[edk2-devel] [PATCH 0/2] Quo vadis virtio-mmio?

Gerd Hoffmann posted 2 patches 2 years, 10 months ago
Failed in applying to current master (apply log)
OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 +++++++
.../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  1 +
.../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++++++---
.../VirtioMmioDeviceFunctions.c               | 31 +++++++++++++++++--
4 files changed, 54 insertions(+), 7 deletions(-)
[edk2-devel] [PATCH 0/2] Quo vadis virtio-mmio?
Posted by Gerd Hoffmann 2 years, 10 months ago
virtio-mmio support in ovmf seems to be the unloved child.  The final
virto-1.0 specification was published five(!) years ago, nevertheless
the mmio transport doesn't support it yet ...

Some people argue that it has been obsoleted by virtio-pci.  Which is a
valid argument.  But IMHO isn't a good reason to just let virtio-mmio
bitrot.  We should either remove it from the tree, or support it.

So, opening the discussion with this little patch series.  It does the
latter and adds virtio 1.0 support.  For the mmio transport the
difference between 0.9.5 and 1.0 is rather small (when compared to the
pci transport), it is just a bunch of new registers for the changed
virtio queue initialization.  So the patch series is small too ...

take care,
  Gerd

Gerd Hoffmann (2):
  OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines
  OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.

 OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 +++++++
 .../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  1 +
 .../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++++++---
 .../VirtioMmioDeviceFunctions.c               | 31 +++++++++++++++++--
 4 files changed, 54 insertions(+), 7 deletions(-)

-- 
2.31.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76247): https://edk2.groups.io/g/devel/message/76247
Mute This Topic: https://groups.io/mt/83414086/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 0/2] Quo vadis virtio-mmio?
Posted by Philippe Mathieu-Daudé 2 years, 10 months ago
On 6/9/21 7:05 AM, Gerd Hoffmann wrote:
> virtio-mmio support in ovmf seems to be the unloved child.  The final
> virto-1.0 specification was published five(!) years ago, nevertheless
> the mmio transport doesn't support it yet ...
> 
> Some people argue that it has been obsoleted by virtio-pci.  Which is a
> valid argument.  But IMHO isn't a good reason to just let virtio-mmio
> bitrot.  We should either remove it from the tree, or support it.
> 
> So, opening the discussion with this little patch series.  It does the
> latter and adds virtio 1.0 support.  For the mmio transport the
> difference between 0.9.5 and 1.0 is rather small (when compared to the
> pci transport), it is just a bunch of new registers for the changed
> virtio queue initialization.  So the patch series is small too ...
> 
> take care,
>   Gerd
> 
> Gerd Hoffmann (2):
>   OvmfPkg/Virtio10: Add virtio-mmio 1.0 defines
>   OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support.
> 
>  OvmfPkg/Include/IndustryStandard/Virtio10.h   | 12 +++++++
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.h    |  1 +
>  .../VirtioMmioDeviceLib/VirtioMmioDevice.c    | 17 +++++++---
>  .../VirtioMmioDeviceFunctions.c               | 31 +++++++++++++++++--
>  4 files changed, 54 insertions(+), 7 deletions(-)

Series:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76258): https://edk2.groups.io/g/devel/message/76258
Mute This Topic: https://groups.io/mt/83414086/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-