[edk2-devel] [PATCH 08/43] OvmfPkg/AcpiPlatformDxe/QemuLoader.h: remove QemuFwCfgLib class dependency

Laszlo Ersek posted 43 patches 4 years, 8 months ago
[edk2-devel] [PATCH 08/43] OvmfPkg/AcpiPlatformDxe/QemuLoader.h: remove QemuFwCfgLib class dependency
Posted by Laszlo Ersek 4 years, 8 months ago
"QemuLoader.h" needs the QEMU_FW_CFG_FNAME_SIZE macro. This macro used to
live in the QemuFwCfgLib class header, but we moved it to the more
foundational IndustryStandard include file called "QemuFwCfg.h" in commit
5583a8a4ffd0 ("OvmfPkg/QemuFwCfgLib: move types/macros from lib class to
IndustryStandard", 2017-02-22).

Replace the lib class dependency with the more basic IndustryStandard
dependency in "QemuLoader.h".

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/AcpiPlatformDxe/QemuLoader.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/AcpiPlatformDxe/QemuLoader.h b/OvmfPkg/AcpiPlatformDxe/QemuLoader.h
index bb3978e900ed..5782a23c4398 100644
--- a/OvmfPkg/AcpiPlatformDxe/QemuLoader.h
+++ b/OvmfPkg/AcpiPlatformDxe/QemuLoader.h
@@ -8,13 +8,13 @@
 **/
 
 #ifndef QEMU_LOADER_H_
 #define QEMU_LOADER_H_
 
 #include <Base.h>
-#include <Library/QemuFwCfgLib.h>
+#include <IndustryStandard/QemuFwCfg.h>
 
 //
 // The types and the documentation reflects the SeaBIOS interface.
 //
 #define QEMU_LOADER_FNAME_SIZE QEMU_FW_CFG_FNAME_SIZE
 
-- 
2.19.1.3.g30247aa5d201




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75677): https://edk2.groups.io/g/devel/message/75677
Mute This Topic: https://groups.io/mt/83110422/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH 08/43] OvmfPkg/AcpiPlatformDxe/QemuLoader.h: remove QemuFwCfgLib class dependency
Posted by Philippe Mathieu-Daudé 4 years, 8 months ago
On 5/26/21 10:14 PM, Laszlo Ersek wrote:
> "QemuLoader.h" needs the QEMU_FW_CFG_FNAME_SIZE macro. This macro used to
> live in the QemuFwCfgLib class header, but we moved it to the more
> foundational IndustryStandard include file called "QemuFwCfg.h" in commit
> 5583a8a4ffd0 ("OvmfPkg/QemuFwCfgLib: move types/macros from lib class to
> IndustryStandard", 2017-02-22).
> 
> Replace the lib class dependency with the more basic IndustryStandard
> dependency in "QemuLoader.h".
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  OvmfPkg/AcpiPlatformDxe/QemuLoader.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75763): https://edk2.groups.io/g/devel/message/75763
Mute This Topic: https://groups.io/mt/83110422/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-