[v3] Introduce Silicon/Ampere and AmpereAltraBinPkg package

[edk2-devel] [edk2-non-osi][PATCH v3 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package

Posted by Vu Nguyen via groups.io 2 years, 11 months ago

Create edk2-non-osi component holder for Ampere Libraries. This patchset
also adds PciePhyLib which provides function to initialize PCIe PHY on
Ampere Altra processor.

Commits in this patchset can be found at:
https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Phong Vo <phong@os.amperecomputing.com>
Cc: Thang Nguyen <thang@os.amperecomputing.com>

Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>

Change since v2:
  Remove unused macros and function prototypes from the header file.
  Rename Ac01BinPkg.dec to AmpereAltraBinPkg.dec.

Change since v1:
  Remove PciePhyLib.lib binary from the commit.
  Update header guard to align with coding standard.

Vu Nguyen (2):
  AmpereAltraBinPkg: Add PciePhyLib library and header
  edk2-non-osi: Add AmpereAltraBinPkg maintainers

 Maintainers.txt                               |   4 +
 Silicon/Ampere/License.txt                    |  25 ++++
 .../AmpereAltraBinPkg/AmpereAltraBinPkg.dec   |  16 +++
 .../Library/PciePhyLib/PciePhyLib.inf         |  23 ++++
 .../Include/Library/PciePhyLib.h              | 111 ++++++++++++++++++
 5 files changed, 179 insertions(+)
 create mode 100644 Silicon/Ampere/License.txt
 create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec
 create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
 create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h

-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75642): https://edk2.groups.io/g/devel/message/75642
Mute This Topic: https://groups.io/mt/83097263/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-non-osi][PATCH v3 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package

Posted by Leif Lindholm 2 years, 11 months ago

Hi Vu,

For this set:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Is there any value to you in me pushing this before the edk2-platforms
set goes in? If not, I'll hold back and push them both at the same
time.

Best Regards,

Leif

On Wed, May 26, 2021 at 17:18:28 +0700, Vu Nguyen wrote:
> Create edk2-non-osi component holder for Ampere Libraries. This patchset
> also adds PciePhyLib which provides function to initialize PCIe PHY on
> Ampere Altra processor.
> 
> Commits in this patchset can be found at:
> https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Phong Vo <phong@os.amperecomputing.com>
> Cc: Thang Nguyen <thang@os.amperecomputing.com>
> 
> Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>
> 
> Change since v2:
>   Remove unused macros and function prototypes from the header file.
>   Rename Ac01BinPkg.dec to AmpereAltraBinPkg.dec.
> 
> Change since v1:
>   Remove PciePhyLib.lib binary from the commit.
>   Update header guard to align with coding standard.
> 
> Vu Nguyen (2):
>   AmpereAltraBinPkg: Add PciePhyLib library and header
>   edk2-non-osi: Add AmpereAltraBinPkg maintainers
> 
>  Maintainers.txt                               |   4 +
>  Silicon/Ampere/License.txt                    |  25 ++++
>  .../AmpereAltraBinPkg/AmpereAltraBinPkg.dec   |  16 +++
>  .../Library/PciePhyLib/PciePhyLib.inf         |  23 ++++
>  .../Include/Library/PciePhyLib.h              | 111 ++++++++++++++++++
>  5 files changed, 179 insertions(+)
>  create mode 100644 Silicon/Ampere/License.txt
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
> 
> -- 
> 2.17.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76073): https://edk2.groups.io/g/devel/message/76073
Mute This Topic: https://groups.io/mt/83097263/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-non-osi][PATCH v3 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package

Posted by Vu Nguyen via groups.io 2 years, 10 months ago

Hi Leif,

It's just fine. But I hope this patch will be pushed before 
edk2-platforms to prevent compile error.

Regards,

Vu

On 6/4/2021 20:43, Leif Lindholm wrote:
> Hi Vu,
>
> For this set:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
> Is there any value to you in me pushing this before the edk2-platforms
> set goes in? If not, I'll hold back and push them both at the same
> time.
>
> Best Regards,
>
> Leif
>
> On Wed, May 26, 2021 at 17:18:28 +0700, Vu Nguyen wrote:
>> Create edk2-non-osi component holder for Ampere Libraries. This patchset
>> also adds PciePhyLib which provides function to initialize PCIe PHY on
>> Ampere Altra processor.
>>
>> Commits in this patchset can be found at:
>> https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib
>>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Chuong Tran <chuong@os.amperecomputing.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Phong Vo <phong@os.amperecomputing.com>
>> Cc: Thang Nguyen <thang@os.amperecomputing.com>
>>
>> Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>
>>
>> Change since v2:
>>    Remove unused macros and function prototypes from the header file.
>>    Rename Ac01BinPkg.dec to AmpereAltraBinPkg.dec.
>>
>> Change since v1:
>>    Remove PciePhyLib.lib binary from the commit.
>>    Update header guard to align with coding standard.
>>
>> Vu Nguyen (2):
>>    AmpereAltraBinPkg: Add PciePhyLib library and header
>>    edk2-non-osi: Add AmpereAltraBinPkg maintainers
>>
>>   Maintainers.txt                               |   4 +
>>   Silicon/Ampere/License.txt                    |  25 ++++
>>   .../AmpereAltraBinPkg/AmpereAltraBinPkg.dec   |  16 +++
>>   .../Library/PciePhyLib/PciePhyLib.inf         |  23 ++++
>>   .../Include/Library/PciePhyLib.h              | 111 ++++++++++++++++++
>>   5 files changed, 179 insertions(+)
>>   create mode 100644 Silicon/Ampere/License.txt
>>   create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec
>>   create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
>>   create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
>>
>> -- 
>> 2.17.1
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76273): https://edk2.groups.io/g/devel/message/76273
Mute This Topic: https://groups.io/mt/83097263/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-