[edk2-devel] [edk2-platforms][PATCH V4 00/11] Add SMBIOS tables for Arm's Reference Design platforms

Pranav Madhu posted 11 patches 2 years, 11 months ago
Failed in applying to current master (apply log)
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc       |  11 +
Platform/ARM/SgiPkg/SgiPlatform.fdf           |   8 +-
.../SmbiosPlatformDxe/SmbiosPlatformDxe.inf   |  62 +++
.../SmbiosPlatformDxe/SmbiosPlatformDxe.h     | 197 +++++++++
Platform/ARM/SgiPkg/Include/SgiPlatform.h     |  36 +-
.../SmbiosPlatformDxe/SmbiosPlatformDxe.c     | 106 +++++
.../SmbiosPlatformDxe/Type0BiosInformation.c  | 135 ++++++
.../Type16PhysicalMemoryArray.c               | 106 +++++
.../SmbiosPlatformDxe/Type17MemoryDevice.c    | 409 ++++++++++++++++++
.../Type19MemoryArrayMappedAddress.c          |  97 +++++
.../Type1SystemInformation.c                  | 142 ++++++
.../Type32SystemBootInformation.c             |  84 ++++
.../SmbiosPlatformDxe/Type3SystemEnclosure.c  | 103 +++++
.../Type4ProcessorInformation.c               | 219 ++++++++++
.../SmbiosPlatformDxe/Type7CacheInformation.c | 342 +++++++++++++++
.../SgiPkg/Library/PlatformLib/PlatformLib.c  |  86 +++-
16 files changed, 2140 insertions(+), 3 deletions(-)
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type0BiosInformation.c
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type16PhysicalMemoryArray.c
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type19MemoryArrayMappedAddress.c
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type32SystemBootInformation.c
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type3SystemEnclosure.c
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c
[edk2-devel] [edk2-platforms][PATCH V4 00/11] Add SMBIOS tables for Arm's Reference Design platforms
Posted by Pranav Madhu 2 years, 11 months ago
Changes since V3:
- Add UpdateMemorySize API to update memory size information as suggested by Sami.

Changes since V2:
- Addressed comments from Sami
- Picked up Sami's reviewed-by tags.

Changes since V1:
- Rebase the patches on top of latest master branch

SMBIOS provides basic hardware and firmware configuration information
through table-driven data structure. This patch series adds SMBIOS
support for Arm's SGI/RD platforms.

The first patch in this series defines platform-id values for the
RD-N2 platform library header. The second patch add SgiGetProductId API,
which is used by the SMBIOS driver to distinguish between the platforms,
and install the right table. The third patch in this series adds SMBIOS
driver support that allows for installation of multiple SMBIOS tables.
And subsequent patches in this series add SMBIOS tables, which are
mandatory as per Arm serverready SBBR specification.

Link to github branch with the patches in this series -
https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rd_smbios

Pranav Madhu (11):
  Platform/Sgi: Define RD-N2 platform id values
  Platform/Sgi: Add GetProductId API for SGI/RD Platforms
  Platform/Sgi: Add Initial SMBIOS support
  Platform/Sgi: Add SMBIOS Type1 Table
  Platform/Sgi: Add SMBIOS Type3 Table
  Platform/Sgi: Add SMBIOS Type4 Table
  Platform/Sgi: Add SMBIOS Type7 Table
  Platform/Sgi: Add SMBIOS Type16 Table
  Platform/Sgi: Add SMBIOS Type17 Table
  Platform/Sgi: Add SMBIOS Type19 Table
  Platform/Sgi: Add SMBIOS Type32 Table

 Platform/ARM/SgiPkg/SgiPlatform.dsc.inc       |  11 +
 Platform/ARM/SgiPkg/SgiPlatform.fdf           |   8 +-
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf   |  62 +++
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.h     | 197 +++++++++
 Platform/ARM/SgiPkg/Include/SgiPlatform.h     |  36 +-
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.c     | 106 +++++
 .../SmbiosPlatformDxe/Type0BiosInformation.c  | 135 ++++++
 .../Type16PhysicalMemoryArray.c               | 106 +++++
 .../SmbiosPlatformDxe/Type17MemoryDevice.c    | 409 ++++++++++++++++++
 .../Type19MemoryArrayMappedAddress.c          |  97 +++++
 .../Type1SystemInformation.c                  | 142 ++++++
 .../Type32SystemBootInformation.c             |  84 ++++
 .../SmbiosPlatformDxe/Type3SystemEnclosure.c  | 103 +++++
 .../Type4ProcessorInformation.c               | 219 ++++++++++
 .../SmbiosPlatformDxe/Type7CacheInformation.c | 342 +++++++++++++++
 .../SgiPkg/Library/PlatformLib/PlatformLib.c  |  86 +++-
 16 files changed, 2140 insertions(+), 3 deletions(-)
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type0BiosInformation.c
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type16PhysicalMemoryArray.c
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type19MemoryArrayMappedAddress.c
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type32SystemBootInformation.c
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type3SystemEnclosure.c
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
 create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c

-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75522): https://edk2.groups.io/g/devel/message/75522
Mute This Topic: https://groups.io/mt/83052318/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms][PATCH V4 00/11] Add SMBIOS tables for Arm's Reference Design platforms
Posted by Sami Mujawar 2 years, 11 months ago
Hi Ard,

EDKII is in hard feature freeze starting 2021-05-24 (See 
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning). 


However, does this apply to the edk2-platforms repo as well? Can you let 
me know, please?

Regards,

Sami Mujawar

On 24/05/2021 03:28 PM, Pranav Madhu wrote:
> Changes since V3:
> - Add UpdateMemorySize API to update memory size information as suggested by Sami.
>
> Changes since V2:
> - Addressed comments from Sami
> - Picked up Sami's reviewed-by tags.
>
> Changes since V1:
> - Rebase the patches on top of latest master branch
>
> SMBIOS provides basic hardware and firmware configuration information
> through table-driven data structure. This patch series adds SMBIOS
> support for Arm's SGI/RD platforms.
>
> The first patch in this series defines platform-id values for the
> RD-N2 platform library header. The second patch add SgiGetProductId API,
> which is used by the SMBIOS driver to distinguish between the platforms,
> and install the right table. The third patch in this series adds SMBIOS
> driver support that allows for installation of multiple SMBIOS tables.
> And subsequent patches in this series add SMBIOS tables, which are
> mandatory as per Arm serverready SBBR specification.
>
> Link to github branch with the patches in this series -
> https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rd_smbios
>
> Pranav Madhu (11):
>    Platform/Sgi: Define RD-N2 platform id values
>    Platform/Sgi: Add GetProductId API for SGI/RD Platforms
>    Platform/Sgi: Add Initial SMBIOS support
>    Platform/Sgi: Add SMBIOS Type1 Table
>    Platform/Sgi: Add SMBIOS Type3 Table
>    Platform/Sgi: Add SMBIOS Type4 Table
>    Platform/Sgi: Add SMBIOS Type7 Table
>    Platform/Sgi: Add SMBIOS Type16 Table
>    Platform/Sgi: Add SMBIOS Type17 Table
>    Platform/Sgi: Add SMBIOS Type19 Table
>    Platform/Sgi: Add SMBIOS Type32 Table
>
>   Platform/ARM/SgiPkg/SgiPlatform.dsc.inc       |  11 +
>   Platform/ARM/SgiPkg/SgiPlatform.fdf           |   8 +-
>   .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf   |  62 +++
>   .../SmbiosPlatformDxe/SmbiosPlatformDxe.h     | 197 +++++++++
>   Platform/ARM/SgiPkg/Include/SgiPlatform.h     |  36 +-
>   .../SmbiosPlatformDxe/SmbiosPlatformDxe.c     | 106 +++++
>   .../SmbiosPlatformDxe/Type0BiosInformation.c  | 135 ++++++
>   .../Type16PhysicalMemoryArray.c               | 106 +++++
>   .../SmbiosPlatformDxe/Type17MemoryDevice.c    | 409 ++++++++++++++++++
>   .../Type19MemoryArrayMappedAddress.c          |  97 +++++
>   .../Type1SystemInformation.c                  | 142 ++++++
>   .../Type32SystemBootInformation.c             |  84 ++++
>   .../SmbiosPlatformDxe/Type3SystemEnclosure.c  | 103 +++++
>   .../Type4ProcessorInformation.c               | 219 ++++++++++
>   .../SmbiosPlatformDxe/Type7CacheInformation.c | 342 +++++++++++++++
>   .../SgiPkg/Library/PlatformLib/PlatformLib.c  |  86 +++-
>   16 files changed, 2140 insertions(+), 3 deletions(-)
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type0BiosInformation.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type16PhysicalMemoryArray.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type19MemoryArrayMappedAddress.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type32SystemBootInformation.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type3SystemEnclosure.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75535): https://edk2.groups.io/g/devel/message/75535
Mute This Topic: https://groups.io/mt/83052318/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-platforms][PATCH V4 00/11] Add SMBIOS tables for Arm's Reference Design platforms
Posted by Sami Mujawar 2 years, 11 months ago
Pushed as 86984c17d562..8cdd4cb7c71e, with minor changes to patch 4 and 7.

Thanks.

Regards,

Sami Mujawar


On 24/05/2021 03:28 PM, Pranav Madhu wrote:
> Changes since V3:
> - Add UpdateMemorySize API to update memory size information as suggested by Sami.
>
> Changes since V2:
> - Addressed comments from Sami
> - Picked up Sami's reviewed-by tags.
>
> Changes since V1:
> - Rebase the patches on top of latest master branch
>
> SMBIOS provides basic hardware and firmware configuration information
> through table-driven data structure. This patch series adds SMBIOS
> support for Arm's SGI/RD platforms.
>
> The first patch in this series defines platform-id values for the
> RD-N2 platform library header. The second patch add SgiGetProductId API,
> which is used by the SMBIOS driver to distinguish between the platforms,
> and install the right table. The third patch in this series adds SMBIOS
> driver support that allows for installation of multiple SMBIOS tables.
> And subsequent patches in this series add SMBIOS tables, which are
> mandatory as per Arm serverready SBBR specification.
>
> Link to github branch with the patches in this series -
> https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rd_smbios
>
> Pranav Madhu (11):
>    Platform/Sgi: Define RD-N2 platform id values
>    Platform/Sgi: Add GetProductId API for SGI/RD Platforms
>    Platform/Sgi: Add Initial SMBIOS support
>    Platform/Sgi: Add SMBIOS Type1 Table
>    Platform/Sgi: Add SMBIOS Type3 Table
>    Platform/Sgi: Add SMBIOS Type4 Table
>    Platform/Sgi: Add SMBIOS Type7 Table
>    Platform/Sgi: Add SMBIOS Type16 Table
>    Platform/Sgi: Add SMBIOS Type17 Table
>    Platform/Sgi: Add SMBIOS Type19 Table
>    Platform/Sgi: Add SMBIOS Type32 Table
>
>   Platform/ARM/SgiPkg/SgiPlatform.dsc.inc       |  11 +
>   Platform/ARM/SgiPkg/SgiPlatform.fdf           |   8 +-
>   .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf   |  62 +++
>   .../SmbiosPlatformDxe/SmbiosPlatformDxe.h     | 197 +++++++++
>   Platform/ARM/SgiPkg/Include/SgiPlatform.h     |  36 +-
>   .../SmbiosPlatformDxe/SmbiosPlatformDxe.c     | 106 +++++
>   .../SmbiosPlatformDxe/Type0BiosInformation.c  | 135 ++++++
>   .../Type16PhysicalMemoryArray.c               | 106 +++++
>   .../SmbiosPlatformDxe/Type17MemoryDevice.c    | 409 ++++++++++++++++++
>   .../Type19MemoryArrayMappedAddress.c          |  97 +++++
>   .../Type1SystemInformation.c                  | 142 ++++++
>   .../Type32SystemBootInformation.c             |  84 ++++
>   .../SmbiosPlatformDxe/Type3SystemEnclosure.c  | 103 +++++
>   .../Type4ProcessorInformation.c               | 219 ++++++++++
>   .../SmbiosPlatformDxe/Type7CacheInformation.c | 342 +++++++++++++++
>   .../SgiPkg/Library/PlatformLib/PlatformLib.c  |  86 +++-
>   16 files changed, 2140 insertions(+), 3 deletions(-)
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type0BiosInformation.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type16PhysicalMemoryArray.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type17MemoryDevice.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type19MemoryArrayMappedAddress.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type32SystemBootInformation.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type3SystemEnclosure.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
>   create mode 100644 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75916): https://edk2.groups.io/g/devel/message/75916
Mute This Topic: https://groups.io/mt/83052318/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-