Silicon/StMMRpmb: Consume MdeLibs.dsc.inc for RegisterFilterLib

[edk2-devel] [PATCH] Silicon/StMMRpmb: Consume MdeLibs.dsc.inc for RegisterFilterLib

Posted by Ilias Apalodimas 2 years, 11 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246

MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg and RegisterFilterLibNull Library
was also added into it as the first version of MdeLibs.dsc.inc.

So update platform dsc to consume MdeLibs.dsc.inc for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 .../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc        | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
index f99a47ebf605..266e2297dd09 100644
--- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
+++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
@@ -22,6 +22,8 @@
   FLASH_DEFINITION               = Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.fdf
   DEFINE DEBUG_MESSAGE           = TRUE
 
+  !include MdePkg/MdeLibs.dsc.inc
+
 ################################################################################
 #
 # Library Class section - list of all Library Classes needed by this Platform.
-- 
2.31.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75468): https://edk2.groups.io/g/devel/message/75468
Mute This Topic: https://groups.io/mt/83036266/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Silicon/StMMRpmb: Consume MdeLibs.dsc.inc for RegisterFilterLib

Posted by Sami Mujawar 2 years, 11 months ago

Hi Ilias,

Thank you for this patch.

I think this change may have been covered in https://edk2.groups.io/g/devel/topic/82880299#75180. However, this is an independent fix that is needed to the current code (before the 32-bit support is merged).

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: Sunday, 23 May 2021 at 21:16
To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>
Cc: ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, leif@nuviainc.com <leif@nuviainc.com>, Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: [PATCH] Silicon/StMMRpmb: Consume MdeLibs.dsc.inc for RegisterFilterLib
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246

MdeLibs.dsc.inc was added for some basic/default library
instances provided by MdePkg and RegisterFilterLibNull Library
was also added into it as the first version of MdeLibs.dsc.inc.

So update platform dsc to consume MdeLibs.dsc.inc for
RegisterFilterLibNull which will be consumed by IoLib and BaseLib.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 .../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc        | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
index f99a47ebf605..266e2297dd09 100644
--- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
+++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
@@ -22,6 +22,8 @@
   FLASH_DEFINITION               = Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.fdf

   DEFINE DEBUG_MESSAGE           = TRUE



+  !include MdePkg/MdeLibs.dsc.inc

+

 ################################################################################

 #

 # Library Class section - list of all Library Classes needed by this Platform.

--
2.31.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75494): https://edk2.groups.io/g/devel/message/75494
Mute This Topic: https://groups.io/mt/83036266/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Silicon/StMMRpmb: Consume MdeLibs.dsc.inc for RegisterFilterLib

Posted by Ilias Apalodimas 2 years, 11 months ago

Hi Sami,

Indeed I forgot about that patchset!
Since Etienne's patches are reviewed already, feel free to ignore this
so he won't need to rebase his code.

Thanks
/Ilias

On Mon, 24 May 2021 at 11:12, Sami Mujawar <Sami.Mujawar@arm.com> wrote:
>
> Hi Ilias,
>
>
>
> Thank you for this patch.
>
>
>
> I think this change may have been covered in https://edk2.groups.io/g/devel/topic/82880299#75180. However, this is an independent fix that is needed to the current code (before the 32-bit support is merged).
>
>
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
>
>
> Regards,
>
>
>
> Sami Mujawar
>
>
>
> From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Date: Sunday, 23 May 2021 at 21:16
> To: devel@edk2.groups.io <devel@edk2.groups.io>, Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>, leif@nuviainc.com <leif@nuviainc.com>, Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Subject: [PATCH] Silicon/StMMRpmb: Consume MdeLibs.dsc.inc for RegisterFilterLib
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
>
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> ---
>  .../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc        | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> index f99a47ebf605..266e2297dd09 100644
> --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> @@ -22,6 +22,8 @@
>    FLASH_DEFINITION               = Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.fdf
>
>    DEFINE DEBUG_MESSAGE           = TRUE
>
>
>
> +  !include MdePkg/MdeLibs.dsc.inc
>
> +
>
>  ################################################################################
>
>  #
>
>  # Library Class section - list of all Library Classes needed by this Platform.
>
> --
> 2.31.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75495): https://edk2.groups.io/g/devel/message/75495
Mute This Topic: https://groups.io/mt/83036266/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-